Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 13 Sep 2022 20:29:50 +0530
From:   "Ritesh Harjani (IBM)" <ritesh.list@gmail.com>
To:     Zhiqiang Liu <liuzhiqiang26@huawei.com>
Cc:     tytso@mit.edu, Ext4 Developers List <linux-ext4@vger.kernel.org>,
        linfeilong <linfeilong@huawei.com>,
        zhanchengbin <zhanchengbin1@huawei.com>,
        wuguanghao <wuguanghao3@huawei.com>
Subject: Re: [PATCH] ext2fs_open2: goto cleanup tag when
 image_header->magic_number != EXT2_ET_MAGIC_E2IMAGE
Message-ID: <20220913145950.t2fwkeihjgas55kj@riteshh-domain>
References: <703f5bf7-fd63-ad0a-fcbb-0b5affd31d53@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <703f5bf7-fd63-ad0a-fcbb-0b5affd31d53@huawei.com>
Precedence: bulk

On 22/09/13 09:14PM, Zhiqiang Liu wrote:
> 
> In ext2fs_open2(), fs->image_header is assigned by calling io_channel_read_blk,
> successfully. If fs->image_header->magic_number is not equal to EXT2_ET_MAGIC_E2IMAGE,
> we should go to cleanup tag to free resouce and return errcode (EXT2_ET_MAGIC_E2IMAGE).
> 
> Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
> ---
>  lib/ext2fs/openfs.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Looks good to me. Feel free to add - 
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>

-ritesh