Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp7222665rwn; Tue, 13 Sep 2022 16:26:28 -0700 (PDT) X-Google-Smtp-Source: AA6agR46aDvSdEwHQO8cUbCdB/BFazey/kUJYVRvUc69sTRlBQPxvgtz/bdbuio/C3I3WY1aC2DP X-Received: by 2002:a63:2c8b:0:b0:41c:5f9e:a1d6 with SMTP id s133-20020a632c8b000000b0041c5f9ea1d6mr29105890pgs.601.1663111588330; Tue, 13 Sep 2022 16:26:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663111588; cv=none; d=google.com; s=arc-20160816; b=Tq8HS5oHC2hO9oSQOSfPJkVoaMWMSQfXWmeq+jRL1caPLAUlGBo8/nUaaeZHPJVNaR Hy5oGnSA88gSIyhbYOoiaaf8AQhhVoMdg18Ah1mMAt5TmRGa3VJl4UhXNrrJ0So6WPba sI+6pWMORFe648xJneB+tixGhQjFXzH66WjhkoXKStFp62CxUNP6PCaUtnFMHLZ8hfe0 XI763XfA4Dnsm5iJ+wNSSkReL9u1fBC+mZCYY1sSe6JqUffCUBUY1+EkO8vOdVTiTmXb KiX6BS2CrcdCI3IZLHVh3pbU3s/sIXWgByc3H6KAxs5x9fJDVnyVaP5bCu+0TbcJ+O7t Ookw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:references:in-reply-to:subject :cc:to:from:mime-version:content-transfer-encoding:dkim-signature :dkim-signature; bh=lCZbTt8MqzDxXBhNECVaeYq92wrfjuXQyXb1QCL9L08=; b=JTZMOQO3U1k+8rY7IcgnraUE18vrfZHq503QJjr1PMnemtjjq1hOMv/q/yiFOnJq8Q h844Q/SbkxBJg0t5RXkRLTKlq8TrX7r9I3SwK7GmRrGrvuoMd7WJuMF6nD3Ii3/YnxK4 VB7ohyfxqhEWtj2KvJI9NAYtww1rza+WL4LUwDq/+n0fa5LSszy6HK7B+nAzXJ9ridQK pCOBApZVJlt6d63gfwCZfjso8xQd9MwTkzp/nBiielb871YUnCq60YWfGVGoIQmVZ1fs PwwsPJto6zn5edqGvIJh5Y/8KlJvSF+Q9bKJ+Rp8DBoZ7AYGx5rb4whLCFFJYySzQ7gF XMSg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=xlbgGCcX; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=f3V4jz9c; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g7-20020a056a000b8700b00545f8bf5f6bsi3510048pfj.274.2022.09.13.16.26.14; Tue, 13 Sep 2022 16:26:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=xlbgGCcX; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=f3V4jz9c; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229478AbiIMXYS (ORCPT + 99 others); Tue, 13 Sep 2022 19:24:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40396 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229456AbiIMXYR (ORCPT ); Tue, 13 Sep 2022 19:24:17 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9778227DE6; Tue, 13 Sep 2022 16:24:16 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 111195C81A; Tue, 13 Sep 2022 23:24:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1663111455; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lCZbTt8MqzDxXBhNECVaeYq92wrfjuXQyXb1QCL9L08=; b=xlbgGCcX1vaqfVo0T7/7HHkGJClHbYwVmCkEjYU+yukwvWlmi/KV4I9oCfaEa4wMX0rAE+ SEsmeldoOIOeCxP5qYRC+CdkHQdKTtaC4+4AbfA5fyhqvZZp3SIKD2vcprwsRNYTCxFz9M JLUB3aTflnqVKCKYq+IrL7uyVXYqhBc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1663111455; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lCZbTt8MqzDxXBhNECVaeYq92wrfjuXQyXb1QCL9L08=; b=f3V4jz9cjD4/+YabArl2nlr3TvCKBf+HRA2DIYhIcYM7hGDyhFP9+9JyddEfjRtGauQ9MS eeY+o8dgRHryQzBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A5AC313AB5; Tue, 13 Sep 2022 23:24:06 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id DEmgFxYRIWMlZgAAMHmgww (envelope-from ); Tue, 13 Sep 2022 23:24:06 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 From: "NeilBrown" To: "Jeff Layton" Cc: "Dave Chinner" , "Trond Myklebust" , "zohar@linux.ibm.com" , "djwong@kernel.org" , "xiubli@redhat.com" , "brauner@kernel.org" , "linux-xfs@vger.kernel.org" , "linux-api@vger.kernel.org" , "bfields@fieldses.org" , "fweimer@redhat.com" , "linux-kernel@vger.kernel.org" , "chuck.lever@oracle.com" , "linux-man@vger.kernel.org" , "linux-nfs@vger.kernel.org" , "tytso@mit.edu" , "viro@zeniv.linux.org.uk" , "jack@suse.cz" , "linux-ext4@vger.kernel.org" , "linux-btrfs@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "adilger.kernel@dilger.ca" , "lczerner@redhat.com" , "ceph-devel@vger.kernel.org" Subject: Re: [man-pages RFC PATCH v4] statx, inode: document the new STATX_INO_VERSION field In-reply-to: References: <91e31d20d66d6f47fe12c80c34b1cffdfc202b6a.camel@hammerspace.com>, <166268467103.30452.1687952324107257676@noble.neil.brown.name>, <166268566751.30452.13562507405746100242@noble.neil.brown.name>, <29a6c2e78284e7947ddedf71e5cb9436c9330910.camel@hammerspace.com>, <8d638cb3c63b0d2da8679b5288d1622fdb387f83.camel@hammerspace.com>, <166270570118.30452.16939807179630112340@noble.neil.brown.name>, <33d058be862ccc0ccaf959f2841a7e506e51fd1f.camel@kernel.org>, <166285038617.30452.11636397081493278357@noble.neil.brown.name>, <2e34a7d4e1a3474d80ee0402ed3bc0f18792443a.camel@kernel.org>, <166302538820.30452.7783524836504548113@noble.neil.brown.name>, <20220913011518.GE3600936@dread.disaster.area>, Date: Wed, 14 Sep 2022 09:24:02 +1000 Message-id: <166311144203.20483.1888757883086697314@noble.neil.brown.name> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, 14 Sep 2022, Jeff Layton wrote: > > At that point, bumping i_version both before and after makes a bit more > sense, since it better ensures that a change will be noticed, whether > the related read op comes before or after the statx. How does bumping it before make any sense at all? Maybe it wouldn't hurt much, but how does it help anyone at all? i_version must appear to change no sooner than the change it reflects becomes visible and no later than the request which initiated that change is acknowledged as complete. Why would that definition ever not be satisfactory? NeilBrown