Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH -next 2/2] ext4: adjust fast commit disable judgement
 order in ext4_fc_track_inode
To:     Jan Kara <jack@suse.cz>
References: <20220915135611.3040776-1-yebin10@huawei.com>
 <20220915135611.3040776-3-yebin10@huawei.com>
 <20220915143008.27woacjur6sg32t2@quack3>
CC:     <tytso@mit.edu>, <adilger.kernel@dilger.ca>,
        <linux-ext4@vger.kernel.org>, <linux-kernel@vger.kernel.org>
From:   yebin <yebin10@huawei.com>
Message-ID: <632339F2.1000802@huawei.com>
Date:   Thu, 15 Sep 2022 22:42:58 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.1.0
MIME-Version: 1.0
In-Reply-To: <20220915143008.27woacjur6sg32t2@quack3>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2022/9/15 22:30, Jan Kara wrote:
> On Thu 15-09-22 21:56:11, Ye Bin wrote:
>> Judge filesystem if fast commit disabled before test inode's journal mode.
>>
>> Signed-off-by: Ye Bin <yebin10@huawei.com>
> Probably makes sense but is there any particular reason why you do this?
>
> 								Honza

I think the impact of fast commit on normal processes should be minimized.

>
>> ---
>>   fs/ext4/fast_commit.c | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/fs/ext4/fast_commit.c b/fs/ext4/fast_commit.c
>> index eadab945b856..9217a588afd1 100644
>> --- a/fs/ext4/fast_commit.c
>> +++ b/fs/ext4/fast_commit.c
>> @@ -577,15 +577,15 @@ void ext4_fc_track_inode(handle_t *handle, struct inode *inode)
>>   	if (S_ISDIR(inode->i_mode))
>>   		return;
>>   
>> +	if (ext4_fc_disabled(inode->i_sb))
>> +		return;
>> +
>>   	if (ext4_should_journal_data(inode)) {
>>   		ext4_fc_mark_ineligible(inode->i_sb,
>>   					EXT4_FC_REASON_INODE_JOURNAL_DATA, handle);
>>   		return;
>>   	}
>>   
>> -	if (ext4_fc_disabled(inode->i_sb))
>> -		return;
>> -
>>   	if (ext4_test_mount_flag(inode->i_sb, EXT4_MF_FC_INELIGIBLE))
>>   		return;
>>   
>> -- 
>> 2.31.1
>>