Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp142382rwb; Sat, 17 Sep 2022 02:29:49 -0700 (PDT) X-Google-Smtp-Source: AMsMyM41B9L/poUl5OmH/g8WgvGuhp0TGkWabj+dfUUrjckn7+12UUW0/Yg/Z0DqTRbLkLHBYFdT X-Received: by 2002:a05:6402:5246:b0:452:76a7:934d with SMTP id t6-20020a056402524600b0045276a7934dmr7279853edd.137.1663406989652; Sat, 17 Sep 2022 02:29:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663406989; cv=none; d=google.com; s=arc-20160816; b=Ix9VrcaP7dU4nEtzLw4zTU37Qlgu1GTa9HEeKIsGci4R4g3Iqq/ZBHHdM154ayJHpU 6+QVuST64zbfk1sZ/b3kqAjq5DRkrkeU87yu1/On2YtbYu7aaMriXFq1wCW1Llqzh4gF NiXWD6GQyFwNae+CKVgTvFEBSbbOj2+LUqQNWqt9GXEH+rNixJDh9UB5pjFsTtPwLeQq q9/RqZ8k+Z8I0+AUXlS5oJ3rU/ZMCg00ue3V/zwYilGE3vUXmW80fJuAYAgQimOcAwiT 03PMBwnqlAfQoXNQaHEMt0lsuwP75iNsgUXH31fanEbqjkGKid5y/yjtthQcQTeIOPOy Rixw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=dfScG+vLLKVj7NAnQO+lP0Aj3+Tat28Dqs5YgUBAaNk=; b=DRnrEDviiEdEBryGWjx1ITMz128a/ACZjtj5EaJHpS9enNO6nhbM4tr7Zuc21xGBMi h1fhAayOD60IJtF6TjD4oU47v2Eds5n/DB89Vz2UKn2qpR7TC/N+m325xmEaN7GyIuhw IYfpgXmGHuhoGSa/WpvdXHofTN+rDQ/3akYMLd1NAYdxqcEzM/5PzczA9UpI6RRI7uBz u8HM5LG0a+jkvY4vXdExaIPT1Z2P/WO5c0IgGs02mI6ChsWm96sxtazizoTpR+9Aa7IP tdLI7I3vTqTrLKN74PseR73EEOt3un0doTBYFG6WbpHWiIKFwss76sVyyGVunNx9zB8W guow== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h10-20020a0564020e8a00b004534bda3de1si3467678eda.301.2022.09.17.02.29.12; Sat, 17 Sep 2022 02:29:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229542AbiIQJ1R (ORCPT + 99 others); Sat, 17 Sep 2022 05:27:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229471AbiIQJ1Q (ORCPT ); Sat, 17 Sep 2022 05:27:16 -0400 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6C4A45981; Sat, 17 Sep 2022 02:27:14 -0700 (PDT) Received: from canpemm500010.china.huawei.com (unknown [172.30.72.57]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4MV58G4lZYz14QPC; Sat, 17 Sep 2022 17:23:10 +0800 (CST) Received: from huawei.com (10.175.127.227) by canpemm500010.china.huawei.com (7.192.105.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sat, 17 Sep 2022 17:27:11 +0800 From: Ye Bin To: , , CC: , , Ye Bin Subject: [PATCH -next] jbd2: add miss release buffer head in fc_do_one_pass() Date: Sat, 17 Sep 2022 17:38:05 +0800 Message-ID: <20220917093805.1782845-1-yebin10@huawei.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.127.227] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To canpemm500010.china.huawei.com (7.192.105.118) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org In fc_do_one_pass() miss release buffer head after use which will lead to reference count leak. Signed-off-by: Ye Bin --- fs/jbd2/recovery.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/jbd2/recovery.c b/fs/jbd2/recovery.c index 1f878c315b03..8286a9ec122f 100644 --- a/fs/jbd2/recovery.c +++ b/fs/jbd2/recovery.c @@ -261,6 +261,7 @@ static int fc_do_one_pass(journal_t *journal, err = journal->j_fc_replay_callback(journal, bh, pass, next_fc_block - journal->j_fc_first, expected_commit_id); + brelse(bh); next_fc_block++; if (err < 0 || err == JBD2_FC_REPLAY_STOP) break; -- 2.31.1