Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp1326012rwb; Sun, 18 Sep 2022 05:24:43 -0700 (PDT) X-Google-Smtp-Source: AMsMyM58oHFI6+X+pgtn9UvmCS6M3PxdLpY7bsXj7/OXmul+PeDfbdWKPya7MrJnaUXO8W2pyvxl X-Received: by 2002:a17:902:e801:b0:178:11e9:2ba2 with SMTP id u1-20020a170902e80100b0017811e92ba2mr8036278plg.26.1663503883710; Sun, 18 Sep 2022 05:24:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663503883; cv=none; d=google.com; s=arc-20160816; b=yhINAby+JJtn+uLyG9Ht6qo5KTflJoNlsdnLwVWklRPlLV2tYxB5w6CJaGsrel69JS TJHTGTQz3zregn6zfOcrVl2+PUBHvpJZmMpDFI1rdi/8OUw++AY+ELvQKhmm9v9rUgWo JCn1iD8W3ktiqaTW9vaZawEp4Q9GISG80bQ8skgIsQ6kbu10oIWfXZO+2rsbOdxOk7go W8xdUHl2l+45U8V/i4LPG64RUt6ydBcULXlunBZydqODqvwHTQZdoZEtAafi5aOV9e5c yoIjjhS30btDGoO3+TJQDk/mT2UIoANKFQzI5bSjXStuoMicw2YW8nG3X+Tzysg9Yn0L eAvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=oVBZfho8PdQ5yA76guiErK3yYPbS35fkQsCtJXulPpk=; b=p67UlpnWbFC5gdlfOITjYuRPtyoOBGRnxuWScaRIpzvHuvN5DSMqb/TXOwNsK3eXjk /Zm0eCC+4AXVZniP+0lStGKst0oWtOFEmCB9UBgdkMTh8FEhJWgocw5qFSZdf0cHAUdY B4M6sVB+s128kz9llV5YqqkfTjVtm8MOKbleOrr59Voqfgksa2USQ0aZ3sz+GMtGdnur kV8I/MesgOHx9/M8CMwM7iIOgCJXToXS7w88riQxyQxFOdYfZW0HAaeAY23AboVS/oJ+ TBE3LX1KmWM8TugdeGEethIpmfVm+HMNcHIDD9a5cd0YBTIDcBQAM09uM9AqwgmTys/N TqcQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=qGV0ipi+; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u131-20020a637989000000b00434dd689f07si28249463pgc.846.2022.09.18.05.24.19; Sun, 18 Sep 2022 05:24:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=qGV0ipi+; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229581AbiIRLwb (ORCPT + 99 others); Sun, 18 Sep 2022 07:52:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229532AbiIRLwa (ORCPT ); Sun, 18 Sep 2022 07:52:30 -0400 Received: from out1.migadu.com (out1.migadu.com [91.121.223.63]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A15F02716B for ; Sun, 18 Sep 2022 04:52:28 -0700 (PDT) X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1663501947; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=oVBZfho8PdQ5yA76guiErK3yYPbS35fkQsCtJXulPpk=; b=qGV0ipi+KqIDXHkE/ASDNaeg8/QvY0osojQP2jsv2mBgOBWjpJwKaMaWjn7KbR4C/LuzqR F+eRTqn7WRZxkefbcjeeruTIMOHLKgmm5G/fGqkCWheZnZgSK6TMiNF9NXJZ42v/M9m18Z 6aJeJBbLO9p1A0v8G7U5k/oQYKHXOfU= From: Guoqing Jiang To: tytso@mit.edu, adilger.kernel@dilger.ca Cc: linux-ext4@vger.kernel.org Subject: [PATCH] ext4: remove redundant checking in ext4_ioctl_checkpoint Date: Sun, 18 Sep 2022 19:52:19 +0800 Message-Id: <20220918115219.12407-1-guoqing.jiang@linux.dev> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org It is already checked after comment "check for invalid bits set", so let's remove this one. Signed-off-by: Guoqing Jiang --- fs/ext4/ioctl.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c index 3cf3ec4b1c21..80678af1fa7c 100644 --- a/fs/ext4/ioctl.c +++ b/fs/ext4/ioctl.c @@ -1060,9 +1060,6 @@ static int ext4_ioctl_checkpoint(struct file *filp, unsigned long arg) if (!EXT4_SB(sb)->s_journal) return -ENODEV; - if (flags & ~EXT4_IOC_CHECKPOINT_FLAG_VALID) - return -EINVAL; - if ((flags & JBD2_JOURNAL_FLUSH_DISCARD) && !bdev_max_discard_sectors(EXT4_SB(sb)->s_journal->j_dev)) return -EOPNOTSUPP; -- 2.31.1