Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 20 Sep 2022 11:29:49 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Dan Williams <dan.j.williams@intel.com>
Cc:     akpm@linux-foundation.org, Jan Kara <jack@suse.cz>,
        Christoph Hellwig <hch@lst.de>,
        "Darrick J. Wong" <djwong@kernel.org>,
        Matthew Wilcox <willy@infradead.org>,
        John Hubbard <jhubbard@nvidia.com>,
        linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev,
        linux-xfs@vger.kernel.org, linux-mm@kvack.org,
        linux-ext4@vger.kernel.org
Subject: Re: [PATCH v2 00/18] Fix the DAX-gup mistake
Message-ID: <YynOXa8+jxxCjH5k@nvidia.com>
References: <166329930818.2786261.6086109734008025807.stgit@dwillia2-xfh.jf.intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <166329930818.2786261.6086109734008025807.stgit@dwillia2-xfh.jf.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gzVaANg579vVe4vzhgXTFXWoUc/WexrGwFPl6BPoT8XWigRo/llEmYbLPJEU?=
 =?us-ascii?Q?bXZrQt94EjB+3E3M9+OBEFujemBOWS0ACcNA4+CwB65Ws+YqFjrkqZMI9mwQ?=
 =?us-ascii?Q?cIFx5iIMaIiXxv3XwXMJGUmAvV3+w9PJk9JZ8Jso/oO/OGqHX2bhpLq6zRbm?=
 =?us-ascii?Q?JmvW9Ooi97LT3teJ0clqqoLLZWe6GrebU7cJ3komYPWqQ1pyu3BTSkb1o17c?=
 =?us-ascii?Q?Jy44NHnLBkQ9leUlXsgzDl4z4OybA8N25baTK/yKhCMORHi2cxHaKa2GdrQx?=
 =?us-ascii?Q?GKnzaxdYRczEwTdJIFXJH2Oej4y1xC0j/aRy8HkU8b3eEJtRvAkiU7Igqpc3?=
 =?us-ascii?Q?/xDf7thqTkNBOpiHpHWs0VLDjaY1j1JooZUYOvxBpgfdZf8TYbKLRobTlrM3?=
 =?us-ascii?Q?X84Uao9Dv6B+QVLuV+Re+8oQQI4IGDdkyvmjnzkfWUl+AcH51Xs8lWr8PDes?=
 =?us-ascii?Q?etyLSSN+/47Bk7gZwSXFeuE/erpCEGpQ+9Nlg8M8BLya6/oh8RFvFiHgi9hT?=
 =?us-ascii?Q?fMPKtR4Y+xXgJAHkaSiQ6Sb4tz6unmSeQ3DkSbmzgZPq+YXDNZQ3W5duf7yd?=
 =?us-ascii?Q?QHytrIDKXWsTJ0KILJo2WZ+wJaP5ciovWWuP/2cKpLOgZu33PGDKyvXI8iJz?=
 =?us-ascii?Q?ku/0K6UlCCFNOhET3/RuKTlgKiPA+mmKXCLbsmuQzGMqOLsyez8fnwTS+s4I?=
 =?us-ascii?Q?MbckTDVCS0Tpm5PFECOj0ZToZUq+E1ARHAv/uoAHpmFHrWhSNiy/0V7pJOFJ?=
 =?us-ascii?Q?hOP406UWVvkJ2RwfS8HtXi9esQw/LzPMfKP3WpC6LmSZ/NLANscR3BzG0F0K?=
 =?us-ascii?Q?n3pRYV3j0gFWH5+/glxptb8TV1Buc1MiIArh8mLdgCZhMtyukaRJjLIeMWWV?=
 =?us-ascii?Q?ArP+k8Z+ZuX2V96KjxjhMDSVUixDfP9CQbg0VXNL69cam4nRBqfL28gZGH0M?=
 =?us-ascii?Q?HlwDMRFxIaJRgY9sjpGDHhvVfzSvHjqmM45kAxiK3Wx1uC9v1xi1gPoIouC9?=
 =?us-ascii?Q?eg3NuFTzFUs/4Jw6TLqHxkp8lZw8YFHhAdPQ/7MMUh6/WhkzL7maapcxs3ha?=
 =?us-ascii?Q?uChi5MTfpv9zXQpJgiwdwSabjJr+HpZDLEp6If3Pmzphs7DtMcdCEgtKzmgG?=
 =?us-ascii?Q?jq1j992jaxnQ+f/6wx0hjvIlNYQ5KhuQ1byQonmgpySOIzR4kxD+yQXjhaes?=
 =?us-ascii?Q?Ynym1fTEcFyCrv/0oBIghO3qTG/lKfhdrwZQ2idbftwUBogxMUfNAct7fNev?=
 =?us-ascii?Q?kLRqrmaR7Mp9fmO+eHajfbB6kc7DMQTS1btXm1cC6354Q7DnPUsgEpYyya3/?=
 =?us-ascii?Q?7YR8ftbJ70cqCfaYiRRz28/PxR5T8Tfw/8AsQpV/jyxweKbkaHlM7xLhLuFB?=
 =?us-ascii?Q?OSlYoqzY+UgK+6JfzHbdGQ8nNCrhPtwILIcSmsT4PJnzOZEzsUtADH3fqMuW?=
 =?us-ascii?Q?/BvjPigMOXFyMAdGlclqVqV31VA0ncI1Wc9nGIZkQccJK5o5qhRUJ+6FykdV?=
 =?us-ascii?Q?/07fkfrO/h/o23vaMb2E1WARMvivAv110hSRrAlNWoltQT0+8S33DleM1qs8?=
 =?us-ascii?Q?b25UWbBeLooc1d1gQu6d9D9d86ikXbVpgIHCdCV9?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 063f9051-4695-436d-66ad-08da9b14939a
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2022 14:29:50.5617
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yKuWuXlai2SPubKRoaJMF8x1l9G5YVHbP6IZFK7Pd7d+6qgbVpWVklpGJcq1ewAJ
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4232
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-ext4.vger.kernel.org>
X-Mailing-List: linux-ext4@vger.kernel.org

On Thu, Sep 15, 2022 at 08:35:08PM -0700, Dan Williams wrote:

> This hackery continues the status of DAX pages as special cases in the
> VM. The thought being carrying the Xarray / mapping infrastructure
> forward still allows for the continuation of the page-less DAX effort.
> Otherwise, the work to convert DAX pages to behave like typical
> vm_normal_page() needs more investigation to untangle transparent huge
> page assumptions.

I see it differently, ZONE_DEVICE by definition is page-based. As long
as DAX is using ZONE_DEVICE it should follow the normal struct page
rules, including proper reference counting everywhere.

By not doing this DAX is causing all ZONE_DEVICE users to suffer
because we haven't really special cased just DAX out of all the other
users.

If there is some kind of non-struct page future, then it will not be
ZONE_DEVICE and it will have its own mechanisms, somehow.

So, we should be systematically stripping away all the half-backed
non-struct page stuff from ZONE_DEVICE as a matter of principle. DAX
included, whatever DAX's future may hold.

The pte bit and the missing refcounting in the page table paths is the
remaining big issue and I hope we fix it. The main problem is that
FS-DAX must create compound pages for the 2M page size.

Jason