Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 20 Sep 2022 11:30:55 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Dan Williams <dan.j.williams@intel.com>
Cc:     akpm@linux-foundation.org, Matthew Wilcox <willy@infradead.org>,
        Jan Kara <jack@suse.cz>, "Darrick J. Wong" <djwong@kernel.org>,
        Christoph Hellwig <hch@lst.de>,
        John Hubbard <jhubbard@nvidia.com>,
        linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev,
        linux-xfs@vger.kernel.org, linux-mm@kvack.org,
        linux-ext4@vger.kernel.org
Subject: Re: [PATCH v2 01/18] fsdax: Wait on @page not @page->_refcount
Message-ID: <YynOnzC5ddCZkir4@nvidia.com>
References: <166329930818.2786261.6086109734008025807.stgit@dwillia2-xfh.jf.intel.com>
 <166329931529.2786261.12375427940949385300.stgit@dwillia2-xfh.jf.intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <166329931529.2786261.12375427940949385300.stgit@dwillia2-xfh.jf.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?R430zEPhE7t7w80h4oIqDkMy6IR1pJ0+SA4oDCIxp7Lx3eXxaR4BdqZ5lwA1?=
 =?us-ascii?Q?ryEv24codxF4wfSjT2i8n5r//pEQgknssUEb7NDXH506WYl9IjULPpD8nvBr?=
 =?us-ascii?Q?0kHEr+yOTyWUcJ2pK17L3UjEJXx7Bx67yfqFkLIk34ApUdCNpEMZsAK2gCNN?=
 =?us-ascii?Q?NBVqMhqCyzCkBU3ck0fVKF8Flg4UqNIvMlNsXmEgMf6hrCHVD/rDwGn4/t+3?=
 =?us-ascii?Q?+ECQDmW0vuOPiWQqwVeQlxd3W7TJO89hp1pFCAQOh0V512FlIxSn54Row3Xq?=
 =?us-ascii?Q?h3uhqgPrm3YHq0g/hILchjFinWhkKjYidclwMSY1PuxWJBjN6sd7ykoemVxM?=
 =?us-ascii?Q?iMJuNZHpcBHkTFl135wX6qroPRifY3xs2IgPtiNMQamOaxhGbdQ6NBZuWSVp?=
 =?us-ascii?Q?HUNh2paCuDVIagbsrCG0yGsJ4kExs+ob/GOTbHKeiJMuymr146c+IDISziYO?=
 =?us-ascii?Q?TBZvUJ6SDOXHkAZy9qhinNWLWaxEbUh5ZrnS8EEtE4sKXy/pkLXrpyIc8I8r?=
 =?us-ascii?Q?rJJ+NlS/nOYqeSVeRif/gbqvSn/Cr3T+j3IlFyPTUrrpOBRXTh0ozaz+eKJJ?=
 =?us-ascii?Q?AaUiFf0KUm/W7qXm9ELJKbvH4bj8eJN+50FWEXh/vXBQlhDyW/L2x6jSmSw5?=
 =?us-ascii?Q?IAo2vo0JtBQY8lflYl+kAuKXdOpciYieKkrzTJSjx+Nem7ygsKmjxbpAwqWH?=
 =?us-ascii?Q?VMLn3XMQl37YUaWko5j7/6LRVU9vCrHdUgY53UwNZj5FYMLbDCQSmrciSVW6?=
 =?us-ascii?Q?xvJYAajtdlisOnm5wpEOZVHYagCzkJ3YtaJsVL3nvXw3gRe5rEtykBqBcQwh?=
 =?us-ascii?Q?/tbtETBfo9eFoCp3Sy2rOVFqoB78aNSGKMmZoaqtQmhZ6X+2gOFKQzeLA+y8?=
 =?us-ascii?Q?e5wyL3xYWVGAobtkH9ho98A68aufrRL5HckYIj8UIntx8JUnb5/FiyMzUPzL?=
 =?us-ascii?Q?3ngcVB/3BJL+WGiYm47Kpll+nbVjDCJM3C8jpCwsXgEZOZvbshgVVf5TLW17?=
 =?us-ascii?Q?CJEvyrV/SwUFbpdsqfT04cc//SRHRa/Inxmg+mKHXIGxG/okTnBGe5sS6EXo?=
 =?us-ascii?Q?knX0gXD2727BOjGNmkzODuKeYOGhYNEnHgPYdVgBCSxyY52mWgHwt6/jBt0G?=
 =?us-ascii?Q?RATjLa6i9JDIhGWTO3E1SPz9PmRwDzz21cPmQJOwan3haBeX4CZE2lvMGiX1?=
 =?us-ascii?Q?TEH/DuiZYzFLD8+z8S/1Z02gOtHruHQQVLaSA0qUT1b+fb4pRABu0gBZpDMS?=
 =?us-ascii?Q?csX0HJnnVFModI8KYjYIDDRUdBdzpAfYzR7GafoUiimGs/RrC6LUenRvoCIb?=
 =?us-ascii?Q?X2UusEP8PnnBEEyy5SEGEpEngd4WPxvnMeAO/7WeEXabsxi+DbczBs9fPxO0?=
 =?us-ascii?Q?LGqJ6DSUZYhpheo5t9Fi+EwXj3CA5yMZvIiRIqgqz9DIvENxqRETpVupL6Lf?=
 =?us-ascii?Q?YtUJqe6UO/fSjjRicEyzqx+gf4o0Gxy2vXn1FvHA16at9glvcWAgK6WvgH9A?=
 =?us-ascii?Q?FRvB6nxW6MhDXvNkWfX9qYKFpOo6p7rcY4FVZJPWB/OcPQMqdhpxKUjPAaxW?=
 =?us-ascii?Q?P0EbI80ioJy8kb1otfPH2IakqrnE2Cr0bcyPN1i1?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fd5c19ef-2e4f-424b-f255-08da9b14bb28
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2022 14:30:56.8957
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lOgEnoDtQ+Z1oMg/2vinM+2cAh6vHSMFQPru1te0HMJENCjRUS5mbbJXCtdq/taQ
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6003
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-ext4.vger.kernel.org>
X-Mailing-List: linux-ext4@vger.kernel.org

On Thu, Sep 15, 2022 at 08:35:15PM -0700, Dan Williams wrote:
> The __wait_var_event facility calculates a wait queue from a hash of the
> address of the variable being passed. Use the @page argument directly as
> it is less to type and is the object that is being waited upon.
> 
> Cc: Matthew Wilcox <willy@infradead.org>
> Cc: Jan Kara <jack@suse.cz>
> Cc: "Darrick J. Wong" <djwong@kernel.org>
> Cc: Jason Gunthorpe <jgg@nvidia.com>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: John Hubbard <jhubbard@nvidia.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
>  fs/ext4/inode.c   |    8 ++++----
>  fs/fuse/dax.c     |    6 +++---
>  fs/xfs/xfs_file.c |    6 +++---
>  mm/memremap.c     |    2 +-
>  4 files changed, 11 insertions(+), 11 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason