Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 20 Sep 2022 09:50:50 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Jason Gunthorpe <jgg@nvidia.com>,
        Dan Williams <dan.j.williams@intel.com>
CC:     <akpm@linux-foundation.org>, Jan Kara <jack@suse.cz>,
        Christoph Hellwig <hch@lst.de>,
        "Darrick J. Wong" <djwong@kernel.org>,
        Matthew Wilcox <willy@infradead.org>,
        John Hubbard <jhubbard@nvidia.com>,
        <linux-fsdevel@vger.kernel.org>, <nvdimm@lists.linux.dev>,
        <linux-xfs@vger.kernel.org>, <linux-mm@kvack.org>,
        <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH v2 00/18] Fix the DAX-gup mistake
Message-ID: <6329ef6a699be_2a6ded29468@dwillia2-xfh.jf.intel.com.notmuch>
References: <166329930818.2786261.6086109734008025807.stgit@dwillia2-xfh.jf.intel.com>
 <YynOXa8+jxxCjH5k@nvidia.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <YynOXa8+jxxCjH5k@nvidia.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?17p4OkigeWkgIcVbb8S1KboCAm1t9pEsarkscslCaZnR2JqsWJaGlJ7Rmf1Y?=
 =?us-ascii?Q?kZq1BDvyMV3/sDKqgfvRIjeuFdJkNoVoOsB7Q3oHdI9VXlkZ6H7ZEyhHNLtq?=
 =?us-ascii?Q?veh2M1sq3W2V/HW45F1/aLXPAnaH63v/8eUOTjhPLINsBKfBA4I87WfFvkCg?=
 =?us-ascii?Q?OnsYE6XlwMrcXhM6lsB3eFdmhtDk4RjRp+15mLNfjeufgGzvrjlBNns++/hq?=
 =?us-ascii?Q?OyGel0PZqblAN+h9KNrSEvldx3BLp/2KsRWSnAYjmPc8n9xbVCgVhdjUdJjR?=
 =?us-ascii?Q?sAKJq445i9f0A7JA29w6Brl6Y3AxEJ8LVHkcU1QH3SUo+PiWVPA3sOf9lber?=
 =?us-ascii?Q?ksRrKdZG7sJKEFTF90Q05FC9r9uAZ/v9RehI7hvOreJdo/AD35Xyrj6M1C/P?=
 =?us-ascii?Q?QmTR6fehqedZEPb79bOOkB/INNDW6Jkox6SpwUrOgFnv1UGf3eElmsHv6sav?=
 =?us-ascii?Q?WQKUDm15tPJHupWFaeELCgb6lqi0TQUwp28t2DKCHmkV5ncoaVyQ2D3zU4Ta?=
 =?us-ascii?Q?4gD7JyN195K+vrah/i5cx7Y9mSL7ipGsxEJn+MHnCNuuhpEuENLS5G1LmvPR?=
 =?us-ascii?Q?GyPaA8qfBtxaDJFn2AcObB+5R3JUgGTAfhanvBuGYNmI3f7MP1ghIl1dnk1x?=
 =?us-ascii?Q?KsJSC5SuR8BIQeEorXM0fUK42LLBTQg6XA+UxHW2wEg1T4xLPvcvasjkwJ5L?=
 =?us-ascii?Q?yBQnSHnHmhA/nkesYsH3RSX8+HKl+ufdWwWrSYun9DpxfMRtlQyP2tZt/dW4?=
 =?us-ascii?Q?r1vnjitqqskaGVtR5ASU2AUCn9wgfVhLLIR0WmyAHxLy76qFk5wdzeAfS3rK?=
 =?us-ascii?Q?2BQbC0DDaDqF9witws2MjyLaYAzkb4e+cLnPD+Ppz5sPvym7CGaixKdiUgcM?=
 =?us-ascii?Q?4dvmRa4K8x21OTZkwI2DwwijkSolYhGhF1ZNpfSW/XO801DIEta6dRMvdhnD?=
 =?us-ascii?Q?f+rgOtDsj9nGgK45JVoV1WDNY7dERQMmufi9sNSWGAvYm6Gf1JiJiDj/JPju?=
 =?us-ascii?Q?y6MSgjxtBOHh//vcZqmm5lheD+ryk34j3tU/8aYV01RaXWDCSMkbFFDsVsJh?=
 =?us-ascii?Q?k7I0nYWiASnQq8Ipt4PRHW11pBKJsNzVmJbegRlnTELLTNwzf7o7hG1mUe96?=
 =?us-ascii?Q?fCoExwr2fWhpByueLaoMoi+Q3+cLZJ/ZZyTg4q85p52wuM8Hp4vn4Gw1IA2Z?=
 =?us-ascii?Q?hynG+ndmKFAgymrOn4o6ZD1F2qr2hDwhifdNkOQCydFIS4RxPks5Ri1YJTdy?=
 =?us-ascii?Q?oz2ioc0DScNz7VeZIDCBKVybeDYXdrrox3ITla/utHsXjO81cMs6SXMXkyui?=
 =?us-ascii?Q?nxXf1eqzk04FKPlZ0K+6HsFwDTrJ4j3hR2Xw54/s90LB+5FV5K9nVsufN3MO?=
 =?us-ascii?Q?gRBUvPpm3KRtDS3Is/2laTzGsbp/zQhz6n/6VOTMG6hwqbtykFqiOaZyjihZ?=
 =?us-ascii?Q?plq4Rs5Xyn4+PueydnZGJ8IPHw3sHVxc3N9n2xY5x4e5JcBTz/xHurb4TTMM?=
 =?us-ascii?Q?cV8Nv6v55kLncxXJOoBrvlbaYRDaS8qwKN0UdVvHLthFHGg+ZilLJi4ju0M9?=
 =?us-ascii?Q?NgxqA0ON8AltUhoS6VU+1JHR4accZXL62U+4TmgeytAgXDsrP0PaIUtX2OWQ?=
 =?us-ascii?Q?Xg=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a2ebfdf8-64bc-4f79-b52c-08da9b284bb0
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2126.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2022 16:50:59.8777
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 30EjbCeUv1PBdfTOWVon9dqK0BC5OUQ7eGlCPgsWg9o7aDLdFp7ItoivckEu9yAKrHlpdwNTIKg1vWFSOnVsEWdqWdM/AjQz8rk5WSXTWas=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7068
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-ext4.vger.kernel.org>
X-Mailing-List: linux-ext4@vger.kernel.org

Jason Gunthorpe wrote:
> On Thu, Sep 15, 2022 at 08:35:08PM -0700, Dan Williams wrote:
> 
> > This hackery continues the status of DAX pages as special cases in the
> > VM. The thought being carrying the Xarray / mapping infrastructure
> > forward still allows for the continuation of the page-less DAX effort.
> > Otherwise, the work to convert DAX pages to behave like typical
> > vm_normal_page() needs more investigation to untangle transparent huge
> > page assumptions.
> 
> I see it differently, ZONE_DEVICE by definition is page-based. As long
> as DAX is using ZONE_DEVICE it should follow the normal struct page
> rules, including proper reference counting everywhere.
> 
> By not doing this DAX is causing all ZONE_DEVICE users to suffer
> because we haven't really special cased just DAX out of all the other
> users.
> 
> If there is some kind of non-struct page future, then it will not be
> ZONE_DEVICE and it will have its own mechanisms, somehow.
> 
> So, we should be systematically stripping away all the half-backed
> non-struct page stuff from ZONE_DEVICE as a matter of principle. DAX
> included, whatever DAX's future may hold.
> 
> The pte bit and the missing refcounting in the page table paths is the
> remaining big issue and I hope we fix it. The main problem is that
> FS-DAX must create compound pages for the 2M page size.

Yes, this is how I see it too. Without serious help from folks that want
to kill struct-page usage with DAX the next step will be dynamic
compound page metadata initialization whenever a PMD entry is installed.