Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp4730886rwb; Tue, 20 Sep 2022 19:43:27 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4h0Dz0GRyqd1Ith9/bNb0f+SFPYg29jblNFjnESYvIsDnj9UR4oIlU/TrVyd3iRUmaIYON X-Received: by 2002:a05:6a00:1a07:b0:541:6060:705d with SMTP id g7-20020a056a001a0700b005416060705dmr26810419pfv.61.1663728207664; Tue, 20 Sep 2022 19:43:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663728207; cv=none; d=google.com; s=arc-20160816; b=dbDp+DKOn8Xg6AczYsTXNexoswYyJPjLbeGdHG5SlLI0ry6QCznaj5Es5jGIZJYwa0 qUXVqEEapniYf2ZPPZEcxtZBL1wulDNoURCaNQoXgbzJR+RBTQoqLYHVpKIcK4oW/KUP 71pvByoHvPcBkODYAHwNL9OdqttB4bu7RFhiqL0vIyUXWYX+7Py1SnbOj1dA+aYQoJRS QYpg/Bvc8LFmln/PDRYK3KSX7ZqwWdkHgs1krVhspPfILItFq3EhHtPF1m0Q9Fsx7Mqg mUyyXyhzLmafLUgoszpMzTLH7F5jiVQLprY60DF032gQNHpgz51kErWrcrnIM36FxqSN 1ARg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=t2Q8V+AEIFSC4FWyOVVZ3q/0L0fosOQqOKm2sowUgLU=; b=oznN3GJg9Woy/+8lP6T1RObXbYL1/Nzyp/b+vosmIB0toxP+oIW74UTdGtf/hZnhGK tDj91pe33JSvqMOhXqZ091DfXYkGd1xnlmpejpsqBVvUpe9ZSNIOe1hHOcMT0QMaySQI 6dOHxX4afWtYmxWUS5lQLdJkefnclUK9Y0bM3gSDaPjq/TEFXi+FdBwK1Da/xG3ohCkZ tO9qqz+CdbzcnzAnHAdHvygxzJ67j6iKaAhBWD1myCNgT9pKE9Xjd1s7M9e9XTDghULt 7cuHa1dRpYXuPi9dFVx4QpUPUgs9/QunX0J/aaT0jRoKidTozWkG/HOlSRP96ZOHW+B6 9hew== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b="DBiS/xxe"; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id oj14-20020a17090b4d8e00b002035055ff7asi1623712pjb.43.2022.09.20.19.43.08; Tue, 20 Sep 2022 19:43:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b="DBiS/xxe"; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229827AbiIUCm2 (ORCPT + 99 others); Tue, 20 Sep 2022 22:42:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230119AbiIUCmQ (ORCPT ); Tue, 20 Sep 2022 22:42:16 -0400 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6AE157D7A8; Tue, 20 Sep 2022 19:42:14 -0700 (PDT) Received: from cwcc.thunk.org (pool-173-48-120-46.bstnma.fios.verizon.net [173.48.120.46]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 28L2fupT001976 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 20 Sep 2022 22:41:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1663728119; bh=t2Q8V+AEIFSC4FWyOVVZ3q/0L0fosOQqOKm2sowUgLU=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=DBiS/xxerukulQL4UwQIAmdTUPF9ZSkwh0fPFFq45tIbzNTTWEtxhAsfkEW70KQS6 qVQtcbPI6J+lJlpLcMN+MNpep3yeA+QiSlt78GuRjpM0NlbsRU7CUd8lClb5b+pepC DSS5we2t7YAFaleOQHG9zF1rC1W0QjD9Q0SMXgAHw2PHxAHAvVY8VlEORVR60ahCKx r9VUo+eHY2Tjmw1u8rvxxTfK//3CQeIm7I52ipSmSoYVorRjTXvjyhmM9IYSb+90KY ESIQQzwUFtn0JUDdW51LtlAvo1Y+u1sCQeYNRMUINshuUyBZAmigOj0rBhBZeJUCU6 5zAPxOdZN1BPg== Received: by cwcc.thunk.org (Postfix, from userid 15806) id C6C2515C526C; Tue, 20 Sep 2022 22:41:56 -0400 (EDT) Date: Tue, 20 Sep 2022 22:41:56 -0400 From: "Theodore Ts'o" To: Thorsten Leemhuis Cc: hazem ahmed mohamed , "linux-ext4@vger.kernel.org" , "adilger.kernel@dilger.ca" , "regressions@lists.linux.dev" , "stable@vger.kernel.org" , "Mohamed Abuelfotoh, Hazem" Subject: Re: Ext4: Buffered random writes performance regression with dioread_nolock enabled Message-ID: References: <48bb6266-2d5c-ffcd-6982-4fd02bfdcfc3@leemhuis.info> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <48bb6266-2d5c-ffcd-6982-4fd02bfdcfc3@leemhuis.info> X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Hazem started separate e-mail threads on this issue (separated by about an hour), and I replied to the earlier one here: https://lore.kernel.org/all/Yypx6VQRbl3bFP2v@mit.edu/ TL;DR: 1) The patch landed in 5.6, and improved performance for some workloads, and also fixed a potential security problem (exposure of stale data caused by a race). 2) If you are using a storage device >= 128GB, and a version of e2fsprogs v1.43.2 (released six years ago), the journal size will be 1GB, which Hazem reported resolved the problem. 3) I disagree that we should revert this commit, as it only changes a default. If you prefer the older behavior, you can change it with a mount option. - Ted