Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp4961664rwb; Wed, 21 Sep 2022 00:49:01 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7oBBx0Ga9lIfTkygBvLd9mv8fUA4qciIfyjS0lWFG+TQTY5ohaT48S/ln4AQgH9H+/T/IX X-Received: by 2002:a05:6402:3c8:b0:454:44b3:2e2a with SMTP id t8-20020a05640203c800b0045444b32e2amr9709528edw.283.1663746541025; Wed, 21 Sep 2022 00:49:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663746541; cv=none; d=google.com; s=arc-20160816; b=ePSRI7msJrhLfQiw+iUaUVF6wgd5i67mDTN93kO+CtNRnUEDbgaRCtEwmLyn4Sfeso duIBdaQia62gDeNHLZioYQOA5qTmbC7l0E6TYRG87IwYQmsMhwzg/BleUtSjep/KswFD B4CPkvZYdGRGqPW/EetB4mMOGwNaX8bykU99DUwTqJSrljWu9FXK7Y85SyvXvr8E6mr4 iUYCNWg5GgOUCQwV8oNG574EHA0MS9HayOKGockzLIK2zoE77CD2ae4Ci4FuOHPGTuvo ///3uFpmNSHQU6a2qeeum4v4mU/nS4sBbW6HZ1PHiSn2CaXH/gqXq3HSsEL98f0UpqQw lgEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:dkim-signature; bh=xnuXU4UZnRZGUPWDNH2YDDT/Zs/oJ/xBk/61+cuL7yk=; b=His7PeDFfd9zk6ojCyzFWxpBKTRKX7zIjYiDZfpueXPWmEUnD+66igDYwzRYBKnvFx G0wI5CCD8IzOGdYCt3i7K6T78KrrVPbhfqH99ZI6FlRAocbhYzJm/OVH5Hx3t5wRskir 3JFN6Zl8gVG1piMm2FxtSn+EOo85RMjslMwlPXlpKy+oI9gWLB3qbMN5zdwZK/AiHI2M dDlXjDEHVf7sHwwnlS0pCkEE49KENTa+Jg7mqxpW0aauoXDgu5yR7LNMmGLMzpYfqC3J aSKEkLIpfdgAZb9Ovkq/qbjrco1hRioGMPBhwMYQm1E+Q2oaNwvM5yeamF5rM4J2UlqW SCew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=Oka4W+OS; dkim=neutral (no key) header.i=@suse.cz; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l6-20020a170906794600b00781599eb7d9si1894061ejo.542.2022.09.21.00.48.29; Wed, 21 Sep 2022 00:49:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=Oka4W+OS; dkim=neutral (no key) header.i=@suse.cz; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230326AbiIUHkF (ORCPT + 99 others); Wed, 21 Sep 2022 03:40:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230312AbiIUHkE (ORCPT ); Wed, 21 Sep 2022 03:40:04 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06A5327CF5; Wed, 21 Sep 2022 00:40:00 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 72DD11F388; Wed, 21 Sep 2022 07:39:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1663745999; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xnuXU4UZnRZGUPWDNH2YDDT/Zs/oJ/xBk/61+cuL7yk=; b=Oka4W+OSOQHj5c2rLmWBL8Xjvq7VzpEzzQB4tDhWafzhs38MCqENmdBWFWeEgrYCuXiPrr Usz7li0+SflrwVaGVWa1hli+JnHNueftR14iAItHD7JzJ+6bGwgf/1CTsziSK2yJsfV5VG g+/bP8Jp/4+dyH0LiClu4XMVz8a12a8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1663745999; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xnuXU4UZnRZGUPWDNH2YDDT/Zs/oJ/xBk/61+cuL7yk=; b=8qBsyoM9PZ67Zm/jPRszdv92ksT1R84+Fv4fJELUuJeXASTjI66U4tbw5GMQH/r58S4Otd NNrFV78ovfGkJhDw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 60CCC13A00; Wed, 21 Sep 2022 07:39:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ywiZF8+/KmO7EQAAMHmgww (envelope-from ); Wed, 21 Sep 2022 07:39:59 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id C0833A0684; Wed, 21 Sep 2022 09:39:58 +0200 (CEST) Date: Wed, 21 Sep 2022 09:39:58 +0200 From: Jan Kara To: Zhihao Cheng Cc: jack@suse.com, tytso@mit.edu, brauner@kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, yukuai3@huawei.com Subject: Re: [PATCH 0/3] Check content after reading from quota file Message-ID: <20220921073958.77i7fj6s2qa7chbv@quack3> References: <20220820110514.881373-1-chengzhihao1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue 13-09-22 09:16:11, Zhihao Cheng wrote: > 在 2022/8/20 19:05, Zhihao Cheng 写道: > > friendly ping. I'm sorry for the delay. Somehow our corporate spam filter decided to discard your patches. I'll have a look into your fixes shortly. Honza > > 1. Fix invalid memory access of dquot. > > 2. Cleanup, replace places of block number checking with helper function. > > 3. Add more sanity checking for the content read from quota file. > > > > Zhihao Cheng (3): > > quota: Check next/prev free block number after reading from quota file > > quota: Replace all block number checking with helper function > > quota: Add more checking after reading from quota file > > > > fs/quota/quota_tree.c | 81 ++++++++++++++++++++++++++++++++++++------- > > 1 file changed, 69 insertions(+), 12 deletions(-) -- Jan Kara SUSE Labs, CR