Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp5262149rwb; Wed, 21 Sep 2022 05:36:10 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7IZyeaRMsEC0mHd5qCOTD3FLGFQZXw9DxYsAKwZUjCz4AnViC7LXHvTEg7VQ2aZDL4TcRi X-Received: by 2002:a17:906:8a46:b0:781:71fc:d23f with SMTP id gx6-20020a1709068a4600b0078171fcd23fmr9816512ejc.500.1663763770718; Wed, 21 Sep 2022 05:36:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663763770; cv=none; d=google.com; s=arc-20160816; b=iLkJC5O6sxTuFrXMD9YYgic74N5bcFO8pjvNC6WX0dWkqynZPfOXKevG/qw/r0ffXR ZiQqpVwQhuXen20rJWn7rF+8FH5YRQTP3NOIl8UYCV1vXK/mLpfPAwmvFZPI2y6BrUGA 6WRtVA+qsZuGXBi/68n0H6W/Texraa4607GJXLB02Tux3JrKU3L8asvx0w+h9UkU1Plx sIIzpSOOFuPRLFr8EJb58JAK6p9MVNan+16ECpeC8SXnQ336TV4u9t69GAWvgEJlJ5v7 nSlh797JgaGlDIbsc/5l2NbJqfgcSfEd361rvu2/qLc7/zTdGr01UGY1tcaUklK+mIrg KVWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=3aJj791SFi8MBmk/3DDeNGs8qJFxgSOFtNXhCuwyFlE=; b=N5Ke6Vt987tVRp1ccWugzaa3kAQHCw3C2Apwa5JWuG40aRCWPgTvfeVJlL98/ZCvMP UwHvG7AyzgIPgkJu+kG5lffqwvcjflK8+ybPVRU0UVQ8p1iSW8Jw/t7wArO2whp1yzNy qBt9I38aAVlbkIL90Naey/dGbvWRq9eus1L3Urjb1LvUNYryq27PUFEFQwrK/+wq15+h j+xHF6W4NGA2beeoRj5eUBsVZ2iK7yCjk/pb+Mb5EBj4bE3Nn45fYfBi3cYXcgtW5WLt M9TIzuGB5wHQgR2Lsn2pVqz25rj00tsdNx+AcUKWvkGtPz63TaRpccTrXNCfDBfGpiZw UYKA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=gZm6pXwM; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m5-20020a056402430500b004515d04e9aasi2706722edc.37.2022.09.21.05.35.28; Wed, 21 Sep 2022 05:36:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=gZm6pXwM; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229908AbiIUMXr (ORCPT + 99 others); Wed, 21 Sep 2022 08:23:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230021AbiIUMXg (ORCPT ); Wed, 21 Sep 2022 08:23:36 -0400 Received: from mail-oa1-x33.google.com (mail-oa1-x33.google.com [IPv6:2001:4860:4864:20::33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7961A97EC6; Wed, 21 Sep 2022 05:23:32 -0700 (PDT) Received: by mail-oa1-x33.google.com with SMTP id 586e51a60fabf-1280590722dso8809378fac.1; Wed, 21 Sep 2022 05:23:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date; bh=3aJj791SFi8MBmk/3DDeNGs8qJFxgSOFtNXhCuwyFlE=; b=gZm6pXwMq2/JC/UTzDilnXvNNyRSckcot0YJ/NTaLbwgqLHVdBCLiaVvIB0NkJ3bmZ 1nk1BYSkGZOBASjKxyjllVNk8cab+Hm+DELpIecZjGPDzX2v6JwuUZjXls2mHcirK/+e GjHbLX+FHDyaNPWfCqF087+Pmtdly7g0V902It5/Dx8SAE/K1+IM5JFG6ucNTT+cOkQf m8u3mwFCbWbPL8pqwWcIkjsxR8riTQ9TH/I8mBcIyfB08ZYi+DoeoHcsYYgHLNBEQyFC KgihHc1TC+jck3iRBGiWUKBctERjn3cr1gNKfLL4FDlLcx9b8NBlZbFIrHHHViZYVUGz VmkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=3aJj791SFi8MBmk/3DDeNGs8qJFxgSOFtNXhCuwyFlE=; b=dhJkOts+5k8Wmkk4KRUUXuZG7kvFYSYZdW/pxM8N9fwHiKWVFEaPocwtjchslb/fNe ZZAO4kt1vt6ShQw+GBZi5OknO0QEa+RcVcZWSx39knPDwwXg4+f0JGm3dCTWtS9toSg1 fi574GFxSgF6181Vjdpk8lrToTN8MQdSaYy7mBJwp+YH72O87PCP0q9/iSb753SL8Wv9 G6jDWZkv8YZen26m3kjXFf/xPzSLchymxLH8etEn9Nm77fzgqjoea9Iv9UT7TLANae3r o9v0TAbgORbEPy7FKfQUMrnwuSo+cDGywzGVAKT0Nz8qXQZWF8c4Mbk3CNBY3VULWXPB G1QA== X-Gm-Message-State: ACrzQf3NaDW5cjC2ZhUHmKSKtUKU/WAtFiJU7DQ/+fND3AmbqXMVdAdP 9O10kfacZ3BBjNagu01Zz09YfR4N+kZQDNT9F1Y= X-Received: by 2002:a05:6870:a78e:b0:12b:542b:e5b2 with SMTP id x14-20020a056870a78e00b0012b542be5b2mr4900564oao.112.1663763011355; Wed, 21 Sep 2022 05:23:31 -0700 (PDT) MIME-Version: 1.0 References: <20220921044419.epojssm3g4j3qkup@riteshh-domain> In-Reply-To: <20220921044419.epojssm3g4j3qkup@riteshh-domain> From: hazem ahmed mohamed Date: Wed, 21 Sep 2022 13:22:55 +0100 Message-ID: Subject: Re: Ext4: Buffered random writes performance regression with dioread_nolock enabled To: "Ritesh Harjani (IBM)" Cc: "linux-ext4@vger.kernel.org" , "tytso@mit.edu" , "adilger.kernel@dilger.ca" , "regressions@lists.linux.dev" , "stable@vger.kernel.org" , "Mohamed Abuelfotoh, Hazem" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Thanks for sharing that unfortunately this patch has been merged to kernel 5.7 and I am still seeing that regression with later versions that include that patch. Hazem. On Wed, 21 Sept 2022 at 05:44, Ritesh Harjani (IBM) wrote: > > On 22/09/19 04:18PM, hazem ahmed mohamed wrote: > > Hey Team, > > > > > > > > I am sending this e-mail to report a performance regression that=E2=80= =99s > > caused by commit 244adf6426(ext4: make dioread_nolock the default) , I > > am listing the performance regression symptoms below & our analysis > > for the reported regression. > > > > Although you did mention you already tested on the latest kernel too and = there > too you saw a similar performance regression. > But no harm in also double checking if you have this patch [1]. > This does fixes a similar problem AFAIU. > > > [1]: https://lore.kernel.org/linux-ext4/20200520133119.1383-1-jack@suse.c= z/ > > -ritesh