Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 21 Sep 2022 08:19:11 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Jason Gunthorpe <jgg@nvidia.com>,
        Dan Williams <dan.j.williams@intel.com>
CC:     <akpm@linux-foundation.org>, Matthew Wilcox <willy@infradead.org>,
        "Jan Kara" <jack@suse.cz>, "Darrick J. Wong" <djwong@kernel.org>,
        "Christoph Hellwig" <hch@lst.de>,
        John Hubbard <jhubbard@nvidia.com>,
        <linux-fsdevel@vger.kernel.org>, <nvdimm@lists.linux.dev>,
        <linux-xfs@vger.kernel.org>, <linux-mm@kvack.org>,
        <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH v2 13/18] dax: Prep mapping helpers for compound pages
Message-ID: <632b2b6f6548c_66d1a29430@dwillia2-xfh.jf.intel.com.notmuch>
References: <166329930818.2786261.6086109734008025807.stgit@dwillia2-xfh.jf.intel.com>
 <166329938508.2786261.5544204703263725154.stgit@dwillia2-xfh.jf.intel.com>
 <YysaS5LIW1YYKSKd@nvidia.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <YysaS5LIW1YYKSKd@nvidia.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0oopoKcjENNG590uE1vk59bAYZjIeDX2MRqT2Cg5UZzqM0DBMoQ/vI7qTrRa?=
 =?us-ascii?Q?1+0volYAIH/PQM2T65nGrRlUouqxz8pvHdT4b9XN8eMD9gxg/y3k/FqKvGwY?=
 =?us-ascii?Q?nlDsmcnhW76O0hGDXOQm8iIL3J8nlPwm+vsxedjdhwq57blKJNbfDv5Jr0jM?=
 =?us-ascii?Q?Jf2aGmlNvsgSXbk1myFatCZhKlqTc0JRd8trxqyAdHZqrsKTnrkNFg5gRHur?=
 =?us-ascii?Q?ud0Va5hjHuN+IvJF0ywzW8nZy5YEM0W4bcPpPqt5pGggmMRKURBYLQamUu4N?=
 =?us-ascii?Q?qbhnz/Mj4f/chJ8o/H/fjcx4RWrHQX6+dCOhQ8RigwXF583Tv9HElNrtMZoy?=
 =?us-ascii?Q?wxoeDNHt6Y9KUJQCWq3/U7HghrzJLGi7wEoPd8U143Ajz7Cmt+Ujvm23vHcR?=
 =?us-ascii?Q?0GYEo0G5xNt7AP+fg3iPJ6D/uuX570NtCi8zhbjPaQPUxXlFEpUog1JjsVNn?=
 =?us-ascii?Q?SmmE1OMgV1jCsbJ89PCjvRsmKHKL+sQHKymHugP96KQiMOi+ehTrORpzoOlD?=
 =?us-ascii?Q?1sPc7bAvLq9XzTo7sTfwP3tVanap84iS1t7oXrXC5fKuKa4ZE6kzSrA5R7sJ?=
 =?us-ascii?Q?3D7rrsFqSmkWhxSAZk3qB6pM/vYeCOfax95cc5hZmGs8P5mA/SoesRVJQQq3?=
 =?us-ascii?Q?3+5tTmoQZXx90JtEYwpbwjgDqXQMVcakJ8yfyboqET1IYL2XZyjCqUhU1U6l?=
 =?us-ascii?Q?U/b2cOqbVhqkiB0TmwBgyr8Ay5thsvMj8Iorv3COcyQ7zs8V8hlChxnJjvc1?=
 =?us-ascii?Q?ZbVkwOwcjeHUL1uUygg7rqCPtdteo6BQPb8Bw3FeQrknohpZtkFhoKIS8np6?=
 =?us-ascii?Q?/6waExnChTOg7IAewKbRW0tVgJuIxnNtDpczOGNw2UuZs7iEVMxRkXj9p+G/?=
 =?us-ascii?Q?P/M7/ItIsU/RWbcYIzZfeAcbvPSUuOAgQAvfZuKcW9/FTxzsnhfCe+GJH6k+?=
 =?us-ascii?Q?+UAibZauwbcEDjlgqf8o2VYDgMOVrtOwtS/UalPo+R/90+nW8Se4odzi6U9r?=
 =?us-ascii?Q?WkDmNIlmxp4lZJdDEwwT8QkLxx93VdT1qzGkeAEhuRZMXrWtk5URElVvolik?=
 =?us-ascii?Q?6wYvtRXN1vHMDg34fxXCMYShETf8XszJuh5nua1NxFf0ib+9780EGA4NWk9J?=
 =?us-ascii?Q?M1Drnds1JkKfQrNmv8FIoNkMDHNIcIF46eHhOL3QrNq0IW1cqGzFGACtRoz1?=
 =?us-ascii?Q?crpA46kIvJZmHSbGpnrgdDcG8q1rCFXN29D7QJ1P8U2iQU/EzyDOfZlbK89Z?=
 =?us-ascii?Q?S1zT9CYsA5g4dhoMBqJug7D+nGiOIb17tNDy0r9MRmAicyIMDmkSWPIUwHY/?=
 =?us-ascii?Q?9jf2wJehUXdTEfKSHZcn0HaTblb2pzkfLC1ntFVIQVonTE29ahFQIRyqSZq8?=
 =?us-ascii?Q?vp1KskPPeVT6kuiib8OQSUuCzlrXecAHB9lBdrWBCFxahF/qrkWOs0K4/2eB?=
 =?us-ascii?Q?8U5rZjDfS407/eV5prs4SkbZ30r7O6ZjrSm0TwPCc4rrc5l9JcT1+EcXpjCB?=
 =?us-ascii?Q?G8PflNcaKBQmddYkcVeDioWOJjpOe4sDtmGJM00KD7hI71U02dCvriFa+ECx?=
 =?us-ascii?Q?XFVgPoOdYJ8rLBVaIjwIOfgUN8SGD2WKbLn82XSHCxLQeJrxkasnE+8sK+/Z?=
 =?us-ascii?Q?5Q=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2f5466b2-1774-451f-a9a8-08da9be4a464
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2126.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2022 15:19:14.0661
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GhHIgagDEk59meiD9UsTpgMnlhGvMp1nh92n9da0+O+mxwxQIxnyZqLqCbfLcgM1yKAX74PwLxMudSYzwd0n+j86bHCfxHOmPp81RL4/vT0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB7350
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_PASS,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-ext4.vger.kernel.org>
X-Mailing-List: linux-ext4@vger.kernel.org

Jason Gunthorpe wrote:
> On Thu, Sep 15, 2022 at 08:36:25PM -0700, Dan Williams wrote:
> > In preparation for device-dax to use the same mapping machinery as
> > fsdax, add support for device-dax compound pages.
> > 
> > Presently this is handled by dax_set_mapping() which is careful to only
> > update page->mapping for head pages. However, it does that by looking at
> > properties in the 'struct dev_dax' instance associated with the page.
> > Switch to just checking PageHead() directly in the functions that
> > iterate over pages in a large mapping.
> > 
> > Cc: Matthew Wilcox <willy@infradead.org>
> > Cc: Jan Kara <jack@suse.cz>
> > Cc: "Darrick J. Wong" <djwong@kernel.org>
> > Cc: Jason Gunthorpe <jgg@nvidia.com>
> > Cc: Christoph Hellwig <hch@lst.de>
> > Cc: John Hubbard <jhubbard@nvidia.com>
> > Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> > ---
> >  drivers/dax/Kconfig   |    1 +
> >  drivers/dax/mapping.c |   16 ++++++++++++++++
> >  2 files changed, 17 insertions(+)
> > 
> > diff --git a/drivers/dax/Kconfig b/drivers/dax/Kconfig
> > index 205e9dda8928..2eddd32c51f4 100644
> > --- a/drivers/dax/Kconfig
> > +++ b/drivers/dax/Kconfig
> > @@ -9,6 +9,7 @@ if DAX
> >  config DEV_DAX
> >  	tristate "Device DAX: direct access mapping device"
> >  	depends on TRANSPARENT_HUGEPAGE
> > +	depends on !FS_DAX_LIMITED
> >  	help
> >  	  Support raw access to differentiated (persistence, bandwidth,
> >  	  latency...) memory via an mmap(2) capable character
> > diff --git a/drivers/dax/mapping.c b/drivers/dax/mapping.c
> > index 70576aa02148..5d4b9601f183 100644
> > --- a/drivers/dax/mapping.c
> > +++ b/drivers/dax/mapping.c
> > @@ -345,6 +345,8 @@ static vm_fault_t dax_associate_entry(void *entry,
> >  	for_each_mapped_pfn(entry, pfn) {
> >  		struct page *page = pfn_to_page(pfn);
> >  
> > +		page = compound_head(page);
> 
> I feel like the word folio is need here.. pfn_to_folio() or something?
> 
> At the very least we should have a struct folio after doing the
> compound_head, right?

True, I can move this to the folio helpers.