Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 21 Sep 2022 21:10:59 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Dan Williams <dan.j.williams@intel.com>
Cc:     Dave Chinner <david@fromorbit.com>, akpm@linux-foundation.org,
        Matthew Wilcox <willy@infradead.org>, Jan Kara <jack@suse.cz>,
        "Darrick J. Wong" <djwong@kernel.org>,
        Christoph Hellwig <hch@lst.de>,
        John Hubbard <jhubbard@nvidia.com>,
        linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev,
        linux-xfs@vger.kernel.org, linux-mm@kvack.org,
        linux-ext4@vger.kernel.org
Subject: Re: [PATCH v2 05/18] xfs: Add xfs_break_layouts() to the inode
 eviction path
Message-ID: <YyuoE8BgImRXVkkO@nvidia.com>
References: <166329930818.2786261.6086109734008025807.stgit@dwillia2-xfh.jf.intel.com>
 <166329933874.2786261.18236541386474985669.stgit@dwillia2-xfh.jf.intel.com>
 <20220918225731.GG3600936@dread.disaster.area>
 <632894c4738d8_2a6ded294a@dwillia2-xfh.jf.intel.com.notmuch>
 <20220919212959.GL3600936@dread.disaster.area>
 <6329ee04c9272_2a6ded294bf@dwillia2-xfh.jf.intel.com.notmuch>
 <20220921221416.GT3600936@dread.disaster.area>
 <632ba61d7666a_34962942a@dwillia2-xfh.jf.intel.com.notmuch>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <632ba61d7666a_34962942a@dwillia2-xfh.jf.intel.com.notmuch>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?mfuXFjSmWuGSlRjmMeotFschbb+RiKA+nXHpFjdTyS2MIlJP2/dNP6fI+7vD?=
 =?us-ascii?Q?+3hweXzjwqt+d5ip6r4mtmdK8lFiuGWKceVicdtPwbw70JC74wDqBxngIXCs?=
 =?us-ascii?Q?oRoXZPEeJhWrAsFqG1/hqtnb6zaq+J5G1cYGJxUiJWic5CfPB7N/HuQhktmk?=
 =?us-ascii?Q?e4Eb6PrHjJKGFy8VU6RFLwIKTuDO7nrs5SCVw++/q9m8Invh21p9bWmVUwFD?=
 =?us-ascii?Q?fTapfptrvzdZyeKBtcAoe4TNcHQZwWLBleCWsz0SDByWT5OZhXdqXUpxp0PF?=
 =?us-ascii?Q?9OVePQw2fIGgFzJ6SyY0wo4NpUa+5mCtoc7XEaEC8NMHlYbUz/GslhoU0Xgp?=
 =?us-ascii?Q?Xqr73+yuDEPPu5JXtJdf8STUIZH1T9pDSl9HPTuiddzq149BLra8OuIGFgra?=
 =?us-ascii?Q?hssFeCF2ueNzTbbeLuc+GOotQKNYsWFJ4ZObGqM8UFVxNL0INayEx0kG4zkv?=
 =?us-ascii?Q?WaBPjC2/wAwzYESlUT0A0Ng1idwOH1mTXb97T5zb4pDQAhq14uzw3ZTTu7kx?=
 =?us-ascii?Q?LkFIy9goFB8WBJcn68SKlGb5I8jg0zdP8Z12ZVrDYj7z7NUPymFMGBAdEcKW?=
 =?us-ascii?Q?H+vSXufA3zPsA/p8ycHg4j7GtTKaMHK4xIw5BT+FsHWYaPU68Wet3lL1Pnjv?=
 =?us-ascii?Q?QHsGnhlnhIi0a7/0jPtvEJ5IiZ8d/6xjX1x94Fc+Gfh2RP9IId4yLbq32JzG?=
 =?us-ascii?Q?Q7PI8l0q179z6CU3O58Wx7hm7C9GAcATM+Dub9GtudaPhpu6mTvNI6JYRF2a?=
 =?us-ascii?Q?qKayuDfl1GrYAVjsXNPbpiu2UZs1kh6NXvxb/Gt04xj3hqNsL+dVDijyXpYi?=
 =?us-ascii?Q?M1RHl7XxiWVC8w9fgChjpb2DPbce/balKfNGa0gOF64CXpvDcpmPMsxDJ/lM?=
 =?us-ascii?Q?LdBYJ8YmyKNpnjde/NeRmABKJwgBj+4jPHde9PR2FISh/nw6vgRvBFpkfJgh?=
 =?us-ascii?Q?6qM1xzqJTbhMDsNHEfqYDFQ/QM9yK1l5YLAf+k2J9pIHcJOWJl3HbOdRHLj5?=
 =?us-ascii?Q?Lxp/mOQkP8lg7UwumESy9pa8zS+dSC4oDatslSo996gflwdbZroidWQurxa4?=
 =?us-ascii?Q?c8LaS/dDBNV7PmfMUBohVEII2s/SXJ/DVFo+6+eTlVNeRC79SEamqlLvlBoI?=
 =?us-ascii?Q?yab/eHkY2X4skIrm4KjwJOwOWfvS0yXCLZQ6eTgRtk70HVawfF003ejkz6xl?=
 =?us-ascii?Q?u3mUca7cb8aHY9UcBQZxyCGxFsHjvoBX4K92nhxPAa6EnXE5XC98zc/v2aCt?=
 =?us-ascii?Q?pK/pI9AIFyXGcO85LWuhXGCwayWDKKv3sGkw3xKM5PSbZ/BdCAelgODg5E7h?=
 =?us-ascii?Q?qhEhXTqBU7RIsd3pQX2Pl7GQ1naC3+ol8pgPEdMI5n3EKzui5EfIhGAakO2/?=
 =?us-ascii?Q?dRV9ouBhSY+8B6JOkSv3cvvBSrEQxGjjvwFqNEYia2g9tmSjPijToFEFG7zM?=
 =?us-ascii?Q?3OnsICHs2mO49WcF/DfcYl/lpM46bJgFKFsIqJvGXyco8HB1kWRs+syz6A56?=
 =?us-ascii?Q?ya8r/TO1PeTHOIxBq6AvZgsLvGbJRixSQF2Eq+xNQSIHLGirhbAO7Ku5kRpJ?=
 =?us-ascii?Q?YiZbr/HoGjieU3jDKjvUwFSf8tuu8cokX+/7+GM/?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 29c44de1-b3ac-465d-220b-08da9c2eee12
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2022 00:11:00.4503
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: U9SkevczG4Y855p7wEZk2tbUJnb5aAkRtH40Fkw64EqnsIHqmV1HArpXmMwoc3nx
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5731
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-ext4.vger.kernel.org>
X-Mailing-List: linux-ext4@vger.kernel.org

On Wed, Sep 21, 2022 at 05:02:37PM -0700, Dan Williams wrote:

> The scenario I cannot convince myself is impossible is a driver that
> goes into interruptible sleep while operating on a page it got from
> get_user_pages(). Where the eventual driver completion path will clean
> up the pinned page, but the process that launched the I/O has already
> exited and dropped all the inode references it was holding. That's not
> buggy on its face since the driver still cleans up everything it was
> handed, but if this type of disconnect happens (closing mappings and
> files while I/O is in-flight) then iput_final() needs to check.

I don't think you can make this argument. The inode you are talking
about is held in the vma of the mm_struct, it is not just a process
exit or interrupted sleep that could cause the vma to drop the inode
reference, but any concurrent thread doing memunmap/close can destroy
the VMA, close the FD and release the inode.

So userspace can certainly create races where something has safely
done GUP/PUP !FOLL_LONGTERM but the VMA that sourced the page is
destroyed while the thread is still processing the post-GUP work.

Jason