Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp426874rwb; Thu, 22 Sep 2022 21:24:05 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4O7dYr5uJIKLyNeEdbm5rh84oAYlyS3ynMiU6k8ja2qJQAERppXZ88X2/I+zsK2M26axzJ X-Received: by 2002:a17:903:25d3:b0:176:e9d3:64bc with SMTP id jc19-20020a17090325d300b00176e9d364bcmr6542877plb.45.1663907044883; Thu, 22 Sep 2022 21:24:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663907044; cv=none; d=google.com; s=arc-20160816; b=Uc/+Nm6kOIu0yQR2NKWvjplZGW7AqLp+QnnNyUG1lFWPrvyE6M81tsk4Wrb5mv5hf4 3fn0RJetbmJRKtnJSJQBoMV7Nug9zlZ6p7DJgPVu/t5qbtvAxqEsEfPvDkeS8Pf9Xy+8 FjXQL8zdF8zbsIEcL+XIqo8REe9Xl4SQ8DBhrr+MBkmko5z1740i1ADK/cExCxZE6KaB zfEZI9bTKGpVeHqMKo34tQsLP65t93QH4+8FgmeXocgxzToiNm2/PO8bDnFutOsFaUYu 3hBFq9u6WGfHrzIxDcljKzm3pl40l12r727OZfQHk7+A91GqAJ9oZ8j8EsV/s3fhriI6 SkVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=8q2l4xojuuBiYN/VbjMNdtw6txtw3PgvF4ZhLb49mp8=; b=IF99SvBJiOcMmNcCdPFsHw5L2wNO3sKB/PCvXo8jsZp1lHaIbmENdFvL90/A0IJYHw IuNg+0fBk+BGpeTQdfUREsb/iiwRBDlREUV39TedvIjuO3qWMPwhK2Pml1PkBwgcPkfN ddyZQACHrZG2vuNrhPGkB7/kUbCj0DaX+KEU+FUAx6UH8gfejNt0AYxWWRBjOr18+COO 19QrR+jFP8aGjBoGfEbMxbHW4+6nfVbvdQhhc459pEd0heiVaVpax/jNL4Zkyj64hd1M D59eTvBzEI5PLIkteCNd1xeDzYMunOVYsHF006cNu+0PGy00675oe01YiCJKKklSbG4T qiHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QnpbsClm; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t2-20020aa79382000000b0054796c5f15bsi6946442pfe.124.2022.09.22.21.23.27; Thu, 22 Sep 2022 21:24:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QnpbsClm; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232459AbiIWDsv (ORCPT + 99 others); Thu, 22 Sep 2022 23:48:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232307AbiIWDst (ORCPT ); Thu, 22 Sep 2022 23:48:49 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB658118B3D for ; Thu, 22 Sep 2022 20:48:48 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 708D6B819DB for ; Fri, 23 Sep 2022 03:48:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E123AC433C1; Fri, 23 Sep 2022 03:48:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663904926; bh=+Q6aM8zRScMQ2iGfiaiyZLKK4o8MFTRoU/8COnemOPs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QnpbsClmfb04NpMflLccEzDO4mH4k4XIK7/Gmrmco139wpNzgmh4kahmkGWQLi1Zr iQASs7IboeOiZzRlNykeekuhqyul+tH9QhLGPPQTyXv55lvTcMtX8NWaLiP7jdxIH1 zeBYSen8kwQ0//cUVukq3dNdIs5aawFAt8teaJQZPRipqF4Q2JxFAysRBTdFG15lVY nRFktK2/1kSSY17d5zOYIl7otCJvOw6V7zg2BpWw+dMN9BF1jECviMzgj46xAD3Lxc ShGZmgLDzOpX1TfExaeYPhkAkuqxuHkeu4J+WhAJWAhR72xesrl6UxjJc9/UYtsbL1 6qfjUOX8+krJA== Date: Thu, 22 Sep 2022 20:48:44 -0700 From: Eric Biggers To: Gabriel Krisman Bertazi Cc: tytso@mit.edu, adilger.kernel@dilger.ca, jaegeuk@kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, kernel@collabora.com Subject: Re: [PATCH v9 4/8] ext4: Reuse generic_ci_match for ci comparisons Message-ID: References: <20220913234150.513075-1-krisman@collabora.com> <20220913234150.513075-5-krisman@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220913234150.513075-5-krisman@collabora.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, Sep 13, 2022 at 07:41:46PM -0400, Gabriel Krisman Bertazi wrote: > Instead of reimplementing ext4_match_ci, use the new libfs helper. > > It also adds a comment explaining why fname->cf_name.name must be > checked prior to the encryption hash optimization, because that tripped > me before. > > Signed-off-by: Gabriel Krisman Bertazi Reviewed-by: Eric Biggers - Eric