Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 26 Sep 2022 10:15:21 +0200
From:   Jan Kara <jack@suse.cz>
To:     Ye Bin <yebin10@huawei.com>
Cc:     tytso@mit.edu, adilger.kernel@dilger.ca,
        linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
        jack@suse.cz
Subject: Re: [PATCH -next v2 1/2] ext4: remove unnecessary drop path
 references in mext_check_coverage()
Message-ID: <20220926081521.szxq4qizpz54opcm@quack3>
References: <20220924021211.3831551-1-yebin10@huawei.com>
 <20220924021211.3831551-2-yebin10@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220924021211.3831551-2-yebin10@huawei.com>
Precedence: bulk

On Sat 24-09-22 10:12:10, Ye Bin wrote:
> According to Jan Kara's suggestion:
> "The use in mext_check_coverage() can be actually removed
> - get_ext_path() -> ext4_find_extent() takes care of dropping the references."
> So remove unnecessary call ext4_ext_drop_refs() in mext_check_coverage().
> 
> Signed-off-by: Ye Bin <yebin10@huawei.com>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  fs/ext4/move_extent.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/ext4/move_extent.c b/fs/ext4/move_extent.c
> index 701f1d6a217f..782bbda2a717 100644
> --- a/fs/ext4/move_extent.c
> +++ b/fs/ext4/move_extent.c
> @@ -103,7 +103,6 @@ mext_check_coverage(struct inode *inode, ext4_lblk_t from, ext4_lblk_t count,
>  		if (unwritten != ext4_ext_is_unwritten(ext))
>  			goto out;
>  		from += ext4_ext_get_actual_len(ext);
> -		ext4_ext_drop_refs(path);
>  	}
>  	ret = 1;
>  out:
> -- 
> 2.31.1
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR