Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp201618rwb; Mon, 26 Sep 2022 11:06:30 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7+1kKpWvBwZEWt/KaTkPw60+SLCLGd3eJCO38E8JNAsXK7opA9cYwBgVabi5VRb3HP2Xnf X-Received: by 2002:a05:6402:1455:b0:456:e24a:59a5 with SMTP id d21-20020a056402145500b00456e24a59a5mr15718547edx.298.1664215590700; Mon, 26 Sep 2022 11:06:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664215590; cv=none; d=google.com; s=arc-20160816; b=dIYHnwadkdtXKtaqWpvRVTtU714coxozHR1LiZyy2YITfwsyFl+Iwk7W4fgvNLv/KB MDvMdpqNtjI/+EShw70/yGpebPvPZCgHgvMIk1ydWKpgj2eJyeb2vpJW1oUYKXcFXjQZ nObUlOXIb7uakdnksZeOdPXANeJgVsiBZZgCPlgvFylPCw+oGSj5UMTTJIjAHn2MgIA4 geNI7Qdc+Y3fMcOBTrOXu83T4bGBRDgwESxsl0HaxeXdzB7v862wxpzh92O32cW0NOei Ii/q8W8Stcr54TJM8F6SqUsZ5S2KAZEhO49LYiDidtltdIJTsHDzZP8dWRqqq82L2UfH UY3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=YMM3AaX/KN+4rmSmHEPW/8P60W72WjElwRSGsItg/ME=; b=vuZoLskgr8/Sl77gPNtlNO6pCk0XZC9nWZnzvA/2RUJ+LEKLRskg/F54I3YYp1oEA4 IrwFZmfGX5CilAcX6UR35saF4JBeXsMlA5UvM1Sfx1YOU2k+MK/4PmYUvcWnVkbX21hd Nm/bWDOTaEAIRKpwZyiEdzzQHbcTqmUPJEksW3cOGKS09C2euagvLL46UebM4tI6gIBs FYvfrP2AcpvIAD2K/Nxk9/ZcbiqdWSQ3R7BKSd7Us0BDzz4aYIG41xLEYVVI5nZi66DJ xLIXnuxQRkuYMUIuWvZ/ZcquuU+H5g4sijxxOhU7b17g9GfkPjfLWAXtL9c1ipiAm2R9 dXkQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b=EXRHbov4; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dr4-20020a170907720400b00780d58a6ac8si607817ejc.804.2022.09.26.11.05.31; Mon, 26 Sep 2022 11:06:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b=EXRHbov4; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230381AbiIZR4E (ORCPT + 99 others); Mon, 26 Sep 2022 13:56:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230337AbiIZRzg (ORCPT ); Mon, 26 Sep 2022 13:55:36 -0400 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C6DF63F06; Mon, 26 Sep 2022 10:32:56 -0700 (PDT) Received: from cwcc.thunk.org (pool-173-48-120-46.bstnma.fios.verizon.net [173.48.120.46]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 28QHWcvb001686 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 26 Sep 2022 13:32:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1664213561; bh=YMM3AaX/KN+4rmSmHEPW/8P60W72WjElwRSGsItg/ME=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=EXRHbov4H+arsPBg4xbppsLVAiSCAd4h8YWgCZXz3ek8HCYT5liQCykeuhSSJxKUz dtMbMHCUgptChMoyuX1SspUc63WFD+GHNvUcn7gzKKQtGak4EzK7YkTV3gBF//Qv2g 2bvPotzOfgW9LN6G7cjKMEPoIJUSI/0H9KSBDrBes1X5LwXMKDxPTEE1Zd2rdHDSm2 QnAdLUSLnmDYyWdOBBm2Y2fwAlvAvqMf9hTLd+x0jEHKS0KcLXfZlQ7oOpBZK2dSRc n4aA54/9Pw5eh8ICIGCk8N1wM3GFRi0Vx3tgdgFmXYNJEltCisvclksGy0JRaVhJ/D DN1wh1T+K4jcQ== Received: by cwcc.thunk.org (Postfix, from userid 15806) id 3E1F515C526C; Mon, 26 Sep 2022 13:32:38 -0400 (EDT) Date: Mon, 26 Sep 2022 13:32:38 -0400 From: "Theodore Ts'o" To: Jan Kara Cc: harshadshirwadkar@gmail.com, stable@vger.kernel.org, ritesh.list@gmail.com, stefan.wahren@i2se.com, ojaswin@linux.ibm.com, linux-ext4@vger.kernel.org, regressions@leemhuis.info Subject: Re: [PATCH 1/5] ext4: Make mballoc try target group first even with mb_optimize_scan Message-ID: References: <20220908091301.147-1-jack@suse.cz> <20220908092136.11770-1-jack@suse.cz> <166381513758.2957616.15274082762134894004.b4-ty@mit.edu> <20220922091542.pkhedytey7wzp5fi@quack3> <20220926091126.yx25wgeibxabmcaj@quack3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220926091126.yx25wgeibxabmcaj@quack3> X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, Sep 26, 2022 at 11:11:26AM +0200, Jan Kara wrote: > > Ted, I've noticed you've merged my mballoc fixes (and pushed them to Linus) > without this fixup. Can you please merge it? The use of uninitialized > variable seems rare but possible... Oops, sorry my bad. I had forgotten to merge the fix before I pushed them to Linus. I'm preparing a follow-up push to Linus right now. Once a smoke test passes, I'll sned out the pull request. - Ted