Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Theodore Ts'o" <tytso@mit.edu>
To:     jack@suse.cz
Cc:     "Theodore Ts'o" <tytso@mit.edu>, tadeusz.struk@linaro.org,
        syzbot+bd13648a53ed6933ca49@syzkaller.appspotmail.com,
        linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: Avoid crash when inline data creation follows DIO write
Date:   Tue, 27 Sep 2022 17:53:32 -0400
Message-Id: <166431556705.3511882.4814006809885292570.b4-ty@mit.edu>
In-Reply-To: <20220727155753.13969-1-jack@suse.cz>
References: <20220727155753.13969-1-jack@suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Wed, 27 Jul 2022 17:57:53 +0200, Jan Kara wrote:
> When inode is created and written to using direct IO, there is nothing
> to clear the EXT4_STATE_MAY_INLINE_DATA flag. Thus when inode gets
> truncated later to say 1 byte and written using normal write, we will
> try to store the data as inline data. This confuses the code later
> because the inode now has both normal block and inline data allocated
> and the confusion manifests for example as:
> 
> [...]

Applied, thanks!

[1/1] ext4: Avoid crash when inline data creation follows DIO write
      commit: 4331037750fdd4c698facc8a03075f88f15ffbe6

Best regards,
-- 
Theodore Ts'o <tytso@mit.edu>