Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: ext4_writepages: jbd2_start: 5120 pages, ino 11; err -5
To:     Theodore Ts'o <tytso@mit.edu>
Cc:     Jan Kara <jack@suse.cz>, linux-ext4@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, dm-devel@redhat.com,
        it+linux@molgen.mpg.de,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <4e83fb26-4d4a-d482-640c-8104973b7ebf@molgen.mpg.de>
 <20220531103834.vhscyk3yzsocorco@quack3.lan>
 <3bfd0ad9-d378-9631-310f-0a1a80d8e482@molgen.mpg.de>
 <YpY2o/GG8HWJHTdo@mit.edu>
From:   Donald Buczek <buczek@molgen.mpg.de>
Message-ID: <302f2af1-eee8-95aa-91f5-55fe5cf8727f@molgen.mpg.de>
Date:   Wed, 28 Sep 2022 12:10:43 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.1
MIME-Version: 1.0
In-Reply-To: <YpY2o/GG8HWJHTdo@mit.edu>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/31/22 5:39 PM, Theodore Ts'o wrote:
> Hmmm..... I think this patch should fix your issues.

Thanks a lot. Unfortunately, it didn't, I still occasionally get

    [368259.560885] EXT4-fs (dm-0): ext4_writepages: jbd2_start: 344 pages, ino 279244; err -5


D.


> 
> If the journal has been aborted (which happens as part of the
> shutdown, we will never write out the commit block --- so it should be
> fine to skip the writeback of any dirty inodes in data=ordered mode.
> 
> BTW, if you know that the file system is going to get nuked in this
> way all the time, so you never care about file system after it is shut
> down, you could mount the file system with the mount option
> data=writeback.
> 
>        	      	      	    		- Ted
> 
> 
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 8ff4c6545a49..2e18211121f6 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -542,7 +542,10 @@ static int ext4_journalled_submit_inode_data_buffers(struct jbd2_inode *jinode)
>  static int ext4_journal_submit_inode_data_buffers(struct jbd2_inode *jinode)
>  {
>  	int ret;
> +	journal_t *journal = EXT4_SB(jinode->i_vfs_inode->i_sb)->s_journal;
>  
> +	if (!journal || is_journal_aborted(journal))
> +		return 0;
>  	if (ext4_should_journal_data(jinode->i_vfs_inode))
>  		ret = ext4_journalled_submit_inode_data_buffers(jinode);
>  	else
> @@ -554,7 +557,10 @@ static int ext4_journal_submit_inode_data_buffers(struct jbd2_inode *jinode)
>  static int ext4_journal_finish_inode_data_buffers(struct jbd2_inode *jinode)
>  {
>  	int ret = 0;
> +	journal_t *journal = EXT4_SB(jinode->i_vfs_inode->i_sb)->s_journal;
>  
> +	if (!journal || is_journal_aborted(journal))
> +		return 0;
>  	if (!ext4_should_journal_data(jinode->i_vfs_inode))
>  		ret = jbd2_journal_finish_inode_data_buffers(jinode);
> 


-- 
Donald Buczek
buczek@molgen.mpg.de
Tel: +49 30 8413 1433