Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp2136911rwb; Thu, 29 Sep 2022 06:44:06 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6xmIuOAlhp+NJXCkXP0HCrTAWXC7zbGcDry/a/bMnbI0SMKoWsSZyEW5huhCaE3UzK0TLN X-Received: by 2002:aa7:c90c:0:b0:457:df26:bfa0 with SMTP id b12-20020aa7c90c000000b00457df26bfa0mr3355003edt.280.1664459046037; Thu, 29 Sep 2022 06:44:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664459046; cv=none; d=google.com; s=arc-20160816; b=E7cEow6qhjmiL68Uonl40j8fY2qBN6a9plDqx42yY8CFiBWgE2cXacgI6ElXc86Odx pkKAlLFWFjswrXgMgKNp+bwt0lo00rmYTIlTg3b+LTnF+d6TpjH+a+CxiUjgpoQ6zQiz UHQG1NE/6QcFuBdjjK1h2ZCEEzIQfwLRn055iajeZiYKJkXUUV0J+FWlcSacjDWLUceH ua0ecs5xfFfHK+MIX37/7RqSgJx6Y2FRISa/WNNZ34dnMJ1znDhJZq4hrXzx6I27W29x MOGE7aEtoOlXhWB+5COLO0MOmDTSEDWMOjipi+s1sI0LQ06yyO9GnkfJBlF6VktgIRzv NRNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :dkim-signature; bh=Ns2J5FCqMyaCVXAnlOwlYGE0L/n4dIeDiQPDs896ezA=; b=QtyXgPkuuRsbx+3fGAcw6VWbrkRr953ZNichmRQP/sXshblivZQzbj7Uc6gyC/XbAB iLsOu1aPIzkhlo7FkFPBub6I366jZj99gSkDFEhn0B4a77cGs0a7Jy5tVgdXut5Ndk0y sctBsJ2G7aqxLq8yAsF8OnqZ38n4k06KVbu5MFIUeXErfl8UZozWadiEoLWiEviSUNlP EIrAkWIN/yYl84PxeJ2QG6uggETKax3sNB44dwxd2L6fz9N9o5lCQfnCnFKvcvxwm/Xc 7XIhDWr/Reve6u2UwaAhliM/1aS51MD2TnJmKu/mjLghU+ytsD22PbzEVYcR2HwCTtjb U9Tg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=IjHgqEyc; dkim=neutral (no key) header.i=@suse.cz header.b=TuFYLQQc; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z15-20020a05640240cf00b00457140a6322si8782244edb.283.2022.09.29.06.43.33; Thu, 29 Sep 2022 06:44:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=IjHgqEyc; dkim=neutral (no key) header.i=@suse.cz header.b=TuFYLQQc; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234751AbiI2NjY (ORCPT + 99 others); Thu, 29 Sep 2022 09:39:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234856AbiI2NjX (ORCPT ); Thu, 29 Sep 2022 09:39:23 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0AAAC18A48F; Thu, 29 Sep 2022 06:39:22 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C1FE81F8AC; Thu, 29 Sep 2022 13:39:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1664458760; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ns2J5FCqMyaCVXAnlOwlYGE0L/n4dIeDiQPDs896ezA=; b=IjHgqEycgP5J5wD2VLtonf+O1JFaEAlB2L/rY9szh34RIByWZDffula3+ZxNprIQvguaAG uEgekbkMgXYkvo1ApZ5trxjIixhRO2mrk1cf7bDAsSwjOieA97PVgsp1g/30wnWDEV5rET Iv7mvC2sImR4NKq151WheRZNvzxFSz8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1664458760; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ns2J5FCqMyaCVXAnlOwlYGE0L/n4dIeDiQPDs896ezA=; b=TuFYLQQcGaR9AcwAgJye4uhGokl2Gf8cI0mVsUFJsMZpMFPwN5EohuYrzfk+e4PYT0s3Tt OGy9UulWHTUO8xBw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B47331348E; Thu, 29 Sep 2022 13:39:20 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id fsUALAigNWPMKwAAMHmgww (envelope-from ); Thu, 29 Sep 2022 13:39:20 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 4EDB8A0681; Thu, 29 Sep 2022 15:39:20 +0200 (CEST) Date: Thu, 29 Sep 2022 15:39:20 +0200 From: Jan Kara To: Zhihao Cheng Cc: jack@suse.com, tytso@mit.edu, brauner@kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, yukuai3@huawei.com Subject: Re: [PATCH v3 0/3] Check content after reading from quota file Message-ID: <20220929133920.ckqbg7qjm557yyp3@quack3> References: <20220923134555.2623931-1-chengzhihao1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220923134555.2623931-1-chengzhihao1@huawei.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Fri 23-09-22 21:45:51, Zhihao Cheng wrote: > v1->v2: > Add CC-stable tag in first patch. > Rename check_free_block() -> check_dquot_block_header(). > v2->v3: > Define do_check_range() completely in patch 1. > Move 'dqdh_entries' checking into check_dquot_block_header(). > Do block checing later in find_next_id(). > > Zhihao Cheng (3): > quota: Check next/prev free block number after reading from quota file > quota: Replace all block number checking with helper function > quota: Add more checking after reading from quota file > > fs/quota/quota_tree.c | 73 ++++++++++++++++++++++++++++++++++++------- > 1 file changed, 61 insertions(+), 12 deletions(-) Thanks! I've merged the patches to my tree now! Honza -- Jan Kara SUSE Labs, CR