Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 29 Sep 2022 10:20:47 -0400
From:   "Theodore Ts'o" <tytso@mit.edu>
To:     Marc =?iso-8859-1?Q?Aur=E8le?= La France <tsi@tuyoix.net>
Cc:     Andreas Dilger <adilger.kernel@dilger.ca>,
        linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ext4: Register ext[23] support only after successful
 ext4 registration
Message-ID: <YzWpv8ZKJ7BrOBsg@mit.edu>
References: <7ef87cdb-0d0b-2488-6f42-a670a6454630@tuyoix.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <7ef87cdb-0d0b-2488-6f42-a670a6454630@tuyoix.net>
Precedence: bulk

On Wed, Aug 10, 2022 at 02:20:45PM -0600, Marc Aur?le La France wrote:
> Register ext4 as a "replacement" for ext2 and ext3 only after ext4 itself has
> been successfully registered.  As a side effect, this allows
> unregister_as_ext[23]() to be inlined.

The corrent ordering is deliberate; it allows file systems that have
ext2 and ext3 only file system features will be reported as using ext2
and ext3 in /proc/mounts.  This doesn't matter quite as much, but it
could potentially break userspace if a legacy file system that only
has ext2 file system features is mounted and reported as ext4.

So sorry, I can't take this change.

					- Ted