Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 29 Sep 2022 15:38:12 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Alistair Popple <apopple@nvidia.com>,
        Dan Williams <dan.j.williams@intel.com>
CC:     <akpm@linux-foundation.org>, Matthew Wilcox <willy@infradead.org>,
        "Jan Kara" <jack@suse.cz>, "Darrick J. Wong" <djwong@kernel.org>,
        Jason Gunthorpe <jgg@nvidia.com>,
        Christoph Hellwig <hch@lst.de>,
        John Hubbard <jhubbard@nvidia.com>,
        <linux-fsdevel@vger.kernel.org>, <nvdimm@lists.linux.dev>,
        <linux-xfs@vger.kernel.org>, <linux-mm@kvack.org>,
        <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH v2 12/18] devdax: Move address_space helpers to the DAX
 core
Message-ID: <63361e5471f48_795a6294be@dwillia2-xfh.jf.intel.com.notmuch>
References: <166329930818.2786261.6086109734008025807.stgit@dwillia2-xfh.jf.intel.com>
 <166329937873.2786261.10966526479509910698.stgit@dwillia2-xfh.jf.intel.com>
 <87y1u5jpus.fsf@nvdebian.thelocal>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <87y1u5jpus.fsf@nvdebian.thelocal>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FJCT64327Zk1+P6FS86jRLebvTpGoTaEcKdwtr3kPYO7+0YIg/NMmcXAMiE1?=
 =?us-ascii?Q?/kmYi3bZ7sNUBK1+MEsjnipCDeLbdyzcylh3grSccCqku4Z/tiRKaUi1+gTE?=
 =?us-ascii?Q?QobAu1YECU6aRPWG9laVWVKOET4UJb1p5Ur9g7HXNQfF3ZH0aNobvF8KWgli?=
 =?us-ascii?Q?IDlcxw5bcrSJF8AEZhxMFwzNUKrbIN//ivYwKhaQq8COBEuSQIxq9ipKtBjr?=
 =?us-ascii?Q?/3dq1mF/G9d3GGUr0rTbDrzsNWLwT4+v7tEnVWa9LOqD0aMFnUJo19MGm0H5?=
 =?us-ascii?Q?bCTBvQBFR1JlpLx4YzOYbvr59oVi2ykYuPuDP0qTzuFBy1z6jykx0HFlKuv8?=
 =?us-ascii?Q?XO6t8bNocQ4+H1oSmCv7g+ZEaTpb4es5FyTH3PRmtz7bqRg7xVdZjOTszma7?=
 =?us-ascii?Q?uB0Htki89NwCITo2P7atATwq4wVB2i19ALx0kap8YzeuvPR/VouVkh9+vqia?=
 =?us-ascii?Q?t0yxXngY/ZLEx68hD0WOXlGBF/pnbGZlOSUkSyUC+m95obuyAVEV6nPrDoFN?=
 =?us-ascii?Q?qKBAqpHy3/277FtvZ0ZoyFk1c48kYsLyhBuC/WotGzhhnNsp0vpLUuRgJc6q?=
 =?us-ascii?Q?lSwyqomCE1aEWYja0Kyb1VqYCVEfYjhfREPir3Y0ff8N4O+9jBK1ZT5XAIuf?=
 =?us-ascii?Q?P6EiSNKXZggNEzbH4bql4ALtX/vLwfD4l+/EVkuK93RtR8nQHFHafLJMB/g+?=
 =?us-ascii?Q?bAHlQwWbAIFLyl912KQoG+BGiiowu37kvp9jkt5yEDbf/DBPuYaFBt6CRqCz?=
 =?us-ascii?Q?3rR0RY+45E2VfBHCBQCjFW+42tts7RcluhNwEll67OW2WwVvhSws43tQZRiG?=
 =?us-ascii?Q?6OIUp4joJoU6TsGF+L+Wd3c3XZcgnVmH+qQCIRaB+E5/AOyKtGoP8kEgKClv?=
 =?us-ascii?Q?ns3OKr2j56G5psGqncA8QV9n5RYQQWqulj81L7G+y+cnCgLmUWAJEFmUhc8H?=
 =?us-ascii?Q?EY963cZIbg866FXn65dxv46ZRSjIl6eTv2NWMeXTxyDFN/Yf74fYS3BU3R2Z?=
 =?us-ascii?Q?0A2BF95dAyaoSrkk3BnYwfoyLNA09kCjEvH8huX9ld9+VS4frV1Nzvd5LhQ5?=
 =?us-ascii?Q?yM5iJI7dMYFKjwb9WRYJYOBbL8wDBzi/fpF93zsw9S3NnAzAuMUBA1Y2yve/?=
 =?us-ascii?Q?rzMm+fKcUo/K5EggxcNOHSLuD5cL7Zp0hHLPJrfWny6j9TojL4LUZCWD/1AE?=
 =?us-ascii?Q?FCMwYK8Bh6glxGVRLr/o6qb4AQhyOIpV2ewtdEP5mnWHjChw/KzNzrCEA03U?=
 =?us-ascii?Q?8IOokAoQ+NdZb0R4oDKJdJB8MGSyXu0G9TnP+lAY9xgxO+GeQ9fUw8GTQIc6?=
 =?us-ascii?Q?gEuVForrAzpHBfWvW7oslLIbhh55cSRmKjkmUYCHFMo6xrau2ctPu3MHpoU2?=
 =?us-ascii?Q?pa1aXE4N95iKZ6otlz7BP3upQ4/+8G+druriidhigsVVNzEaVAfc0V4z4pIL?=
 =?us-ascii?Q?j/x9MxNzb7EggTQ5A2TgbpXc/gS1+pjxiPw6ITapZFiaU/zPHDI/tRdVTjiT?=
 =?us-ascii?Q?aCooqJPskZVSbofAS3y5kA0aQCN4VZ/2Rolf6LOspTwg82AYa81CLWus6McP?=
 =?us-ascii?Q?53ZGzm8ygFqIRgjxIy//zCn/Gp1wz5EGXaR/MFBIZlC93CoQ4Baazn0z6WZk?=
 =?us-ascii?Q?ig=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8cefcad1-bc00-42d3-2974-08daa26b4c25
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2126.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 22:38:15.1238
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Y5w+aji4qXJupkcL15EnrxPU/e0/LmnHLrW5WV9Ccr+I0fnpL7NRX3MtDTb5MX2gujoOw6iPVR5M8K9Iz860ANSXEVLfu0U6Wz8xuaJ8ta0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7091
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-ext4.vger.kernel.org>
X-Mailing-List: linux-ext4@vger.kernel.org

Alistair Popple wrote:
> 
> Dan Williams <dan.j.williams@intel.com> writes:
> 
> [...]
> 
> > +/**
> > + * dax_zap_mappings_range - find first pinned page in @mapping
> > + * @mapping: address space to scan for a page with ref count > 1
> > + * @start: Starting offset. Page containing 'start' is included.
> > + * @end: End offset. Page containing 'end' is included. If 'end' is LLONG_MAX,
> > + *       pages from 'start' till the end of file are included.
> > + *
> > + * DAX requires ZONE_DEVICE mapped pages. These pages are never
> > + * 'onlined' to the page allocator so they are considered idle when
> > + * page->count == 1. A filesystem uses this interface to determine if
> 
> Minor nit-pick I noticed while reading this but shouldn't that be
> "page->count == 0" now?

I put this patch set down for a couple days to attend a conference and
now I am warming up my cache again. I believe the patch to make this
zero based comes later in this series, but I definitely did not come
back and fix this up in that patch, so good catch!