Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp3059893rwb; Thu, 29 Sep 2022 20:21:40 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5nHlONpXsnVSSHX11wAGNGj+nzqh7KTN2JKYXFpruk0AbWev1qZe/ezRD5Nlep3ZYuGh2o X-Received: by 2002:a63:6cc3:0:b0:43c:7585:1ec with SMTP id h186-20020a636cc3000000b0043c758501ecmr5747631pgc.571.1664508099789; Thu, 29 Sep 2022 20:21:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664508099; cv=none; d=google.com; s=arc-20160816; b=X66NRvd239KBAtHERuGRJh0Q+EnFCDPaYWITo1IslvdVIFybD4XqQqAihyaUvm0YF/ RF97AtXAe4BjBix6IEYEjomLmS9q9jRCiCME25PAztZD++4hTbunDTkGFcFXF8EF9bMj e7ZmegahgMF2CHERpYxCNZjcTEq63jg7yP98jnwwITlOK72osx3uXoqfr/WqBuAyPjPe tKtzxYNqaRyOLfywV5jLfPPbJ/2URyR0/VLq3cg7WlTQrd5wWmYOHyEiBprUAAuoCqCl yhLZV//vjQiwxKHVV4B5Dwc0I0b986ywlrfHEpbtY1B50EP6w0F0Lc4PCYFdiJ1deobx eyLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=RNnEUzk72r2UUhbmcnm5zy/8mne8jVwvTdepoA/0vrA=; b=Jau5RwK47OoAMn6KicS9mFGjOqldBlBv2qG8j4J5jdX5g0l5vib2DVU7YXW2R8157w Ay3q5en6ulbJNQa3jLzrMBv5gycauVvywPpwkC2YAY/FJ9uwbax+MJsqqXsPA4xIbopK pmLArUPeKE9QTObYT3UkD2sjvOMh8EIBefZV1sm1HoZwjoi/q08yRsao/fz4faCFqC0L 4SAmhVTq0GHjP4Mt0dqEaS0U3IDe2Nt7OqEXzc26IIPOIdVXljMZBdVYBV8mnifJ383F dilo1JHv3vVt8P7v8Mvcq7NH/gRiy3vT64PHfcyzbkuKb8L0qCOqAN/9HpGFZ8R3cQUb VgRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b=IraIG3Xg; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c188-20020a6335c5000000b0041bdae7558esi1520861pga.653.2022.09.29.20.21.18; Thu, 29 Sep 2022 20:21:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b=IraIG3Xg; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230051AbiI3DUD (ORCPT + 99 others); Thu, 29 Sep 2022 23:20:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230064AbiI3DT6 (ORCPT ); Thu, 29 Sep 2022 23:19:58 -0400 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C79825E89 for ; Thu, 29 Sep 2022 20:19:56 -0700 (PDT) Received: from cwcc.thunk.org (pool-173-48-120-46.bstnma.fios.verizon.net [173.48.120.46]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 28U3JlGK002419 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 29 Sep 2022 23:19:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1664507989; bh=RNnEUzk72r2UUhbmcnm5zy/8mne8jVwvTdepoA/0vrA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=IraIG3Xghe0LreXYjtt6Dxm3SIswy4/JBfkjjAOBZjd4vyY10kcPeQr99lFlzVIAV BkV13IKtKClSvE9J2rOAuhSIsPJnm2V6JWf5DOYnZ89MyEOZtJV3WMGxG115RVFjYx qELcbJB5y+zF09KVKAaYrlN5KjoE7YGLHGF7ABQb9B/f38XZhU0YQvsMXscEf8fp+M XZ9MVrD1Db9DV9AeKt2VUZmVXoze2ifq2hR0MAWQ4tNX2EzSNYBRqSYRJIFUQaBD6q T5Cdkabtl6Fx0r6oJKxJCOYfFq4YN9pSsUf/4JXMba48QWJ6L3NfvOYj4JlwieYA2g MOK++EnjkxiMw== Received: by cwcc.thunk.org (Postfix, from userid 15806) id 8E33515C3443; Thu, 29 Sep 2022 23:19:47 -0400 (EDT) From: "Theodore Ts'o" To: adilger.kernel@dilger.ca, guoqing.jiang@linux.dev Cc: "Theodore Ts'o" , linux-ext4@vger.kernel.org Subject: Re: [PATCH] ext4: remove redundant checking in ext4_ioctl_checkpoint Date: Thu, 29 Sep 2022 23:19:34 -0400 Message-Id: <166450797717.256913.6262236365363903982.b4-ty@mit.edu> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20220918115219.12407-1-guoqing.jiang@linux.dev> References: <20220918115219.12407-1-guoqing.jiang@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Sun, 18 Sep 2022 19:52:19 +0800, Guoqing Jiang wrote: > It is already checked after comment "check for invalid bits set", > so let's remove this one. > > Applied, thanks! [1/1] ext4: remove redundant checking in ext4_ioctl_checkpoint commit: 0a13172182a4d896bddfb42c06c85199fc526104 Best regards, -- Theodore Ts'o