Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp3059896rwb; Thu, 29 Sep 2022 20:21:40 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5q2blIhiWswpH9INuPWrHlMiGFqd7Xn4csI4g4oQkL2+ZgV78OB4NMETtGrNdhqAgD4OSp X-Received: by 2002:a17:902:834c:b0:178:be25:203c with SMTP id z12-20020a170902834c00b00178be25203cmr6752401pln.96.1664508099797; Thu, 29 Sep 2022 20:21:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664508099; cv=none; d=google.com; s=arc-20160816; b=R6XrrdMrpHtnFdPP1tBnND4yhsk8v92sVaNiY2Dlc/Mp5viaDdKmRH4fbqpIXh5jGF EIe/0Nur+PNnS+5UC8pT+0unbwwyd2q0Qp1/sGDVLHPZ65bdm+G0tkZnOq8ibisrhnZa cceFTUC8ksbvQLdMSzIKu9r29+Ti6AhW/8YvFo6KKOhMQEJHlg4/EY5pTjqR9hk6EfzB aKh+samgEZS+ynEwc1fQH54/rOSp/0Tpgo1UxrZZZnDu/JEifgCFvhvRGOEhUtVsRckX uet97ZHWWzqjZnoAcWfGSuGi6Zmhg9BWzBlDPSn4JRckruNG0TuwUIESczAYzq2MegdR Cz/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=DD9FGOxQACkAQcGRJt+qd4WJy0wpwTmqGsoEmb+vaZA=; b=hZdzmobTBF5vPL650sxyvKQiCUvDnHxL44FOscr4YQayF0EnEAMAGe8NiadIlrnFl2 YjUOSelyTBz0HFRBNtMCog2G8BYmGXKa9qrbQILgXKAmH3fG74WJRlt77j84qbkeK0zR SZRvIAIegiICuijfV5POCASt82swEGqIDwAydkN1k8WnjwDsRfbHyL5H2nf8piwhzAiA vzU62+AaR+72GuYJajWHyXp20ic7n0klqbIop4bq3GyUM9T7PM2vkaT/zwRUewk0b9TK 3M7KU4zOjcATox77Nfj5Al4CTwpKulDYFap/hSkSSSv5DfPQDUhhKXqvh5QK2K2yyH4X vliQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b="M4K/JKjk"; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o24-20020a63fb18000000b0043891d59cb7si1625368pgh.833.2022.09.29.20.21.16; Thu, 29 Sep 2022 20:21:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b="M4K/JKjk"; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229719AbiI3DUB (ORCPT + 99 others); Thu, 29 Sep 2022 23:20:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230060AbiI3DT6 (ORCPT ); Thu, 29 Sep 2022 23:19:58 -0400 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 965FD2253C for ; Thu, 29 Sep 2022 20:19:54 -0700 (PDT) Received: from cwcc.thunk.org (pool-173-48-120-46.bstnma.fios.verizon.net [173.48.120.46]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 28U3Jlir002409 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 29 Sep 2022 23:19:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1664507989; bh=DD9FGOxQACkAQcGRJt+qd4WJy0wpwTmqGsoEmb+vaZA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=M4K/JKjk5fhKlJ6iKmKT5iaovR3IBqDTv+N+zOKRzpY6l1UYYxPYCn9a1zUzFaakp DvOPIteYPsGjLjNbTa9GwceWJY/z3YBclk1tqomRoSZyKJTsQRahhk4xxfVecLh2kG 4KMZswbdGcYHsscm6jjaB++ZG+vzpE30aEuYz2qj07gwtFUh3VZLarr/X6ccdj3atW x2feiFN0BsojfYx6gMc37srdD2hyPI0vgIUmWfVhguTHeIoMdBq45sGy/K4O5Pvkeh 6goWzwgogTR/dkOFyvqd3PHBfEUeI+avlenOrz2O85pqfcAZozjNW1n4xbKL4nNxmq hOXEpjMFAk9cA== Received: by cwcc.thunk.org (Postfix, from userid 15806) id 88CFF15C33A3; Thu, 29 Sep 2022 23:19:47 -0400 (EDT) From: "Theodore Ts'o" To: linux-ext4@vger.kernel.org, adilger@dilger.ca, artem.blagodarenko@gmail.com, alexey.lyashkov@gmail.com Cc: "Theodore Ts'o" , anserper@ya.ru, ritesh.list@gmail.com Subject: Re: [PATCH] jbd2: wake up journal waiters in FIFO order, not LIFO Date: Thu, 29 Sep 2022 23:19:31 -0400 Message-Id: <166450797716.256913.3257351603456798728.b4-ty@mit.edu> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20220912180137.2308900-1-alexey.lyashkov@gmail.com> References: <20220912180137.2308900-1-alexey.lyashkov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, 12 Sep 2022 21:01:37 +0300, Alexey Lyashkov wrote: > From: Andrew Perepechko > > LIFO wakeup order is unfair and sometimes leads to a journal > user not being able to get a journal handle for hundreds of > transactions in a row. > > FIFO wakeup can make things more fair. > > [...] Applied, thanks! [1/1] jbd2: wake up journal waiters in FIFO order, not LIFO commit: 2bf6739025dcfca3a24fbc73b8f2dbd979c0e4c9 Best regards, -- Theodore Ts'o