Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2c8f3b3a-b6d1-9b8b-27c7-2df51236fe8c@huawei.com>
Date:   Mon, 10 Oct 2022 16:56:58 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
To:     Theodore Ts'o <tytso@mit.edu>
CC:     <linux-ext4@vger.kernel.org>, Lukas Czerner <lczerner@redhat.com>,
        <liuzhiqiang26@huawei.com>, linfeilong <linfeilong@huawei.com>
From:   zhanchengbin <zhanchengbin1@huawei.com>
Subject: [PATCH v2] misc/fsck.c: Processes may kill other processes.
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

I find a error in misc/fsck.c, if run the fsck -N command, processes
don't execute, just show what would be done. However, the pid whose
value is -1 is added to the instance_list list in the execute
function,if the kill_all function is called later, kill(-1, signum)
is executed, Signals are sent to all processes except the number one
process and itself. Other processes will be killed if they use the
default signal processing function.

Signed-off-by: zhanchengbin <zhanchengbin1@huawei.com>
Signed-off-by: Lukas Czerner <lczerner@redhat.com>
---
V1->V2:
   Anything <= 0 is a bug and can have unexpected consequences if
we actually call the kill(). So change inst->pid==-1 to inst->pid<=0.

  misc/fsck.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/misc/fsck.c b/misc/fsck.c
index 4efe10ec..c56d1b00 100644
--- a/misc/fsck.c
+++ b/misc/fsck.c
@@ -546,6 +546,8 @@ static int kill_all(int signum)
  	for (inst = instance_list; inst; inst = inst->next) {
  		if (inst->flags & FLAG_DONE)
  			continue;
+		if (inst->pid <= 0)
+			continue;
  		kill(inst->pid, signum);
  		n++;
  	}
-- 
2.27.0