Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 10 Oct 2022 15:04:55 +0200
From:   Lukas Czerner <lczerner@redhat.com>
To:     zhanchengbin <zhanchengbin1@huawei.com>
Cc:     Theodore Ts'o <tytso@mit.edu>, linux-ext4@vger.kernel.org,
        liuzhiqiang26@huawei.com, linfeilong <linfeilong@huawei.com>
Subject: Re: [PATCH v2] misc/fsck.c: Processes may kill other processes.
Message-ID: <20221010130455.2e5th5sboluwn457@fedora>
References: <2c8f3b3a-b6d1-9b8b-27c7-2df51236fe8c@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2c8f3b3a-b6d1-9b8b-27c7-2df51236fe8c@huawei.com>
Precedence: bulk

On Mon, Oct 10, 2022 at 04:56:58PM +0800, zhanchengbin wrote:
> I find a error in misc/fsck.c, if run the fsck -N command, processes
> don't execute, just show what would be done. However, the pid whose
> value is -1 is added to the instance_list list in the execute
> function,if the kill_all function is called later, kill(-1, signum)
> is executed, Signals are sent to all processes except the number one
> process and itself. Other processes will be killed if they use the
> default signal processing function.

Looks good thanks.

> 
> Signed-off-by: zhanchengbin <zhanchengbin1@huawei.com>
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
                  ^^^
You can remove my Sob, but you can add

Reviewed-by: Lukas Czerner <lczerner@redhat.com>

Thanks!
-Lukas

> ---
> V1->V2:
>   Anything <= 0 is a bug and can have unexpected consequences if
> we actually call the kill(). So change inst->pid==-1 to inst->pid<=0.
> 
>  misc/fsck.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/misc/fsck.c b/misc/fsck.c
> index 4efe10ec..c56d1b00 100644
> --- a/misc/fsck.c
> +++ b/misc/fsck.c
> @@ -546,6 +546,8 @@ static int kill_all(int signum)
>  	for (inst = instance_list; inst; inst = inst->next) {
>  		if (inst->flags & FLAG_DONE)
>  			continue;
> +		if (inst->pid <= 0)
> +			continue;
>  		kill(inst->pid, signum);
>  		n++;
>  	}
> -- 
> 2.27.0
>