Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9ac447b9-0cb5-2b03-12b5-9c3f1cc7e5fe@linux.alibaba.com>
Date:   Tue, 11 Oct 2022 19:23:30 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.11.0
Subject: Re: [PATCH -next] jbd2: use the correct print format
To:     Jason Yan <yanaijie@huawei.com>, rostedt@goodmis.org,
        mhiramat@kernel.org, bvanassche@acm.org, axboe@kernel.dk,
        tytso@mit.edu, linux-kernel@vger.kernel.org,
        linux-ext4@vger.kernel.org
References: <1665389343-35572-1-git-send-email-cuibixuan@linux.alibaba.com>
 <c30377f7-f9b8-5774-b509-a4285210b40f@huawei.com>
From:   Bixuan Cui <cuibixuan@linux.alibaba.com>
In-Reply-To: <c30377f7-f9b8-5774-b509-a4285210b40f@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


在 2022/10/10 22:35, Jason Yan 写道:
> While you are at it, can you make all the tid tracing consistent. Some 
> tracing points using unsigned long such as:
>
> TRACE_EVENT(jbd2_handle_extend,
>     TP_PROTO(dev_t dev, unsigned long tid, unsigned int type,
>          unsigned int line_no, int buffer_credits,
>          int requested_blocks),
>
>     TP_ARGS(dev, tid, type, line_no, buffer_credits, requested_blocks),
>
>
> and the caller passing transaction->t_tid which is tid_t(unsigned int).
>
>     trace_jbd2_handle_extend(journal->j_fs_dev->bd_dev,
>                  transaction->t_tid,
>                  handle->h_type, handle->h_line_no,
>                  handle->h_total_credits,
>                  nblocks); 

Ok, I'll send another patch to fix this problem.


Thanks

Bixuan Cui