Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 20 Oct 2022 13:08:12 -0400
From:   "Theodore Ts'o" <tytso@mit.edu>
To:     Li Jinlin <lijinlin3@huawei.com>
Cc:     adilger@whamcloud.com, linux-ext4@vger.kernel.org,
        linfeilong@huawei.com, liuzhiqiang26@huawei.com
Subject: Re: [PATCH] tune2fs: exit directly when fs freed in
 ext2fs_run_ext3_journal
Message-ID: <Y1GAfCVhruEJ+5IL@mit.edu>
References: <20220916074223.8885-1-lijinlin3@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220916074223.8885-1-lijinlin3@huawei.com>
Precedence: bulk

On Fri, Sep 16, 2022 at 03:42:23PM +0800, Li Jinlin wrote:
> In ext2fs_run_ext3_journal(), fs will be free and reallocate. But
> reallocating by ext2fs_open() may fail in some cases, such as device
> being offline at the same time. In these cases, goto closefs will
> cause segfault, fix it by exiting directly.
> 
> Signed-off-by: Li Jinlin <lijinlin3@huawei.com>

Thanks, applied, although I simplified the patch a little:

@@ -3106,6 +3106,8 @@ _("Warning: The journal is dirty. You may wish to replay the journal like:\n\n"
                        com_err("tune2fs", retval,
                                "while recovering journal.\n");
                        printf(_("Please run e2fsck -fy %s.\n"), argv[1]);
+                       if (!fs)
+                               exit(1);
                        rc = 1;
                        goto closefs;
                }

					- Ted