Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp736491rwi; Wed, 26 Oct 2022 06:41:46 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4j9hzyaef0MgIJ9bR6GruYVyx7jQ6DJKBvYGHtT6ziJmXTTLpWyMvq1F4toxH9BtPd5vTo X-Received: by 2002:a17:902:f54f:b0:186:c3af:b558 with SMTP id h15-20020a170902f54f00b00186c3afb558mr7976151plf.143.1666791706088; Wed, 26 Oct 2022 06:41:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666791706; cv=none; d=google.com; s=arc-20160816; b=Rj7gv5iphQ6L0WXjZfX2vVVz9C7BTwpOypN9RjNwMxWnC+c5Jx1PvH92GLJr//QDBt eFXIUFU1FV7HoACISfPGEGGSlGIogOvm3HO3e9Q3zGRyOLmzFTR1dJ9YCAel9JEPPzF9 YbGlqA0IYKRRg8sy/jUeiFBwTnVsFK1N71M9TgCwwghwuURKZ4GwbQrzgZP9VZn9k01+ evA5QSnc+0x7H3HeCYcDh0Hz/5DO61pJTDhBtlL5EBNUod9FsqTXTOJY/SjNczQOwc0A MRVdmHOMcTjhrCsTekel6DniH4/3Sltxk+ONw/6s/8WM0RzzOxEHMJKqkr+L60yG50qn g+zQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :to:subject; bh=kkYTcT0QjWHnzszF0a8UvSpwyC4O7QUDnPM9MkY6zS4=; b=vHJEWSUFPlB7/yreRbhJkM8F0Rog3VDtzAWi7sD3dsIhkzcD0PEm6LrRVH5q+4XL/7 weSZMh0FG/R9p8JVkk+nETS+/HYOicVM2GSzMM0usLTFwpQMxRYtms6dq3OABNi1Eg06 uAT2/O12uut4M0mDSFnclu5kCnt9fLzfuSdFfx2arnn5mIU/8BHx5xUGTaAYCnTjQw3U o8RH8k2B5clVIvM1rtfn1RCI7NWbggE4OoAVeQFHz8IU+qMa5Jx8pSNkM9looljRWNao FN19/yHg5tdDAHWLJpr93kG0/XndjpC5NEVTs2J25r9hmK3US+37Z4MNPdW2CvjpJzQ6 e6kA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o14-20020a17090ab88e00b001fe27fb63d5si2822259pjr.40.2022.10.26.06.41.23; Wed, 26 Oct 2022 06:41:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232848AbiJZNgX (ORCPT + 99 others); Wed, 26 Oct 2022 09:36:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229949AbiJZNgV (ORCPT ); Wed, 26 Oct 2022 09:36:21 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3AB35604BC; Wed, 26 Oct 2022 06:36:18 -0700 (PDT) Received: from canpemm500004.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4My8w31Cm1zHvCp; Wed, 26 Oct 2022 21:36:03 +0800 (CST) Received: from [10.174.179.14] (10.174.179.14) by canpemm500004.china.huawei.com (7.192.104.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 26 Oct 2022 21:36:15 +0800 Subject: Re: [PATCH -next v2] jbd2: use the correct print format To: Bixuan Cui , , , , , , , References: <1665488024-95172-1-git-send-email-cuibixuan@linux.alibaba.com> From: Jason Yan Message-ID: <60a7370a-0b7f-1f56-0fa4-08a96138b1cd@huawei.com> Date: Wed, 26 Oct 2022 21:36:15 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <1665488024-95172-1-git-send-email-cuibixuan@linux.alibaba.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.14] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To canpemm500004.china.huawei.com (7.192.104.92) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On 2022/10/11 19:33, Bixuan Cui wrote: > The print format error was found when using ftrace event: > <...>-1406 [000] .... 23599442.895823: jbd2_end_commit: dev 252,8 transaction -1866216965 sync 0 head -1866217368 > <...>-1406 [000] .... 23599442.896299: jbd2_start_commit: dev 252,8 transaction -1866216964 sync 0 > > Use the correct print format for transaction, head and tid. > > Fixes: 879c5e6b7cb4 ('jbd2: convert instrumentation from markers to tracepoints') > Signed-off-by: Bixuan Cui > --- > v1->v2: Make all the tid tracing consistent. > > include/trace/events/jbd2.h | 44 ++++++++++++++++++++++---------------------- > 1 file changed, 22 insertions(+), 22 deletions(-) Reviewed-by: Jason Yan