Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 26 Oct 2022 21:46:04 +0800
From:   Zorro Lang <zlang@redhat.com>
To:     Eric Whitney <enwlinux@gmail.com>
Cc:     Dave Chinner <david@fromorbit.com>, fstests@vger.kernel.org,
        linux-ext4@vger.kernel.org, tytso@mit.edu
Subject: Re: [PATCH] generic/455: add $FSX_AVOID
Message-ID: <20221026134604.ks5pview6j6ly4t4@zlang-mailbox>
References: <20221021211950.510006-1-enwlinux@gmail.com>
 <20221026030827.GT2703033@dread.disaster.area>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221026030827.GT2703033@dread.disaster.area>
Precedence: bulk

On Wed, Oct 26, 2022 at 02:08:27PM +1100, Dave Chinner wrote:
> On Fri, Oct 21, 2022 at 05:19:50PM -0400, Eric Whitney wrote:
> > generic/455 fails when run on an ext4 bigalloc file system.  Its
> > fsx invocations can make insert range and collapse range calls whose
> > arguments are not cluster aligned, and ext4 will fail those calls for
> > bigalloc.  They can be suppressed by adding the FSX_AVOID environment
> > variable to the fsx invocation and setting its value appropriately in
> > the test environment, as is done for other fsx-based tests.  This
> > avoids the need to exclude the test to avoid failures and makes it
> > possible to take advantage of the remainder of its coverage.
> > 
> > Signed-off-by: Eric Whitney <enwlinux@gmail.com>
> > ---
> >  tests/generic/455 | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tests/generic/455 b/tests/generic/455
> > index 649b5410..c13d872c 100755
> > --- a/tests/generic/455
> > +++ b/tests/generic/455
> > @@ -77,7 +77,7 @@ FSX_OPTS="-N $NUM_OPS -d -P $SANITY_DIR -i $LOGWRITES_DMDEV"
> >  seeds=(0 0 0 0)
> >  # Run fsx for a while
> >  for j in `seq 0 $((NUM_FILES-1))`; do
> > -	run_check $here/ltp/fsx $FSX_OPTS -S ${seeds[$j]} -j $j $SCRATCH_MNT/testfile$j &
> > +	run_check $here/ltp/fsx $FSX_OPTS $FSX_AVOID -S ${seeds[$j]} -j $j $SCRATCH_MNT/testfile$j &
> 
> generic/457 needs this fix as well.

Yes,
$ grep -rsn here/ltp/fsx tests/|grep -Ev "FSX_AVOID|replay-ops"
tests/generic/457:86:   run_check $here/ltp/fsx $FSX_OPTS -S 0 -j $j $SCRATCH_MNT/testfile$j &
tests/generic/455:80:   run_check $here/ltp/fsx $FSX_OPTS -S ${seeds[$j]} -j $j $SCRATCH_MNT/testfile$j &

Hi Eric,

May you resend this patch? And you can keep Darrick's RVB in V2.

Thanks,
Zorro

> 
> -Dave.
> -- 
> Dave Chinner
> david@fromorbit.com
>