Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Jeff Layton <jlayton@kernel.org>
CC:     Theodore Ts'o <tytso@mit.edu>,
        "adilger.kernel@dilger.ca" <adilger.kernel@dilger.ca>,
        "Darrick J. Wong" <djwong@kernel.org>,
        "david@fromorbit.com" <david@fromorbit.com>,
        "trondmy@hammerspace.com" <trondmy@hammerspace.com>,
        Neil Brown <neilb@suse.de>, Al Viro <viro@zeniv.linux.org.uk>,
        "zohar@linux.ibm.com" <zohar@linux.ibm.com>,
        "xiubli@redhat.com" <xiubli@redhat.com>,
        "lczerner@redhat.com" <lczerner@redhat.com>,
        "jack@suse.cz" <jack@suse.cz>, Bruce Fields <bfields@fieldses.org>,
        "brauner@kernel.org" <brauner@kernel.org>,
        "fweimer@redhat.com" <fweimer@redhat.com>,
        "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>,
        "linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        "linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH v7 8/9] nfsd: remove fetch_iversion export operation
Thread-Topic: [PATCH v7 8/9] nfsd: remove fetch_iversion export operation
Thread-Index: AQHY4hdEz9E5Fj2hi0iz4xQvGekkH64tcemA
Date:   Thu, 3 Nov 2022 15:43:42 +0000
Message-ID: <4D563C45-38A2-4755-BF06-7A30E0331541@oracle.com>
References: <20221017105709.10830-1-jlayton@kernel.org>
 <20221017105709.10830-9-jlayton@kernel.org>
In-Reply-To: <20221017105709.10830-9-jlayton@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?IIcHp4I3qeq0zP1dUlGaHf4CXd8dfuYGM9u7lYyid/sRsDjsLvayckYyPTjg?=
 =?us-ascii?Q?JcjuLfrKNqP41h+RAOs99q86dTkTlvnDqd9KFPwuyL/AdftmMw6a6qprfj8/?=
 =?us-ascii?Q?8mvFZ6NdubpgmHcJT/FU9/eWc5meZF9cKPvzAsLR8J5ujEJmXKft+80UVOso?=
 =?us-ascii?Q?SSLxbPe/MyF/64X3jA9jcfziuHL+IzhJ07CS4taVd4kN0uK+3CehloFe2ktI?=
 =?us-ascii?Q?Sk+GE6PJtPqTFBDAM4iPQiTPRgQBEZ/Mytw5RLeuGVqYcQcrc1UahT1wlTCX?=
 =?us-ascii?Q?KJhzaM/3Wc6RqqvjKcVbSN0pOLmA16MBoVzgG335to4OQJtasNEV3RJwgS2x?=
 =?us-ascii?Q?w7/S+41zJbMCkE2brmyq8cIchGuUQWPuF9ifyjzGSZoNK9IGOzszgoZt7ppq?=
 =?us-ascii?Q?R9WDu4ws+0R19XsbHwLJ1/MHoT3GH7gTa1gT1eb1sTbFrDXqdIO/90/AQVjK?=
 =?us-ascii?Q?Bm2q7JVUhNU5zZ3j+AWej9DKABV7FpIeL1UdWADZQ/ZkuUKQfqjZlflUwAnI?=
 =?us-ascii?Q?0Rj7/odpTPxDO6lkcHnr7b5XFRg3MGwkgtu+OWlSf+Z4iT8PKIrTtnhYAjra?=
 =?us-ascii?Q?nNV8rzQbU/WHfubkxfhnT3Fq8hplVIWLTo0D3KaGBuyef4HZOza3iH1DkNiM?=
 =?us-ascii?Q?f/f3TDAQYAwboMA7RrLxfJ1QxdmtICZ4Hqjmg1CGm0DfqBBXXluarWAWSE40?=
 =?us-ascii?Q?g//kEUFQlfWzTwhQnxxjgqnx6Bv03Sp28E0bcpjgKXDXu/M6azwKZw0KOlHx?=
 =?us-ascii?Q?QyiVnt1Kw9szM0c1Y9TBEIDGVwvUv87kPJ+dKrOemFJ+2SwRhojOeS6iFxEg?=
 =?us-ascii?Q?hyd+rHmOcQCVCpTmRsC5Nsvwdha90AvvDPvGuJtkaSlsPVXxeXaOD9XU4jCk?=
 =?us-ascii?Q?7HigPElW5SlZW1LqYHw74CAJ3XEIlxzMc84mw8m84uBxCvEmCRgr/UlXk3KV?=
 =?us-ascii?Q?gmBR0aDqkg4m/MVSJ/nfkFx9J4/L1cqm4PjD83IyGFZHeQ1fKRUaRE9/7M43?=
 =?us-ascii?Q?WFRySjoBIqhhnonPnKO1RzingExIawAzvi7t90oy0d2pKv5v+CU/qnlobjw/?=
 =?us-ascii?Q?Rsrkk1GnYnS4HCfTIT3cH5OzoIAOSLd/cwJdYk41ePRTeK/cEVeNDATkfjA1?=
 =?us-ascii?Q?q6y7PMdXRHuNKqOwa/qhqILRTyVpD0/XRYFdbWi2xvSH724iIKsHZLwnjsO0?=
 =?us-ascii?Q?mYR5mnzSlPJJCIeS5L0uCaTy3xkl12z/ct5X9PJu9VtCs7u/O1D7uYnVgE0t?=
 =?us-ascii?Q?wDJjQ2Vxv8hYojC+X7sERcrsVjXcXq++Js5qt8DCYV5E0Q0Y6W4ySETzpccF?=
 =?us-ascii?Q?tAVXKyeJY7fl4EZuGHpQy76C8sLx0DBHkG4Kt+B2UwSkCxXDSWY9MPEupoF2?=
 =?us-ascii?Q?bCEg/TacSpGj3OLR9kQGb3VcfC8n4F5AJkOFpWwoE6pMLdFfdlTO5sU7LxfU?=
 =?us-ascii?Q?w0uP39uDnzFJQAN2P0ymyPLGVf7RTGX6kD0nFeJzP2sWRej8ufxXm2+AZNOo?=
 =?us-ascii?Q?6qPCtiQWxB8oLtvjk6YGmDE4DRbhO9z3E39lWKlx2t8rfqgSIukM+W1WsRaH?=
 =?us-ascii?Q?XKAxto4MiJAQYMjgXtM4Sv4e3rDZmZKnWIb8JcXAn7OtXd2obl88WZpANiCD?=
 =?us-ascii?Q?gA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <FDC10AF60243CE4BAA0502B32F834E51@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1985b75a-ae49-4eda-9c89-08dabdb22f6d
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Nov 2022 15:43:42.3262
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 1/q0D4NI7YMu8iH7G47TNCagTv/9DVyyDMR+lvnBgeqKGwojhFBVpNvPzCpUDARjwKBtSxbaDtwAVaOsRyPFKA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB5700
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-03_04,2022-11-03_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 suspectscore=0
 mlxlogscore=999 mlxscore=0 adultscore=0 phishscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000
 definitions=main-2211030104
X-Proofpoint-GUID: Pyr4_bRFeNYsY5qXCIKjfglc1h8rXG0I
X-Proofpoint-ORIG-GUID: Pyr4_bRFeNYsY5qXCIKjfglc1h8rXG0I
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-ext4.vger.kernel.org>
X-Mailing-List: linux-ext4@vger.kernel.org


> On Oct 17, 2022, at 6:57 AM, Jeff Layton <jlayton@kernel.org> wrote:
>=20
> Now that the i_version counter is reported in struct kstat, there is no
> need for this export operation.
>=20
> Reviewed-by: NeilBrown <neilb@suse.de>
> Signed-off-by: Jeff Layton <jlayton@kernel.org>

Acked-by: Chuck Lever <chuck.lever@oracle.com>


> ---
> fs/nfs/export.c          | 7 -------
> fs/nfsd/nfsfh.c          | 2 --
> include/linux/exportfs.h | 1 -
> 3 files changed, 10 deletions(-)
>=20
> diff --git a/fs/nfs/export.c b/fs/nfs/export.c
> index 01596f2d0a1e..1a9d5aa51dfb 100644
> --- a/fs/nfs/export.c
> +++ b/fs/nfs/export.c
> @@ -145,17 +145,10 @@ nfs_get_parent(struct dentry *dentry)
> 	return parent;
> }
>=20
> -static u64 nfs_fetch_iversion(struct inode *inode)
> -{
> -	nfs_revalidate_inode(inode, NFS_INO_INVALID_CHANGE);
> -	return inode_peek_iversion_raw(inode);
> -}
> -
> const struct export_operations nfs_export_ops =3D {
> 	.encode_fh =3D nfs_encode_fh,
> 	.fh_to_dentry =3D nfs_fh_to_dentry,
> 	.get_parent =3D nfs_get_parent,
> -	.fetch_iversion =3D nfs_fetch_iversion,
> 	.flags =3D EXPORT_OP_NOWCC|EXPORT_OP_NOSUBTREECHK|
> 		EXPORT_OP_CLOSE_BEFORE_UNLINK|EXPORT_OP_REMOTE_FS|
> 		EXPORT_OP_NOATOMIC_ATTR,
> diff --git a/fs/nfsd/nfsfh.c b/fs/nfsd/nfsfh.c
> index 21b64ac97a06..9c1f697ffc72 100644
> --- a/fs/nfsd/nfsfh.c
> +++ b/fs/nfsd/nfsfh.c
> @@ -777,8 +777,6 @@ u64 nfsd4_change_attribute(struct kstat *stat, struct=
 inode *inode)
> {
> 	u64 chattr;
>=20
> -	if (inode->i_sb->s_export_op->fetch_iversion)
> -		return inode->i_sb->s_export_op->fetch_iversion(inode);
> 	if (stat->result_mask & STATX_VERSION) {
> 		chattr =3D stat->version;
>=20
> diff --git a/include/linux/exportfs.h b/include/linux/exportfs.h
> index fe848901fcc3..9f4d4bcbf251 100644
> --- a/include/linux/exportfs.h
> +++ b/include/linux/exportfs.h
> @@ -213,7 +213,6 @@ struct export_operations {
> 			  bool write, u32 *device_generation);
> 	int (*commit_blocks)(struct inode *inode, struct iomap *iomaps,
> 			     int nr_iomaps, struct iattr *iattr);
> -	u64 (*fetch_iversion)(struct inode *);
> #define	EXPORT_OP_NOWCC			(0x1) /* don't collect v3 wcc data */
> #define	EXPORT_OP_NOSUBTREECHK		(0x2) /* no subtree checking */
> #define	EXPORT_OP_CLOSE_BEFORE_UNLINK	(0x4) /* close files before unlink =
*/
> --=20
> 2.37.3
>=20

--
Chuck Lever