Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1666504rwb; Mon, 7 Nov 2022 04:31:23 -0800 (PST) X-Google-Smtp-Source: AMsMyM538i8sHEh90HXtyMXAzPrG4sidX637KfLS7ukGx5QrlCujueCBN0JHFRmuCKRvyIA/Js0c X-Received: by 2002:a17:902:aa42:b0:17e:b779:dadb with SMTP id c2-20020a170902aa4200b0017eb779dadbmr51216384plr.11.1667824282950; Mon, 07 Nov 2022 04:31:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667824282; cv=none; d=google.com; s=arc-20160816; b=CvTj25YAxTU5YBjMj3SVu12lNF1MnNk4YLAaFT2R/5PbX5TA3wTDgq5qO/HJ9a7P7A jOPsgh0S+UbxscvWZIt6x6/VXf+AWNsCgAY1t6yQRhczywlHRizkn82ViBQK5aJPb0pX lfMB9l4nRClQGvkDbN/8PL+VXzbnp1mqOeOYv+rBOMjSt43PEj6ERvfsewCvqHvfdogQ wJCaEEUYPaMEtbM9ymGkzgIfvhThipMnIOgOS4zRX1z4U+9lo356OdAIbbZ3d79c/JZi moEeIGzX7DNzDqOieu5Pj6QcHV80PMewGlG70lMYw2t57MbDt2z06/xtn4se7iIzT+As kEZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Vm7hA39O7IoRiEPnNzVpo9eYZrFR9MuwdVKpH1WkXyw=; b=0qZ0j779lV9y8oyi9t/mZCtDP3GpLmojSAnJiSXPi3vx549Sp/ox/30dVFkL5ep9cp xa4KLmud4pPG/j5UbIauj5ovXsaFK433WACYQayUxrBM34qsRA3Z597kJ/L/e3r0LXjV r4eSsy4CnRqklZ+9Tn72y9OdmH9mczc8G47vrzzL94RiTQnqktS1+JKtqmR85H3MFtPU Z5+eeAE8i6YFGGUAltsDzV2pfFPymJKUJGDs6ckVTQwCNRvJRlzRcuCGlg+njJY1QvH9 wPPT8AZ3Z97yULo6oLblh3fRF8uxPWZ3/QT1sIOajJc6B7kuJXmo/Mhfj3hPY359JxZS 4WKA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Ulyyhmy6; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cq25-20020a056a00331900b0056c0a9e09f0si8139684pfb.292.2022.11.07.04.31.09; Mon, 07 Nov 2022 04:31:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Ulyyhmy6; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232292AbiKGMau (ORCPT + 99 others); Mon, 7 Nov 2022 07:30:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232208AbiKGM31 (ORCPT ); Mon, 7 Nov 2022 07:29:27 -0500 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B740C1B7B9 for ; Mon, 7 Nov 2022 04:29:25 -0800 (PST) Received: by mail-pf1-x436.google.com with SMTP id q9so10457934pfg.5 for ; Mon, 07 Nov 2022 04:29:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Vm7hA39O7IoRiEPnNzVpo9eYZrFR9MuwdVKpH1WkXyw=; b=Ulyyhmy61IqcJV0xQeuXsHBBbmB5rT0zFmpEj5neoUwo1QrP1JSfZSKScdyVdqX2rO MER6aSikvY8emKy+JgdvgbSVN5G1iiV1lpuByw2mGJT/HhyZ+hB/tu0VmM9qW2tnoBXp FZ/0qiqIvFq7vkALaq7o+NJqmLbPHECzPUun9KrLC0FgB6lYSskm8RmFhfOSqNfx5V25 m0cpWReR3H+ISjSav9aeFXJPsfMc2dSsRw/jVuJ7YERM4HrIMh/GvUveGmzjNJWoOKrM TOKNeUIUZTUHHs+QGBUyTSkvvKti/kWtFRbDrfZrmS0RCSjwxlYuhcaJkvUvBf0Wo/zb Rm8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Vm7hA39O7IoRiEPnNzVpo9eYZrFR9MuwdVKpH1WkXyw=; b=iv21G46GL4ilwM1VrZgvRHwV1bfuq5xw1BEhP5hpsG+zZsugToMTuZ8BY2TSruQZ3d gVHnzsTJAwog+u8ZPC+uyVRFmSsZfq3dc0jLb9n9SAx2/cz4cZkW5KwXYMw5NB6J6Brj EZRuT9ANfAMpqF7+otuH7iYznD1KS/3BUyTcWJkJLetSciZNX4TwcwCk3EQBVWwJRH3m NnQNbIPT5wxAM2iHFL11/eZVRTXdPwHl9RURfE3A4zNf3QnT4XVR8LULq6iKdvj0w9X4 kAxWoAm51rFqBOVebj+Rqup5SSlfeH5sXkuYkXE5+UvovTf3/oKlvLejcjthmvUN0jT2 TSYA== X-Gm-Message-State: ACrzQf1nLCjKXXTcRsGE2IZWI/z61bgO5IBu9WBnnBvPgTEa07wBsADr 32Jr7CoNzdd30Y1oESApdP8= X-Received: by 2002:a63:581d:0:b0:42b:399:f15a with SMTP id m29-20020a63581d000000b0042b0399f15amr43135266pgb.337.1667824165272; Mon, 07 Nov 2022 04:29:25 -0800 (PST) Received: from localhost ([2406:7400:63:f20b:312d:45b2:85c1:c486]) by smtp.gmail.com with ESMTPSA id m2-20020a170902768200b0017f72a430adsm4858722pll.71.2022.11.07.04.29.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Nov 2022 04:29:24 -0800 (PST) From: "Ritesh Harjani (IBM)" To: Theodore Ts'o Cc: linux-ext4@vger.kernel.org, Harshad Shirwadkar , Wang Shilong , Andreas Dilger , Li Xi , "Ritesh Harjani (IBM)" Subject: [RFCv1 69/72] e2fsck: Fix double free of inodes_to_process Date: Mon, 7 Nov 2022 17:51:57 +0530 Message-Id: <0de5025b40eb8f462d2f01321432ac0535345e3d.1667822612.git.ritesh.list@gmail.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Found during code review, this fixes the double free of inodes_to_process in e2fsck_pass1_run. Signed-off-by: Ritesh Harjani (IBM) --- e2fsck/pass1.c | 1 - 1 file changed, 1 deletion(-) diff --git a/e2fsck/pass1.c b/e2fsck/pass1.c index c934b021..4168a45d 100644 --- a/e2fsck/pass1.c +++ b/e2fsck/pass1.c @@ -2436,7 +2436,6 @@ void e2fsck_pass1_run(e2fsck_t ctx) } ctx->flags |= E2F_FLAG_ALLOC_OK; - ext2fs_free_mem(&inodes_to_process); endit: e2fsck_use_inode_shortcuts(ctx, 0); ext2fs_free_mem(&inodes_to_process); -- 2.37.3