Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 9 Nov 2022 16:49:59 +0100
From:   Jan Kara <jack@suse.cz>
To:     JunChao Sun <sunjunchao2870@gmail.com>
Cc:     linux-ext4@vger.kernel.org, tytso@mit.edu,
        adilger.kernel@dilger.ca, jack@suse.cz
Subject: Re: [PATCH] ext4: replace kmem_cache_create with KMEM_CACHE
Message-ID: <20221109154959.r7at3nrsq6ydaypg@quack3>
References: <20221109153822.80250-1-sunjunchao2870@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221109153822.80250-1-sunjunchao2870@gmail.com>
Precedence: bulk

On Wed 09-11-22 07:38:22, JunChao Sun wrote:
> Replace kmem_cache_create with KMEM_CACHE macro that
> guaranteed struct alignment
> 
> Signed-off-by: JunChao Sun <sunjunchao2870@gmail.com>

Yeah, nice cleanups. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza


> ---
>  fs/ext4/extents_status.c | 8 ++------
>  fs/ext4/readpage.c       | 5 ++---
>  2 files changed, 4 insertions(+), 9 deletions(-)
> 
> diff --git a/fs/ext4/extents_status.c b/fs/ext4/extents_status.c
> index cd0a861853e3..97eccc0028a1 100644
> --- a/fs/ext4/extents_status.c
> +++ b/fs/ext4/extents_status.c
> @@ -155,9 +155,7 @@ static void __revise_pending(struct inode *inode, ext4_lblk_t lblk,
>  
>  int __init ext4_init_es(void)
>  {
> -	ext4_es_cachep = kmem_cache_create("ext4_extent_status",
> -					   sizeof(struct extent_status),
> -					   0, (SLAB_RECLAIM_ACCOUNT), NULL);
> +	ext4_es_cachep = KMEM_CACHE(extent_status, SLAB_RECLAIM_ACCOUNT);
>  	if (ext4_es_cachep == NULL)
>  		return -ENOMEM;
>  	return 0;
> @@ -1807,9 +1805,7 @@ static void ext4_print_pending_tree(struct inode *inode)
>  
>  int __init ext4_init_pending(void)
>  {
> -	ext4_pending_cachep = kmem_cache_create("ext4_pending_reservation",
> -					   sizeof(struct pending_reservation),
> -					   0, (SLAB_RECLAIM_ACCOUNT), NULL);
> +	ext4_pending_cachep = KMEM_CACHE(pending_reservation, SLAB_RECLAIM_ACCOUNT);
>  	if (ext4_pending_cachep == NULL)
>  		return -ENOMEM;
>  	return 0;
> diff --git a/fs/ext4/readpage.c b/fs/ext4/readpage.c
> index 3d21eae267fc..773176e7f9f5 100644
> --- a/fs/ext4/readpage.c
> +++ b/fs/ext4/readpage.c
> @@ -410,9 +410,8 @@ int ext4_mpage_readpages(struct inode *inode,
>  
>  int __init ext4_init_post_read_processing(void)
>  {
> -	bio_post_read_ctx_cache =
> -		kmem_cache_create("ext4_bio_post_read_ctx",
> -				  sizeof(struct bio_post_read_ctx), 0, 0, NULL);
> +	bio_post_read_ctx_cache = KMEM_CACHE(bio_post_read_ctx, SLAB_RECLAIM_ACCOUNT);
> +
>  	if (!bio_post_read_ctx_cache)
>  		goto fail;
>  	bio_post_read_ctx_pool =
> -- 
> 2.17.1
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR