Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp2633562rwb; Thu, 17 Nov 2022 13:46:19 -0800 (PST) X-Google-Smtp-Source: AA0mqf7NlKPxylMcvm6SzzAyROwBoz9eRgmnz0DB+PHIidMWmV2kpRHvy8JVPdJ+PiXt2Q8rw7u7 X-Received: by 2002:a63:4b50:0:b0:459:16e5:9dd9 with SMTP id k16-20020a634b50000000b0045916e59dd9mr3800999pgl.362.1668721579701; Thu, 17 Nov 2022 13:46:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668721579; cv=none; d=google.com; s=arc-20160816; b=uuLRkHJbBVqiLhFRI8CdDC4s/OjcoYvLKAArNwixj05ITac54EsWMAMk9+6MoXD4e0 eNssPiB1XpeZX6yVOVb7z39Omp0ekAcpH+u5SjECMycTb1AnXnjnSe9P97u/XiJxu4RN bgUM3h1wGN+8kj8zIcgLqvkwmcenLet3Rg6RsLghdKNuzEnc7QS4+KuzbmkvzfUlb5N2 sGE6vhMmvP6Tr/FG8jLCa7WV0ylxB6GcoDXKxsKqKReYj4XBILrcN2PBdcTwC1NhSoV9 85inqI72FyO0EXCuiHwOAuAEhFlO+1++oedx6S0YRvymZUOBUQQ+L29zAMaLrTFYbMSr SEWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-id:mime-version:subject :cc:to:references:in-reply-to:from:organization:dkim-signature; bh=UuffnjWXo7tMwo00tJbjEU1LHxhg1We6830zDfm1nv8=; b=xxBgeqg2lTvhFGqw2moxvwEhFIq32uT3hvNNsINv0bm2mgCri9bfFVbfUFk+/f9mCr 7hOk0eJc4W4PXVsfI4uqn/248ajrrXaqlgACm7KuQRltQlBIkww/qRBnSKvIHCm2Ei4F lglypJq4D15G9FT2CYpJVmHTxXiP5Jf2D+c50SFbwm6rMSg6D4UDYnBZx3MmGe6Ev6Du TGu61EN0sigCBB7tB7MKi08JEewfItLcdn3/FmZ5IJ6sCHHIRMW52U6chMRn37QgA3qR AfiLO34bkMRty41mc+9xRCAwrGXPjG55687cLFVwOUwwuw33DlL4eIGKgZsnNwzQvLYM UeNA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DIUL0IuD; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k8-20020a170902c40800b00186db024863si2154404plk.612.2022.11.17.13.46.04; Thu, 17 Nov 2022 13:46:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DIUL0IuD; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234986AbiKQVma (ORCPT + 99 others); Thu, 17 Nov 2022 16:42:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234821AbiKQVm2 (ORCPT ); Thu, 17 Nov 2022 16:42:28 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46AEF697C3 for ; Thu, 17 Nov 2022 13:41:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668721288; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UuffnjWXo7tMwo00tJbjEU1LHxhg1We6830zDfm1nv8=; b=DIUL0IuDlNddnIFXkE0QyDMQZhbJUYLtHxAbH4DlKcWchvEoC9XlsLcau340162cgqzPdV Akn1/u4Be40L6nhOVr+TNpwb+wnPU66+ulcambjlNYvB9bC8iiT02IBa0+i3oa+qwlWx/J a+LILUWd9oKUE3oIqjimADHeon76Dhg= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-628-2Ct9ZNWvOY2mRvcbD5Qzyg-1; Thu, 17 Nov 2022 16:41:25 -0500 X-MC-Unique: 2Ct9ZNWvOY2mRvcbD5Qzyg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A8B0329ABA33; Thu, 17 Nov 2022 21:41:24 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.24]) by smtp.corp.redhat.com (Postfix) with ESMTP id 123EF40C6EC3; Thu, 17 Nov 2022 21:41:22 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20221116183900.yzpcymelnnwppoh7@riteshh-domain> References: <20221116183900.yzpcymelnnwppoh7@riteshh-domain> <20221113162902.883850-1-hch@lst.de> To: "Ritesh Harjani (IBM)" Cc: dhowells@redhat.com, Christoph Hellwig , Namjae Jeon , Sungjong Seo , Jan Kara , OGAWA Hirofumi , Mikulas Patocka , Dave Kleikamp , Bob Copeland , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-karma-devel@lists.sourceforge.net, linux-mm@kvack.org Subject: Re: start removing writepage instances MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <4031744.1668721280.1@warthog.procyon.org.uk> Date: Thu, 17 Nov 2022 21:41:20 +0000 Message-ID: <4031745.1668721280@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Also ->writepage() is called with the page already locked, which is a problem if you need to write out a number of surrounding pages with it. David