Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (1.0)
Subject: Re: [RFCv1 03/72] blkmap64_ba: Add common helper for bits size calculation
From:   Andreas Dilger <adilger@dilger.ca>
In-Reply-To: <728edcaf0eb7fca7e347183799b5dca743236db0.1667822611.git.ritesh.list@gmail.com>
Cc:     Theodore Ts'o <tytso@mit.edu>, linux-ext4@vger.kernel.org,
        Harshad Shirwadkar <harshadshirwadkar@gmail.com>,
        Wang Shilong <wshilong@ddn.com>,
        Andreas Dilger <adilger.kernel@dilger.ca>, Li Xi <lixi@ddn.com>
Date:   Fri, 18 Nov 2022 04:40:01 -0600
Message-Id: <83758DE7-4D3D-4AD1-8EC5-5521672072CC@dilger.ca>
References: <728edcaf0eb7fca7e347183799b5dca743236db0.1667822611.git.ritesh.list@gmail.com>
To:     "Ritesh Harjani (IBM)" <ritesh.list@gmail.com>
Precedence: bulk

On Nov 7, 2022, at 06:22, Ritesh Harjani (IBM) <ritesh.list@gmail.com> wrote=
:
>=20
> =EF=BB=BFJust a quick common helper for bits size calculation.
>=20
> Signed-off-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>

Reviewed-by: Andreas Dilger <adilger@dilger.ca>

> ---
> lib/ext2fs/blkmap64_ba.c | 20 +++++++++++++-------
> 1 file changed, 13 insertions(+), 7 deletions(-)
>=20
> diff --git a/lib/ext2fs/blkmap64_ba.c b/lib/ext2fs/blkmap64_ba.c
> index 5d8f1548..4e7007f0 100644
> --- a/lib/ext2fs/blkmap64_ba.c
> +++ b/lib/ext2fs/blkmap64_ba.c
> @@ -40,6 +40,13 @@ struct ext2fs_ba_private_struct {
>=20
> typedef struct ext2fs_ba_private_struct *ext2fs_ba_private;
>=20
> +#define ba_bits_size(start, end) ((((end) - (start)) / 8 + 1))
> +
> +static size_t ba_bitmap_size(ext2fs_generic_bitmap_64 bitmap)
> +{
> +    return (size_t) ba_bits_size(bitmap->start, bitmap->real_end);
> +}
> +
> static errcode_t ba_alloc_private_data (ext2fs_generic_bitmap_64 bitmap)
> {
>   ext2fs_ba_private bp;
> @@ -56,7 +63,7 @@ static errcode_t ba_alloc_private_data (ext2fs_generic_b=
itmap_64 bitmap)
>   if (retval)
>       return retval;
>=20
> -    size =3D (size_t) (((bitmap->real_end - bitmap->start) / 8) + 1);
> +    size =3D ba_bitmap_size(bitmap);
>=20
>   retval =3D ext2fs_get_mem(size, &bp->bitarray);
>   if (retval) {
> @@ -80,7 +87,7 @@ static errcode_t ba_new_bmap(ext2_filsys fs EXT2FS_ATTR(=
(unused)),
>       return retval;
>=20
>   bp =3D (ext2fs_ba_private) bitmap->private;
> -    size =3D (size_t) (((bitmap->real_end - bitmap->start) / 8) + 1);
> +    size =3D ba_bitmap_size(bitmap);
>   memset(bp->bitarray, 0, size);
>=20
>   return 0;
> @@ -115,7 +122,7 @@ static errcode_t ba_copy_bmap(ext2fs_generic_bitmap_64=
 src,
>=20
>   dest_bp =3D (ext2fs_ba_private) dest->private;
>=20
> -    size =3D (size_t) (((src->real_end - src->start) / 8) + 1);
> +    size =3D ba_bitmap_size(src);
>   memcpy (dest_bp->bitarray, src_bp->bitarray, size);
>=20
>   return 0;
> @@ -145,8 +152,8 @@ static errcode_t ba_resize_bmap(ext2fs_generic_bitmap_=
64 bmap,
>       return 0;
>   }
>=20
> -    size =3D ((bmap->real_end - bmap->start) / 8) + 1;
> -    new_size =3D ((new_real_end - bmap->start) / 8) + 1;
> +    size =3D ba_bitmap_size(bmap);
> +    new_size =3D ba_bits_size(new_real_end, bmap->start);
>=20
>   if (size !=3D new_size) {
>       retval =3D ext2fs_resize_mem(size, new_size, &bp->bitarray);
> @@ -306,8 +313,7 @@ static void ba_clear_bmap(ext2fs_generic_bitmap_64 bit=
map)
> {
>   ext2fs_ba_private bp =3D (ext2fs_ba_private) bitmap->private;
>=20
> -    memset(bp->bitarray, 0,
> -           (size_t) (((bitmap->real_end - bitmap->start) / 8) + 1));
> +    memset(bp->bitarray, 0, ba_bitmap_size(bitmap));
> }
>=20
> #ifdef ENABLE_BMAP_STATS
> --=20
> 2.37.3