Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp5945316rwb; Tue, 22 Nov 2022 06:59:58 -0800 (PST) X-Google-Smtp-Source: AA0mqf7HEJDsqynozvu5iAlVprTI6AyuBKGfB5PSPhNVjONoifhcvBM7Qt1LSTFEQqdChx9N/n3I X-Received: by 2002:a17:903:456:b0:186:880c:167e with SMTP id iw22-20020a170903045600b00186880c167emr17486352plb.7.1669129197918; Tue, 22 Nov 2022 06:59:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669129197; cv=none; d=google.com; s=arc-20160816; b=xB7UoLs+GMUtnlLXRxqSisEXbzTmmySybgL/h6wnu83Hl4SgAsxNXYqFmhgrlFsy8V XnzlJtZrihPWr4w9Qhq/NxPP7HMKqe2iqxvSCNai3rBeJB7XYllla354AFW3t3XiBWPS TM6u40guqPphQUsTuPKMnhJmi1ADlSfGHDssa6yNAQqmfPw98dGFnRow6+8ybCFB0Gmz 7BwKYY63fac1mOAIbSKc4gCu8dGXrpcF/aDgLc4okPjLg7wwrAiDNIfJBv2CSz1nC5T9 kQDLRonN7RRc359uI1ovv10RI19WzTxaBkJaBpFFooW3YUR3CgfpMNxRl5Gv+YKgflQW vEvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:reply-to:message-id:subject:cc:to:from:date :dkim-signature:dkim-signature; bh=at6y+TTS2oVXMolCIvQb3yxpVnbineUdxV9fGtNxfj4=; b=FdwvLocUZnydrwK2PD5j2B6NhHFvkqvbQnb6gKBjLZEwQxhkpZp2GGAZMnBRDJJCH0 cCJJYI0ruegVolVLgxAKlTvQ+u2qkRgkS2mPrdUaKr3SbnRh48xHJiljLHcGpZASV2az Mu3mjLAJcy/DE878YfN0ymmrmE+ZCL9ZR6Ow+UUrRGtH4L84f2NWm0wD3Hap9pqDAMnk wyduBJynv00TlQ+91HwL5dJXtQzZuhFmkKMmaugAOmckYKeNjl5/Y9eytUDVmhNCen9L U2i5NNX6aH0Yn55vnVus9EPTKELRb/LiqHQIsvTKV8QJrtBZ0gGM6Gms9ftU62YGS3sZ IrKQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b="zLRw/arW"; dkim=neutral (no key) header.i=@suse.cz; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o17-20020a170902d4d100b00188e9ec511dsi16355466plg.397.2022.11.22.06.59.39; Tue, 22 Nov 2022 06:59:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b="zLRw/arW"; dkim=neutral (no key) header.i=@suse.cz; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233512AbiKVO7O (ORCPT + 99 others); Tue, 22 Nov 2022 09:59:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234177AbiKVO64 (ORCPT ); Tue, 22 Nov 2022 09:58:56 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17BD1C773; Tue, 22 Nov 2022 06:56:47 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C12EA1F85D; Tue, 22 Nov 2022 14:56:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1669129005; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=at6y+TTS2oVXMolCIvQb3yxpVnbineUdxV9fGtNxfj4=; b=zLRw/arWcUItGvQQk81m0Q0MzGiML2vcj/dEs3DO6QaUsXJRNv1MBXNe/VvXZNvQIgwcFW f/8WniJE7hKwXnS1PQpVQXcRK1CXDJmUkifVVi5Z2onjTKVsqJBLjnRjXfeVvAe1cTgFW7 ZVINEJVKUtklvunA/yNYDGjb6pvTnBM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1669129005; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=at6y+TTS2oVXMolCIvQb3yxpVnbineUdxV9fGtNxfj4=; b=gVo3iIsAvA6V6/B4tE3nZfbtatg4VQ9mzj/DiSLbBgjm/M78VvqsipK8uGqyn3zizV4Rm6 EZ+NlKRNIRNhV3AQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 829D113B01; Tue, 22 Nov 2022 14:56:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id WQXfHi3jfGNDBAAAMHmgww (envelope-from ); Tue, 22 Nov 2022 14:56:45 +0000 Date: Tue, 22 Nov 2022 15:56:15 +0100 From: David Sterba To: Alexander Potapenko Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, tytso@mit.edu, adilger.kernel@dilger.ca, jaegeuk@kernel.org, chao@kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Eric Biggers Subject: Re: [PATCH 2/5] fs: affs: initialize fsdata in affs_truncate() Message-ID: <20221122145615.GE5824@twin.jikos.cz> Reply-To: dsterba@suse.cz References: <20221121112134.407362-1-glider@google.com> <20221121112134.407362-2-glider@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221121112134.407362-2-glider@google.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_SOFTFAIL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, Nov 21, 2022 at 12:21:31PM +0100, Alexander Potapenko wrote: > When aops->write_begin() does not initialize fsdata, KMSAN may report > an error passing the latter to aops->write_end(). > > Fix this by unconditionally initializing fsdata. > > Suggested-by: Eric Biggers > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Signed-off-by: Alexander Potapenko With the fixed Fixes: reference, Acked-by: David Sterba