Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 24 Nov 2022 19:09:13 -0800
From:   Eric Biggers <ebiggers@kernel.org>
To:     Chao Yu <chao@kernel.org>
Cc:     Jaegeuk Kim <jaegeuk@kernel.org>, linux-fsdevel@vger.kernel.org,
        linux-ext4@vger.kernel.org, linux-fscrypt@vger.kernel.org,
        Matthew Wilcox <willy@infradead.org>,
        linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH v3] fsverity: stop using PG_error to track error status
Message-ID: <Y4Ax2YqOY8wyhnE8@sol.localdomain>
References: <20221028175807.55495-1-ebiggers@kernel.org>
 <Y2y0cspSZG5dt6c+@sol.localdomain>
 <Y36ccbZq9gsnbmWw@gmail.com>
 <4b0a548a-5b04-24a6-944d-348d15605dd2@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4b0a548a-5b04-24a6-944d-348d15605dd2@kernel.org>
Precedence: bulk

On Fri, Nov 25, 2022 at 11:06:43AM +0800, Chao Yu wrote:
> On 2022/11/24 6:19, Eric Biggers wrote:
> > On Thu, Nov 10, 2022 at 12:21:06AM -0800, Eric Biggers wrote:
> > > On Fri, Oct 28, 2022 at 10:58:07AM -0700, Eric Biggers wrote:
> > > > From: Eric Biggers <ebiggers@google.com>
> > > > 
> > > > As a step towards freeing the PG_error flag for other uses, change ext4
> > > > and f2fs to stop using PG_error to track verity errors.  Instead, if a
> > > > verity error occurs, just mark the whole bio as failed.  The coarser
> > > > granularity isn't really a problem since it isn't any worse than what
> > > > the block layer provides, and errors from a multi-page readahead aren't
> > > > reported to applications unless a single-page read fails too.
> > > > 
> > > > f2fs supports compression, which makes the f2fs changes a bit more
> > > > complicated than desired, but the basic premise still works.
> > > > 
> > > > Signed-off-by: Eric Biggers <ebiggers@google.com>
> > > > ---
> > > > 
> > > > In v3, I made a small simplification to the f2fs changes.  I'm also only
> > > > sending the fsverity patch now, since the fscrypt one is now upstream.
> > > > 
> > > >   fs/ext4/readpage.c |  8 ++----
> > > >   fs/f2fs/compress.c | 64 ++++++++++++++++++++++------------------------
> > > >   fs/f2fs/data.c     | 48 +++++++++++++++++++---------------
> 
> Hi Eric,
> 
> Result of "grep PageError fs/f2fs/* -n"
> 
> ...
> fs/f2fs/gc.c:1364:      ClearPageError(page);
> fs/f2fs/inline.c:177:   ClearPageError(page);
> fs/f2fs/node.c:1649:    ClearPageError(page);
> fs/f2fs/node.c:2078:            if (TestClearPageError(page))
> fs/f2fs/segment.c:3406: ClearPageError(page);
> 
> Any plan to remove above PG_error flag operations? Maybe in a separated patch?
> 

Those are all for writes, not reads.  So I didn't want to touch them in this
patch, which is only about reads.

- Eric