Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp9817455rwb; Thu, 24 Nov 2022 19:42:52 -0800 (PST) X-Google-Smtp-Source: AA0mqf4QRhU56i8Z0FFNizfBFv54JOklsDezJ6jJf7JlU19AF0dRMVv1CLCMF2bbKvjbCx1t1ege X-Received: by 2002:a63:5819:0:b0:476:8ce9:be5d with SMTP id m25-20020a635819000000b004768ce9be5dmr16010919pgb.15.1669347772309; Thu, 24 Nov 2022 19:42:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669347772; cv=none; d=google.com; s=arc-20160816; b=arxnoSF3iJjUUqF4SaA1e2vVxzCpfdFgQuWCX2LgUJ1mw/+zvC+wJ9hTrSePbv6h2P TKGkoCvuk1jzXVkwIcyOvDaNYj2/glj6jxLmdv9SwdSRMam34RUJqFmmyRC+6myDXA9B tNWL79HjdhIoah4vIKrqoxgwq9Ya/JohB7Zz2eKNBqmKeDTTCZmCE1JeMa9saE5XiPim fyh22jNRSmtatbfyvC9AOoGfClm2nQ2uRjftGfaXiPyBJeWadGibN/u+Uf3fmVvDPUkf phBINklgpT/qJQCjSMGTG/VRct+GBoV9xiiFXhdkBDtmrfrqVB0W+W8hvWyEoh46rpj0 3whQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=f0LjV9FzsxIjl8BBgAmsWZF5+ijsH7PMUknKWmygCc8=; b=Jrpg2tTjapTAnQnJpN1SM+lOx15exqh3Cbs555RCIKj1+vuZZ3U1k+ODazHCigVYQ2 d7R4E/KnxlU2cz0VrnmcAiEhYmXa43kgfL707PpSohLY7/WB9q2XqtZ+2ITzSJzOUDdu +HMu/VHeFk8KkgP/d81ma/yHNXBbD2CUMFz/HnrK41HMaV7JRFQtqhsVA8g6vtGJd/lq a1piJoxuaElNZX3JxFBDUleTIKtLNeTsHgp7VVBKtQnSF1iJXqvSyN6w35yQQzijWMUF skMdewYtE6WbC0bHgEgsqEbXVmWdPZs2JQLvRfi6iYU8hjmrdH8eTbkCIWQevHgYrKtq kcwQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YTqZbNiR; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o17-20020a170902d4d100b0017865059c4bsi3068145plg.401.2022.11.24.19.42.33; Thu, 24 Nov 2022 19:42:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YTqZbNiR; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229646AbiKYDgU (ORCPT + 99 others); Thu, 24 Nov 2022 22:36:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229453AbiKYDgU (ORCPT ); Thu, 24 Nov 2022 22:36:20 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 920D92AC57; Thu, 24 Nov 2022 19:36:19 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2D732621E1; Fri, 25 Nov 2022 03:36:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1292CC433C1; Fri, 25 Nov 2022 03:36:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669347378; bh=wKWPk4v8fe90jffTIHyQjUbwPtVaGLxqGFEpI0P7wnE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=YTqZbNiRd4JIWn0K8jzRIqEDGOkfDpOe3H7Mh1qixAiAm+8XzeAOmWoqz4YaQxk+L bN0908UoIcr3RNueemlQyVj6OYnR2g0a++qQzBUNzvlypbC/CQDTwawvHAsZmbZy7o eGz8b8YIftg2Jn7zN0Ia872itxFTG+7H4mx1HT6aCaTaLEemm30HaTGMmUnFhdT5OG iBFvoiplRvGL2GTEe1MJAnzmn5X6IKVEcqgnNy3ionyb8mgAN5ov/Ao3YTHpOU3wyn qY7P6trgGmIJofxRtN0esLJNrvLfLE61VfiycElQf94+/xSeFvFjSObSDwQqk9cQ1A Yy1unQXoyXl5g== Message-ID: <6bce9afb-2561-7937-caea-8aadaa5a21cd@kernel.org> Date: Fri, 25 Nov 2022 11:36:14 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [f2fs-dev] [PATCH v3] fsverity: stop using PG_error to track error status Content-Language: en-US To: Eric Biggers , linux-fscrypt@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, Matthew Wilcox , linux-f2fs-devel@lists.sourceforge.net References: <20221028175807.55495-1-ebiggers@kernel.org> From: Chao Yu In-Reply-To: <20221028175807.55495-1-ebiggers@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On 2022/10/29 1:58, Eric Biggers wrote: > @@ -116,43 +116,51 @@ struct bio_post_read_ctx { > struct f2fs_sb_info *sbi; > struct work_struct work; > unsigned int enabled_steps; > + bool decompression_attempted; How about adding some comments for decompression_attempted? Otherwise it looks good to me. Reviewed-by: Chao Yu Thanks,