Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1410765rwb; Tue, 29 Nov 2022 13:13:38 -0800 (PST) X-Google-Smtp-Source: AA0mqf4nWID5TVEdZFMJpAQt6ZGuLOqMMDhPDIGxUpefwQXdqyCEBffA8Tz8+/Idsydh2HkQoV+a X-Received: by 2002:a17:90b:48c8:b0:20b:16bc:8493 with SMTP id li8-20020a17090b48c800b0020b16bc8493mr62330224pjb.210.1669756418531; Tue, 29 Nov 2022 13:13:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669756418; cv=none; d=google.com; s=arc-20160816; b=UF4MgLRLo2AWHzT72nu6wuk4JksBZoKPLfVLGeH3Lz+cBngo+fha0RZKb+X+HvcZV1 XC2Rrx7nNCCUVlucimRgMlXMOkKFyU9mF8jmlI9rJwN8ephgeO98RONOcnvv9+eKsili LwFjnT3qHBSp/qJAEQpcD6YLIO+S47emS5SNZayKHCvEq4zy1P7E92N6Or86dhHfJ+v4 4vErlQdWbv1J4wev5VuccemFQi9RfA1G9iTow01iP3FUVcqYajM/SfkPleGq+ObtcRBv /vvrC6F6TFxhyhrV5ecVG7JcP24WMrnMfWft4BJT36XT7XdyUxegi5jnpVPebXSQ81Fy quWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=g/EGor8m8Q9DnBuYXTaxaOxW8TyeAAYrJqaM/ODqyTY=; b=ap7otfClG9TkmvZ+UioNl8s8aBTUfQTTN+XAgFyF3Ym3jZpCWZHY26o6MYNCijNG+j zBPOqOJTQi+yDEZN7lAjdMtqnlEuK0BExJ5aTtarxp9Q50aX8WDUjb86MffTsRiz1Go8 Kw/vpJWUPvx+LqhV/HQRY8wZbZrLG0Y/kRiN+r+nrrrmzYB1MqeOh18CFtgXMKjG0QNi RbyoF3yFsoD+Bh/kLW0pVGQCtRutxf8lSO/ytIxlnYH21bPTIF5h/snXWaUnkD/9rTYg BrGcjDLYdkHgNoN5yMES/gq/JtQxTdEvssrxrkSz7qa6abmVHz2P46gCIvwUqUJ8fEZh PZaA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b=WCoh1X8t; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a3-20020a1709027e4300b001842f465c10si13307723pln.438.2022.11.29.13.13.24; Tue, 29 Nov 2022 13:13:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b=WCoh1X8t; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236903AbiK2VMv (ORCPT + 99 others); Tue, 29 Nov 2022 16:12:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237058AbiK2VMe (ORCPT ); Tue, 29 Nov 2022 16:12:34 -0500 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 03EF726C5; Tue, 29 Nov 2022 13:12:23 -0800 (PST) Received: from cwcc.thunk.org (pool-173-48-120-46.bstnma.fios.verizon.net [173.48.120.46]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 2ATLCJqT029740 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 29 Nov 2022 16:12:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1669756341; bh=g/EGor8m8Q9DnBuYXTaxaOxW8TyeAAYrJqaM/ODqyTY=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=WCoh1X8t4yx0iRaLsj5C4qC9uVD7SOjlYuX914LNEwLUfRDdL9yPxTg92FbF0+Vsn JjRXc5tETAy9CMmDzWoGpSrxHWElo9Q3JeiaVyOfNXTBctSqZftgKntsIoLQsOdODB duVjgNl5BiIQZT1c+72jhJKm2PPmjO4qX+MPTUw4RD5//SeZDPxur4h008yykFd717 YVxTrGtEfEBIoIKA+I6JJGhIzd04WAvO5EkJa0D0Kwok+09o9ApGswYjm0ip0Bm8Ni ks7BV3+7qB3yRxPxrqMoReFnl8hZFtiwweGR9+0mFHo3Vkexr7CKaZxGsEKxixVsuy JNfrzJJj2RiFg== Received: by cwcc.thunk.org (Postfix, from userid 15806) id 6622D15C3AAD; Tue, 29 Nov 2022 16:12:19 -0500 (EST) From: "Theodore Ts'o" To: linux-ext4@vger.kernel.org, Li Zhong , linux-kernel@vger.kernel.org Cc: "Theodore Ts'o" , adilger.kernel@dilger.ca Subject: Re: [PATCH v2] fs/ext4/xattr: check the return value of ext4_xattr_inode_dec_ref() Date: Tue, 29 Nov 2022 16:12:11 -0500 Message-Id: <166975630695.2135297.1954942678969463045.b4-ty@mit.edu> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20220917002816.3804400-1-floridsleeves@gmail.com> References: <20220917002816.3804400-1-floridsleeves@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Fri, 16 Sep 2022 17:28:16 -0700, Li Zhong wrote: > Check the return value of ext4_xattr_inode_dec_ref(), which could return > error code and need to be warned. > > Applied, thanks! [1/1] fs/ext4/xattr: check the return value of ext4_xattr_inode_dec_ref() commit: 883a86e4276a9facf1a0fe6950e504f52b841853 Best regards, -- Theodore Ts'o