Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp2512873rwb; Fri, 2 Dec 2022 10:47:13 -0800 (PST) X-Google-Smtp-Source: AA0mqf4Zy60Yu9ptdxzfJDyMbuK0DD78SlqdJswoByEdKsjPHbfDrXdH2fhs/RIGf5clT76LsFjJ X-Received: by 2002:a17:906:99d3:b0:78d:c7fd:f755 with SMTP id s19-20020a17090699d300b0078dc7fdf755mr4681962ejn.702.1670006833763; Fri, 02 Dec 2022 10:47:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670006833; cv=none; d=google.com; s=arc-20160816; b=u9E2ZgMdSAHLiarsm6gbn3zWoaJiQ0JCNUIVMsfHe4PWQBdsbAFfGhDK/YiLlJslP0 FSa01SoNFOiI4Pkc/ZCCyOhauuk1eHKiZakE/tET+VoKbvaKW13+H0FMq3cXfqdCwaIe VTq+HGKbL35BkE2Bw3EWqRBzlNGcNsPrigdqV1KgW8zxGeCmgze4QT5uzg3vWAiNyoed LxV+6XQkWQC5oeg9BVkj3jdpkZ1FxmiLUo9epcajyuUaYqMyZ7tQ59AH2KSG3mT+pd2v gxkZT2aUmsaTtSyELGQjSsnzROp6q/SV2NKHXfuC+6L4+TvC/D2t3h8ruNSGlVVN6bqn 8grw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature:dkim-signature; bh=Jxf9LTF/3YlfiMDoausCmPmiH2lwzWUXTFrC2+NnIHM=; b=kWXt2vzHPc0JDOIvdBfLBzRyEVXfBseSHDGmi5DZIwIBo84LNBaxAn5wp0v5v0vhid 05sKF59ZCL0lzCRvag486Z/WSJFh0G75WggP/jeSu4xa8LbjeAHR0TaFf07Tv8GZiQXO ciudsVwuwC/V3G78jH9Q69m31q7X3uOAAUXS6tBIHWY5slYw4fRlopRlYVuVdEEuavgA 60TnPj+CJOr85v1bngE9ajniPhGnB4CTMoK0SBznfGJMex+gXWveeaVrA1Mm5cnIAbxe mvi2zwZnrqE4j4eElc15gkFbcBwHoJh5wDi3ZnF1homLvI62IiqfqyoRHMYMJNQOUeNq noZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=nxAtAgcs; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id di12-20020a170906730c00b007be079862c8si7271131ejc.965.2022.12.02.10.46.50; Fri, 02 Dec 2022 10:47:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=nxAtAgcs; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234064AbiLBSmI (ORCPT + 99 others); Fri, 2 Dec 2022 13:42:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233612AbiLBSl2 (ORCPT ); Fri, 2 Dec 2022 13:41:28 -0500 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E322ECA2B for ; Fri, 2 Dec 2022 10:39:46 -0800 (PST) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E697121BFE; Fri, 2 Dec 2022 18:39:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1670006383; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Jxf9LTF/3YlfiMDoausCmPmiH2lwzWUXTFrC2+NnIHM=; b=nxAtAgcsRhKzGHpZy/YwIcOOkKw+VIUzRkBkev+mTC6WDJYiBgbYEHCkk4yPiSkOe4ldcc sNZC0Ti/jRrFnOgra3LFUBMRZzFAqSKddCfnPUjOUwzA+C384BUE02379QJVPQFTWY3ywu 2rd3iEcmSh30niYwVAhQpvKJsSD4F20= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1670006383; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Jxf9LTF/3YlfiMDoausCmPmiH2lwzWUXTFrC2+NnIHM=; b=damwn1pET83lr8H+WbvP0dhisCx2bXUeu7zB1IAhcFUUcW7ijBujGNdX5o9GKRL9rSouir tlhVzG8/5JTVUQAw== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id D15A913649; Fri, 2 Dec 2022 18:39:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id ZGJ2Mm9GimOlZAAAGKfGzw (envelope-from ); Fri, 02 Dec 2022 18:39:43 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 49DFFA070B; Fri, 2 Dec 2022 19:39:43 +0100 (CET) From: Jan Kara To: Ted Tso Cc: , Christoph Hellwig , Ritesh Harjani , Jan Kara Subject: [PATCH v2 0/11] ext4: Stop using ext4_writepage() for writeout of ordered data Date: Fri, 2 Dec 2022 19:39:25 +0100 Message-Id: <20221202163815.22928-1-jack@suse.cz> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1235; i=jack@suse.cz; h=from:subject:message-id; bh=qiNRJ+2e7WogrxmIyrdwiJ4WhlmfPG4jNydopJXKGTc=; b=owEBbQGS/pANAwAIAZydqgc/ZEDZAcsmYgBjikZUho/8NjJBFwsU0f2mgWoROdHoVcUnMmLPzzy3 hRtIsu+JATMEAAEIAB0WIQSrWdEr1p4yirVVKBycnaoHP2RA2QUCY4pGVAAKCRCcnaoHP2RA2R9EB/ wP5VQ8gfwxMx8tGRsalZeoR5rBbT70cZSdTsUjGA6OyJNtJwrCL4NDf4ihoEJ71zzeXX/hlojmuqWv FtcriLAu2rFppy7OC0DuXoHYr2riwnALb0n0ALXGJhs4uejbCbKKKHy9R4A+M9bfnHqTmwDQKGy6qG EXkJbAMklDzWX5WR5uz7pS8MmQLdIsj8v5ZEPKerXKo/FZV8uL18+IHCy+yr7tD8NonFXgqfmOfeIv qKbgOkbnDWIiqILgnQGa6FpunY2JqkzI6sf+iNTVNcDjodmQBm81QYJST7brbeGrx+Vjz4bWLEDRVl lXKLuMXvTCvyzCBKiAQ+v3wGWHz12q X-Developer-Key: i=jack@suse.cz; a=openpgp; fpr=93C6099A142276A28BBE35D815BC833443038D8C Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_SOFTFAIL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Hello, this patch series modifies ext4 so that we stop using ext4_writepage() for writeout of ordered data during transaction commit (through generic_writepages() from jbd2_journal_submit_inode_data_buffers()). Instead we directly call ext4_writepages() from the ext4_journal_submit_inode_data_buffers(). This is part of Christoph's effort to get rid of the .writepage() callback in all filesystems. I have also modified ext4_writepages() to use write_cache_pages() instead of generic_writepages() so now we don't expose .writepage hook at all. We still keep ext4_writepage() as a callback for write_cache_pages(). We should refactor that path as well and get rid of ext4_writepage() completely but that is for a separate cleanup. Also note that jbd2 still uses generic_writepages() in its jbd2_journal_submit_inode_data_buffers() helper because it is still used from OCFS2. Again, something to be dealt with in a separate patchset. Changes since v1: * Added Reviewed-by tags from Ritesh * Added patch to get rid of generic_writepages() in ext4_writepages() * Added patch to get rid of .writepage hook Honza Previous versions: Link: http://lore.kernel.org/r/20221130162435.2324-1-jack@suse.cz # v1