Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Dec 2022 13:07:27 +0100
From:   Jan Kara <jack@suse.cz>
To:     Ye Bin <yebin@huaweicloud.com>
Cc:     tytso@mit.edu, adilger.kernel@dilger.ca,
        linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
        jack@suse.cz, Ye Bin <yebin10@huawei.com>
Subject: Re: [PATCH -next 5/6] ext4: rename xattr_find_entry() and
 __xattr_check_inode()
Message-ID: <20221206120727.ak2txwu72zomtwxe@quack3>
References: <20221206015806.3420321-1-yebin@huaweicloud.com>
 <20221206015806.3420321-6-yebin@huaweicloud.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221206015806.3420321-6-yebin@huaweicloud.com>
Precedence: bulk

On Tue 06-12-22 09:58:05, Ye Bin wrote:
> From: Ye Bin <yebin10@huawei.com>
> 
> xattr_find_entry() and __xattr_check_inode() is in EXT4 xattr module. so
> add 'ext4' prefix to unify name style.
> 
> Signed-off-by: Ye Bin <yebin10@huawei.com>

Looks nice. Just one nit below:

> @@ -1862,7 +1862,7 @@ ext4_xattr_block_find(struct inode *inode, struct ext4_xattr_info *i,
>  		bs->s.first = BFIRST(bs->bh);
>  		bs->s.end = bs->bh->b_data + bs->bh->b_size;
>  		bs->s.here = bs->s.first;
> -		error = xattr_find_entry(inode, &bs->s.here, bs->s.end,
> +		error = ext4_xattr_find_entry(inode, &bs->s.here, bs->s.end,
>  					 i->name_index, i->name, 1);
>  		if (error && error != -ENODATA)
>  			return error;
> @@ -2222,11 +2222,11 @@ int ext4_xattr_ibody_find(struct inode *inode, struct ext4_xattr_info *i,
>  	is->s.here = is->s.first;
>  	is->s.end = (void *)raw_inode + EXT4_SB(inode->i_sb)->s_inode_size;
>  	if (ext4_test_inode_state(inode, EXT4_STATE_XATTR)) {
> -		error = xattr_check_inode(inode, header, is->s.end);
> +		error = ext4_xattr_check_inode(inode, header, is->s.end);
>  		if (error)
>  			return error;
>  		/* Find the named attribute. */
> -		error = xattr_find_entry(inode, &is->s.here, is->s.end,
> +		error = ext4_xattr_find_entry(inode, &is->s.here, is->s.end,
>  					 i->name_index, i->name, 0);
>  		if (error && error != -ENODATA)
>  			return error;

The indentation of arguments in the above should be updated as well to look
like:

		error = ext4_xattr_find_entry(inode, &is->s.here, is->s.end,
					      i->name_index, i->name, 0);

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR