Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 7 Dec 2022 14:44:29 +0700
From:   Bagas Sanjaya <bagasdotme@gmail.com>
To:     Ye Bin <yebin@huaweicloud.com>
Cc:     tytso@mit.edu, adilger.kernel@dilger.ca,
        linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
        jack@suse.cz, Ye Bin <yebin10@huawei.com>
Subject: Re: [PATCH v2 6/6] ext4: fix inode leak in
 'ext4_xattr_inode_create()'
Message-ID: <Y5BEXTyXkVh+XZW1@debian.me>
References: <20221207074043.1286731-1-yebin@huaweicloud.com>
 <20221207074043.1286731-7-yebin@huaweicloud.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="3ch33433gQYX2hYg"
Content-Disposition: inline
In-Reply-To: <20221207074043.1286731-7-yebin@huaweicloud.com>
Precedence: bulk


--3ch33433gQYX2hYg
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Dec 07, 2022 at 03:40:43PM +0800, Ye Bin wrote:
> Above issue occur in 'ext4_xattr_inode_create()', if 'ext4_mark_inode_dir=
ty()'
> failed need to drop inode's i_nlink. Or will lead to inode leak.
>=20

What about "This occurs in ... . If ... fails, dropping i_nlink of the
inode is needed, otherwise inode leak can occur."?

--=20
An old man doll... just what I always wanted! - Clara

--3ch33433gQYX2hYg
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCY5BEXQAKCRD2uYlJVVFO
o9S/APwNWBjguUmtCD77SDwA2SlTP2eRYnR7mT11nojNnMH+BQD/R1DMOhfiOy73
HCaHV+bfSnnne6L5P8T7i/fYkP6oHAU=
=V10K
-----END PGP SIGNATURE-----

--3ch33433gQYX2hYg--