Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Andreas Dilger <adilger@dilger.ca>
Message-Id: <37DB544F-6224-4513-AF46-E1DFF06E5E01@dilger.ca>
Content-Type: multipart/signed;
 boundary="Apple-Mail=_B909F056-4FC8-45C8-A831-3836BA4D19AD";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: [RFCv1 19/72] libext2fs: Misc fixes for struct_ext2_filsys
Date:   Wed, 14 Dec 2022 14:22:45 -0700
In-Reply-To: <d9c1ee96a026bfa4652e1c57d7c7dc40bdf049df.1667822611.git.ritesh.list@gmail.com>
Cc:     Theodore Ts'o <tytso@mit.edu>, linux-ext4@vger.kernel.org,
        Harshad Shirwadkar <harshadshirwadkar@gmail.com>,
        Li Xi <lixi@ddn.com>
To:     "Ritesh Harjani (IBM)" <ritesh.list@gmail.com>
References: <cover.1667822611.git.ritesh.list@gmail.com>
 <d9c1ee96a026bfa4652e1c57d7c7dc40bdf049df.1667822611.git.ritesh.list@gmail.com>
Precedence: bulk


--Apple-Mail=_B909F056-4FC8-45C8-A831-3836BA4D19AD
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

On Nov 7, 2022, at 5:21 AM, Ritesh Harjani (IBM) <ritesh.list@gmail.com> =
wrote:
>=20
> From: Andreas Dilger <adilger@whamcloud.com>
>=20
> Move ext2_filsys fs_num_threads to fit into the __u16 "pad" field
> to avoid consuming one of the few remaining __u32 reserved fields.

This should be merged into the previous patch.

> Signed-off-by: Andreas Dilger <adilger@whamcloud.com>
> Signed-off-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
> ---
> lib/ext2fs/ext2fs.h | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>=20
> diff --git a/lib/ext2fs/ext2fs.h b/lib/ext2fs/ext2fs.h
> index 6b4926ce..950ab042 100644
> --- a/lib/ext2fs/ext2fs.h
> +++ b/lib/ext2fs/ext2fs.h
> @@ -278,12 +278,11 @@ struct struct_ext2_filsys {
> 	time_t				now;
> 	int				cluster_ratio_bits;
> 	__u16				default_bitmap_type;
> -	__u16				pad;
> -	__u32				fs_num_threads;
> +	__u16				fs_num_threads;
> 	/*
> 	 * Reserved for future expansion
> 	 */
> -	__u32				reserved[4];
> +	__u32				reserved[5];
>=20
> 	/*
> 	 * Reserved for the use of the calling application.
> --
> 2.37.3
>=20


Cheers, Andreas


--Apple-Mail=_B909F056-4FC8-45C8-A831-3836BA4D19AD
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org

iQIzBAEBCAAdFiEEDb73u6ZejP5ZMprvcqXauRfMH+AFAmOaPqUACgkQcqXauRfM
H+A+vhAAvyqASEu3eiiQzm2Ki4DOo26JuS2zAotNibxDTTploPr+HIxsSs6h/RdO
Wt02IOD1DoIy3j6QsVf2qLEvWBYtrJI/r4VDKS8cOQ8mtQpUbw5BRxmCVRCTRz0l
JTkiCyQe/6FCDRGT/zSZzWRC18N/okODoUOpWpsrNsE/3QqLAizgsk/7HidPue+E
XBlE4SW7XuM+ExqZiFGr1YLS4l1PtJY3xNg+vFVBw2MsFkOE+VLkZ2bXxAtb3esa
pQs0kja5HhprdFpYVXS9WhFrWruHPkNshC5xh/9TdPC71HQdLuy/lQRli0P+ERIU
NuAEs92FVDf9OcAxBHTkCkSb90Wu1YcUaH4SRv8OvcvQjz/Y1z+diI5mR2Yc3oyM
25P8plnsUnL/BB1v9BDivytHD9kWx0qwPOveSZ+vkGmrJD38te5rG2HBCHcoqxgv
W8X8QRBBA6Q96disSDvmVaTO3V8kImGbAgtFlHwPsu079Peq3ZSN4wL4rdJpbrXG
VYHChcfXO4qGI0/6eQqvkoPbj3daQV4AIxAD2yEh82AXR99CzgkkVLvRUJUe56hu
2wpJnAz9WAgUc8uk+vjywAyYEEIrK22CtjSNJYS+zc1wVGOotpGzAGN21JNvNHad
8keamNL6D740eOD8Qk1leAkh7y4b8xxFbg7Tl+T7DetDfiVVZCU=
=Zt10
-----END PGP SIGNATURE-----

--Apple-Mail=_B909F056-4FC8-45C8-A831-3836BA4D19AD--