Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Andreas Dilger <adilger@dilger.ca>
Message-Id: <DEE6E02A-8AEC-400F-814B-7D7A6173BFFE@dilger.ca>
Content-Type: multipart/signed;
 boundary="Apple-Mail=_3E79795F-7D55-4288-BA90-7176671DD6BF";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: [RFCv1 21/72] e2fsck: add -m option for multithread
Date:   Wed, 14 Dec 2022 14:32:14 -0700
In-Reply-To: <935d3652155338e793325acd5f8b900728a56bd9.1667822611.git.ritesh.list@gmail.com>
Cc:     Theodore Ts'o <tytso@mit.edu>, linux-ext4@vger.kernel.org,
        Harshad Shirwadkar <harshadshirwadkar@gmail.com>,
        Wang Shilong <wangshilong1991@gmail.com>, Li Xi <lixi@ddn.com>
To:     "Ritesh Harjani (IBM)" <ritesh.list@gmail.com>
References: <cover.1667822611.git.ritesh.list@gmail.com>
 <935d3652155338e793325acd5f8b900728a56bd9.1667822611.git.ritesh.list@gmail.com>
Precedence: bulk


--Apple-Mail=_3E79795F-7D55-4288-BA90-7176671DD6BF
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

On Nov 7, 2022, at 5:21 AM, Ritesh Harjani (IBM) <ritesh.list@gmail.com> =
wrote:
>=20
> From: Li Xi <lixi@ddn.com>
>=20
> -m option is added but no actual functionality is added. This
> patch only adds the logic that when -m is specified, one of
> -p/-y/-n options should be specified. And when -m is specified,
> -C shouldn't be specified and the completion progress report won't
> be triggered by sending SIGUSR1/SIGUSR2 signals. This simplifies
> the implementation of multi-thread fsck in the future.
>=20
> Completion progress support with multi-thread fsck will be added
> back after multi-thread fsck implementation is finished. Right
> now, disable it to simplify the implementation of multi-thread fsck.
>=20
> Signed-off-by: Li Xi <lixi@ddn.com>
> Signed-off-by: Wang Shilong <wshilong@ddn.com>
> Signed-off-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>

Minor nit below, but looks OK otherwise:

Reviewed-by: Andreas Dilger <adilger@dilger.ca>

> diff --git a/e2fsck/unix.c b/e2fsck/unix.c
> index e5b672a2..1ee27f6a 100644
> --- a/e2fsck/unix.c
> +++ b/e2fsck/unix.c
> @@ -854,7 +855,8 @@ static errcode_t PRS(int argc, char *argv[], =
e2fsck_t *ret_ctx)
>=20
> 	phys_mem_kb =3D get_memory_size() / 1024;
> 	ctx->readahead_kb =3D ~0ULL;
> -	while ((c =3D getopt(argc, argv, =
"panyrcC:B:dE:fvtFVM:b:I:j:P:l:L:N:SsDkz:")) !=3D EOF)
> +
> +	while ((c =3D getopt(argc, argv, =
"pamnyrcC:B:dE:fvtFVM:b:I:j:P:l:L:N:SsDkz:")) !=3D EOF)

I find it easier to find/add options when these are sorted in =
alphabetical order, but
that is not solely the fault of this patch.  At least 'm' is added in =
order relative
to most other lower-case options.

Cheers, Andreas


--Apple-Mail=_3E79795F-7D55-4288-BA90-7176671DD6BF
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org

iQIzBAEBCAAdFiEEDb73u6ZejP5ZMprvcqXauRfMH+AFAmOaQN8ACgkQcqXauRfM
H+Cs0hAAgDAX3PI8QjwxZSXiAAyXMcHpLyH6QdajKzm7N0Z+Sd5ST3uM2P8wfNpH
8MKRNvMaV+/G11yPYgqHjOwdZMTGtMH/JLmgNx2YUO9I6FYLNi2m1W8imWyCch1E
/WC3W+7dgYzGM5g9pZ5qUzwDh/zgEYyptK+gD2fBsgjThomS3F7XSvjje32ABo7A
/t1H/j2Cg/tPn0wqXNyd6q4uWsVid9cZxip7IGZAUXf1+tEIgbuNK45Mk4FoyZBW
mlpFGySIJ10ZDoH5uhm/fubDGybcFFjapwGqhsgql/WhuYJMIWYlt6qp33fxfgDp
rnlZXYKEmwCYXUf3vRDgdFQ4HI1CC/79U5eaF6S6WKlbYTcgIF2AnAzcBed/+JoU
xtMDDPUr67i+3Ncuq0ze7TXwPibM3jUkBswxeIlPCBfL6TDjEOQ+VM9i863UOnGN
W7oqsAkh0mPV3GFWPzEfaVnMJNRTPPVeL4z8/BmIM55O7l7gss3WCCTSRSXO2bo2
ADrbb+Sy7AqC6SDBJcLWcZtKOYNCj0bQxV0uFWKDVPQi9UaI+8F/9pRGHJaJEGev
RnbOBn4pI0TA1wb/cSK2bHhJrVtTMmasYfMxkZEC8k/gU4v8IRmwpPPxZhBfp9fN
u5CgTZCeOw7FGLBv07b3/KVy71v6dnmgzwX8iZkbEBHpfIb9uIw=
=a9MC
-----END PGP SIGNATURE-----

--Apple-Mail=_3E79795F-7D55-4288-BA90-7176671DD6BF--