Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp2015375rwb; Thu, 15 Dec 2022 18:12:06 -0800 (PST) X-Google-Smtp-Source: AA0mqf5WXqdJqhdy9Uj5Qvd2w2MJYxFKFayn6MZ6vd17X/4ekAPmw4AvcDWW4MggjqtIM2VK19tH X-Received: by 2002:a05:6a20:b2a4:b0:af:80bb:1483 with SMTP id ei36-20020a056a20b2a400b000af80bb1483mr7236330pzb.55.1671156726744; Thu, 15 Dec 2022 18:12:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671156726; cv=none; d=google.com; s=arc-20160816; b=I4CGja6EJyS7f0atnI2/sT8XnME8c05r3QokTHIh+xs3LpWwn3VODRRJ1eOJxKyttU ZpQa017m2BCu22X/0LArlYMwt2LYF00mDAxRgwnNMOORZpmq2acw+0CkaN1GKV637RHM s+CkEYPHbaIFH5zFxp+CWphkh9lKB7BwaNqgEKlkFcfTaN34J1wk5dpMPp02jVK1pE8u w8r909M5YYBawMedNmyRwT9VGNng8onLrhcKDHA2CHVNpzan7+5KQL6m7VkNhnJqj9lU 1dAMbUYlX3UkxudZL7TqWpSfYe3dW9z/L/mugoa1bMz8HLFxtktTGj6O1mLezfAYwbgs +nVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=e02A3aKKE1KFtmTpiDh0G9R+xSN1Czem5UA155kzumk=; b=lvhJjnae83fhxUOr8YScSsQC6RdOmChQWN6AEFFsyqpAcB63LeWkCqqYY9mZDf5Tqr 4HzTlin/fvirTA7lc9Za8tibFvVBWTx1tf1HYtlpqUtDelm4CXt1cuMeAz4SoelfmmWM PzozJPQ8xEfL4mit2A8EI4wMltSuydpwVvT9jAgdJ8Xq3aQ1r4kOqdG8N0mZsj6mLIvD RzmpEMljVPC1ypv9HTHsllmpzfROD91EqwlYT7BcxmF3U3x4dNbQlTfuw9cIDF7E1zP8 MKikgodA/aZiVXAF8mZpOgpz/r/gmV6sI5Gzz+Hhm+C6TQBxuoDFa381LJWg3LP/HdSm VWtQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b=Gy0di33j; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f70-20020a636a49000000b00478794d20e5si1173575pgc.407.2022.12.15.18.11.47; Thu, 15 Dec 2022 18:12:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b=Gy0di33j; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229675AbiLPCLo (ORCPT + 99 others); Thu, 15 Dec 2022 21:11:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229611AbiLPCLn (ORCPT ); Thu, 15 Dec 2022 21:11:43 -0500 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8662E389D6 for ; Thu, 15 Dec 2022 18:11:42 -0800 (PST) Received: from cwcc.thunk.org (pool-173-48-120-46.bstnma.fios.verizon.net [173.48.120.46]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 2BG2BMNq009691 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Dec 2022 21:11:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1671156685; bh=e02A3aKKE1KFtmTpiDh0G9R+xSN1Czem5UA155kzumk=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=Gy0di33jqH4RW1/P2M/zt/kI5vJa6AopjA3rbIFhWiWiWftWk1H3lWGBEuoJiU7v8 Xk2y/tvY8Cj8R71Pkx36zeWRhN0gndP8kL/2vIF61QxVO4I5jwbK8TLOWCfsehcrL6 rWFQskdFARu2CQohek4PtWq0MSh1CQN6bIT1BVnPERG92dg8CmO+rmnMChTebwxy4z eHMvkSmeVgVBwrhQRhL3YiN6SjFCaonqd8vqeiPvl4atn7G2dcppfBgEuB5UdnXFg+ wkEM9EETSp8l92rI89M3Z6grkboB1+BwIcNHVFJrDOp7PRqVnfQfpJNiD7SB5OatZj 8a4zaLSfdu8VA== Received: by cwcc.thunk.org (Postfix, from userid 15806) id 8834915C40A2; Thu, 15 Dec 2022 21:11:22 -0500 (EST) Date: Thu, 15 Dec 2022 21:11:22 -0500 From: "Theodore Ts'o" To: syzbot Cc: adilger.kernel@dilger.ca, gregkh@linuxfoundation.org, lczerner@redhat.com, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, sashal@kernel.org, stable@vger.kernel.org, syzkaller-android-bugs@googlegroups.com, tadeusz.struk@linaro.org Subject: Re: kernel BUG in ext4_free_blocks (2) Message-ID: References: <0000000000006c411605e2f127e5@google.com> <000000000000b60c1105efe06dea@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <000000000000b60c1105efe06dea@google.com> X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,RCVD_IN_DNSWL_MED,SORTED_RECIPS,SPF_HELO_NONE,SPF_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Dec 15, 2022 at 08:34:35AM -0800, syzbot wrote: > This bug is marked as fixed by commit: > ext4: block range must be validated before use in ext4_mb_clear_bb() > But I can't find it in any tested tree for more than 90 days. > Is it a correct commit? Please update it by replying: > #syz fix: exact-commit-title > Until then the bug is still considered open and > new crashes with the same signature are ignored. I don't know what is going on with syzkaller's commit detection, but commit 1e1c2b86ef86 ("ext4: block range must be validated before use in ext4_mb_clear_bb()") is an exact match for the commit title, and it's been in the upstream kernel since v6.0. How do we make syzkaller accept this? I'll try this again, but I don't hold out much hope. #syz fix: ext4: block range must be validated before use in ext4_mb_clear_bb() Syzkaller, go home, you're drunk. - Ted