Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 30 Dec 2022 12:13:25 -0800
From:   Eric Biggers <ebiggers@kernel.org>
To:     Jun Nie <jun.nie@linaro.org>
Cc:     tytso@mit.edu, adilger.kernel@dilger.ca,
        linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
        tudor.ambarus@linaro.org
Subject: Re: [PATCH 2/2] ext4: refuse to create ea block when umounted
Message-ID: <Y69GZdLcWkCvZhq1@sol.localdomain>
References: <20221230110016.476621-1-jun.nie@linaro.org>
 <20221230110016.476621-2-jun.nie@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221230110016.476621-2-jun.nie@linaro.org>
Precedence: bulk

On Fri, Dec 30, 2022 at 07:00:16PM +0800, Jun Nie wrote:
> The ea block expansion need to access s_root while it is
> already set as NULL when umount is triggered. Refuse this
> request to avoid panic.
> 
> Reported-by: syzbot+2dacb8f015bf1420155f@syzkaller.appspotmail.com
> Link: https://syzkaller.appspot.com/bug?id=3613786cb88c93aa1c6a279b1df6a7b201347d08
> Signed-off-by: Jun Nie <jun.nie@linaro.org>
> ---
>  fs/ext4/xattr.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c
> index 235a517d9c17..ac58494e49b6 100644
> --- a/fs/ext4/xattr.c
> +++ b/fs/ext4/xattr.c
> @@ -1422,6 +1422,12 @@ static struct inode *ext4_xattr_inode_create(handle_t *handle,
>  	uid_t owner[2] = { i_uid_read(inode), i_gid_read(inode) };
>  	int err;
>  
> +	if (inode->i_sb->s_root == NULL) {
> +		ext4_error(inode->i_sb,
> +			   "refuse to create EA inode when umounting");
> +		return ERR_PTR(-EINVAL);
> +	}
> +

Why is an xattr being set during unmount?

- Eric