Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 2 Jan 2023 20:30:10 -0800
From:   Ira Weiny <ira.weiny@intel.com>
To:     "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
CC:     Theodore Ts'o <tytso@mit.edu>,
        Andreas Dilger <adilger.kernel@dilger.ca>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Tom Rix <trix@redhat.com>, <linux-ext4@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <llvm@lists.linux.dev>,
        <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] fs/ext4: Replace kmap_atomic() with kmap_local_page()
Message-ID: <Y7OvUjWtYPTJYjbU@iweiny-mobl>
References: <20221231174439.8557-1-fmdefrancesco@gmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20221231174439.8557-1-fmdefrancesco@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?mFiYqqlRCm2+oJgAOeRIenz9bkNwtbU2LnEdte0xJAV5UZgS2TTNxVngwl9v?=
 =?us-ascii?Q?5s8is4SclT7i6bB9afBBn0CPYqVro0sa9vTsYq511SypIqO8yQ5qygYs6ynU?=
 =?us-ascii?Q?ZUYfZv+snNElr/P/huG+e9HBnt2BHnbHfzmPkGSIFID7M+JO/hbVmfKNfetA?=
 =?us-ascii?Q?7vrxg+xp5+yqlurGWmzoW5uxRiAjWkVIVc8TFFelEUBvXvz8Oz6w69M66fTG?=
 =?us-ascii?Q?eTr0+cHJYkCvWIx3iivze8wuZBOLumWlabzWvLiJIoeKkUj8XwfFcAs535Ws?=
 =?us-ascii?Q?4ovqkReubuAembdPuejBXl+/rhcL8Ka9hDXZIH1rTpVxNE2X1s75lCzfhGfI?=
 =?us-ascii?Q?BxvCBNU+44rXV2JJVGWF+KalBQNscIXs0tdmxXE9faNk2ilFo5dXVN2YZE7H?=
 =?us-ascii?Q?Q6124+Q2pATX0HCCdP/hwg/2Ch8TG0+idAQrqK4XyrBW7YtvISxrOpwNV0zx?=
 =?us-ascii?Q?E2sGSiGzO16YiBj3i5PlV3y4eSDs8WQXHu4k/J1ehn/kk4cokuyzNcz2U3jy?=
 =?us-ascii?Q?djlBiKFnB0MMAm7zp3I5VtybjsfVjnBHnfHoes6xUuoR0RJlAnI5CLmx6BBD?=
 =?us-ascii?Q?4Qr8bdJohXW0CRLOSSpcW3ArlA6ZtlEKHAW2+1VwdaAOsSmdsZ/mDw+ENGMW?=
 =?us-ascii?Q?LKBkGEeL0AKuohTcEc1d6yyVRGN/S9JaQCHUkhBQfKMDJJTQbbAs6t7tQ4SR?=
 =?us-ascii?Q?L+79nHlqnbCKoAy4r69hY804MHkVqcm4lRlm2eWe8H9iqQS9V8yPRaZ0ozoA?=
 =?us-ascii?Q?rDRyfXH4T3jv5uVGewrrsIY+QdTwB5e9yvf+tjcyocvSj8OGZJYoAbl0aTWe?=
 =?us-ascii?Q?c/yT+Za7crH5RYozx2OiXR61RS0XY2+UeZdtQhgpnb29oxYZtTTn/0IFc5WT?=
 =?us-ascii?Q?EVUyrqFAwo2hUPDt0dlGKzO5iY8PbofBZsK1Z9xS+oR8tyhC1ojtNCsO/MdK?=
 =?us-ascii?Q?ckfWqI/nqmwzOC9gkiyJhCZWvIUsFcgCqVQPgQxdTX9SnZGp1u89AzLYbzOD?=
 =?us-ascii?Q?Wq3HiUYFDh74tquEgM0S0pcpcuOpOKPB7vfHWafgRGhk5f5lJtByifEfWI5J?=
 =?us-ascii?Q?eQ24bKSDRKqQuCBl3/OSj/AmpM/T8UN3t9Kd9PUVF+XSz34GMe8+cpEV2Oig?=
 =?us-ascii?Q?RnPyfxXPbW+JsCmkadBu5tuvTg7RuEbJcty6eqzxca3y0FiHAWJRlGhqsYWZ?=
 =?us-ascii?Q?G9sV6ngfV4elP39u+0WF59/adm9UFMqdG+8wzz+vejZgIAItuS7NvlDOIjyC?=
 =?us-ascii?Q?P10qhhA9ez1emJnSL2c250RronhSAKZg/voghfus2B5DMtxOOKYL/OQBc1TC?=
 =?us-ascii?Q?kewi9G9uUs9d//z5cmxZtUQZcsANMU0Xs63sheWxnIU85r/q4AG5eaNX+YuO?=
 =?us-ascii?Q?yK6vs9exmU2KHkHl/KJ/biwvCDNBVZdzke6SH231bajO3x1Zjl0SrPTE7g5k?=
 =?us-ascii?Q?dyNa2n7FT83HmJ2ZEDdcg9MKgWzAH0r3kLO6tGCCwg9Twu3CqC/y0OzOE7J0?=
 =?us-ascii?Q?2LP3YJAdhUJcJGtmwWD4ubYg6d9/lDRPTs3EXDyBi4pcQnhgS0qR0FB00Avd?=
 =?us-ascii?Q?pyEcw/Uece+HLolyvGoo0efarjJhJEARjKChSmpa?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 11d6bd5e-97bc-43d5-079c-08daed4335ce
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2023 04:30:14.9173
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eKhYRkcT7o8nhRGqCSN6QNreb6PkQamvvrw+iqHpdDg7wAKz+AG1gsmx6IpIHjTYN8ylH+h6K5a10ftEtahJng==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6199
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-ext4.vger.kernel.org>
X-Mailing-List: linux-ext4@vger.kernel.org

On Sat, Dec 31, 2022 at 06:44:39PM +0100, Fabio M. De Francesco wrote:
> kmap_atomic() is deprecated in favor of kmap_local_page(). Therefore,
> replace kmap_atomic() with kmap_local_page().
> 
> kmap_atomic() is implemented like a kmap_local_page() which also disables
> page-faults and preemption (the latter only for !PREEMPT_RT kernels).
> 
> However, the code within the mappings and un-mappings in ext4/inline.c
> does not depend on the above-mentioned side effects.
> 
> Therefore, a mere replacement of the old API with the new one is all it
> is required (i.e., there is no need to explicitly add any calls to
> pagefault_disable() and/or preempt_disable()).
> 
> Suggested-by: Ira Weiny <ira.weiny@intel.com>

Reviewed-by: Ira Weiny <ira.weiny@intel.com>

> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> ---
> 
> I tried my best to understand the code within mapping and un-mapping.
> However, I'm not an expert. Therefore, although I'm pretty confident, I
> cannot be 100% sure that the code between the mapping and the un-mapping
> does not depend on pagefault_disable() and/or preempt_disable().
> 
> Unfortunately, I cannot currently test this changes to check the
> above-mentioned assumptions. However, if I'm required to do the tests
> with (x)fstests, I have no problems with doing them in the next days.
> 
> If so, I'll test in a QEMU/KVM x86_32 VM, 6GB RAM, booting a kernel with
> HIGHMEM64GB enabled.
> 
> I'd like to hear whether or not the maintainers require these tests
> and/or other tests.
> 
>  fs/ext4/inline.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/fs/ext4/inline.c b/fs/ext4/inline.c
> index 2b42ececa46d..bfb044425d8a 100644
> --- a/fs/ext4/inline.c
> +++ b/fs/ext4/inline.c
> @@ -490,10 +490,10 @@ static int ext4_read_inline_page(struct inode *inode, struct page *page)
>  		goto out;
>  
>  	len = min_t(size_t, ext4_get_inline_size(inode), i_size_read(inode));
> -	kaddr = kmap_atomic(page);
> +	kaddr = kmap_local_page(page);
>  	ret = ext4_read_inline_data(inode, kaddr, len, &iloc);
>  	flush_dcache_page(page);
> -	kunmap_atomic(kaddr);
> +	kunmap_local(kaddr);
>  	zero_user_segment(page, len, PAGE_SIZE);
>  	SetPageUptodate(page);
>  	brelse(iloc.bh);
> @@ -763,9 +763,9 @@ int ext4_write_inline_data_end(struct inode *inode, loff_t pos, unsigned len,
>  		 */
>  		(void) ext4_find_inline_data_nolock(inode);
>  
> -		kaddr = kmap_atomic(page);
> +		kaddr = kmap_local_page(page);
>  		ext4_write_inline_data(inode, &iloc, kaddr, pos, copied);
> -		kunmap_atomic(kaddr);
> +		kunmap_local(kaddr);
>  		SetPageUptodate(page);
>  		/* clear page dirty so that writepages wouldn't work for us. */
>  		ClearPageDirty(page);
> @@ -831,9 +831,9 @@ ext4_journalled_write_inline_data(struct inode *inode,
>  	}
>  
>  	ext4_write_lock_xattr(inode, &no_expand);
> -	kaddr = kmap_atomic(page);
> +	kaddr = kmap_local_page(page);
>  	ext4_write_inline_data(inode, &iloc, kaddr, 0, len);
> -	kunmap_atomic(kaddr);
> +	kunmap_local(kaddr);
>  	ext4_write_unlock_xattr(inode, &no_expand);
>  
>  	return iloc.bh;
> -- 
> 2.39.0
>