Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 4 Jan 2023 11:23:26 +0100
From:   Lukas Czerner <lczerner@redhat.com>
To:     Eric Biggers <ebiggers@kernel.org>
Cc:     linux-ext4@vger.kernel.org, Andreas Dilger <adilger@dilger.ca>
Subject: Re: [e2fsprogs PATCH] libext2fs: remove unused variable in
 ext2fs_xattrs_read_inode()
Message-ID: <20230104102326.eoitvoj3bbcp6oqd@fedora>
References: <20230104090314.276028-1-ebiggers@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230104090314.276028-1-ebiggers@kernel.org>
Precedence: bulk

On Wed, Jan 04, 2023 at 01:03:14AM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
> 
> Address the following compiler warning with gcc -Wall:
> 
> ext_attr.c: In function ‘ext2fs_xattrs_read_inode’:
> ext_attr.c:1000:16: warning: unused variable ‘i’ [-Wunused-variable]
>  1000 |         size_t i;
>       |                ^

You might as well remove the unnecessary newline at the top of the
function.

But regardless, you can add.

Reviewed-by: Lukas Czerner <lczerner@redhat.com>

Thanks!
-Lukas

> 
> Cc: Andreas Dilger <adilger@dilger.ca>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
>  lib/ext2fs/ext_attr.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/lib/ext2fs/ext_attr.c b/lib/ext2fs/ext_attr.c
> index d36fe68d..6fc4214c 100644
> --- a/lib/ext2fs/ext_attr.c
> +++ b/lib/ext2fs/ext_attr.c
> @@ -997,7 +997,6 @@ errcode_t ext2fs_xattrs_read_inode(struct ext2_xattr_handle *handle,
>  	unsigned int storage_size;
>  	char *start, *block_buf = NULL;
>  	blk64_t blk;
> -	size_t i;
>  	errcode_t err = 0;
>  
>  	EXT2_CHECK_MAGIC(handle, EXT2_ET_MAGIC_EA_HANDLE);
> -- 
> 2.39.0
>