Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 4 Jan 2023 11:25:38 +0100
From:   Lukas Czerner <lczerner@redhat.com>
To:     Eric Biggers <ebiggers@kernel.org>
Cc:     linux-ext4@vger.kernel.org
Subject: Re: [e2fsprogs PATCH] libsupport: remove unused label in
 get_devname()
Message-ID: <20230104102538.bbttn6is7w6gdsbo@fedora>
References: <20230104090341.276131-1-ebiggers@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230104090341.276131-1-ebiggers@kernel.org>
Precedence: bulk

On Wed, Jan 04, 2023 at 01:03:41AM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
> 
> Address the following compiler warning with gcc -Wall:
> 
> devname.c: In function ‘get_devname’:
> devname.c:61:1: warning: label ‘out_strdup’ defined but not used [-Wunused-label]
>    61 | out_strdup:
>       | ^~~~~~~~~~

Looks good, thanks!

Reviewed-by: Lukas Czerner <lczerner@redhat.com>


> 
> Cc: Lukas Czerner <lczerner@redhat.com>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
>  lib/support/devname.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/lib/support/devname.c b/lib/support/devname.c
> index 8c2349a3..e0306ddf 100644
> --- a/lib/support/devname.c
> +++ b/lib/support/devname.c
> @@ -58,7 +58,6 @@ char *get_devname(blkid_cache cache, const char *token, const char *value)
>  		goto out;
>  	}
>  
> -out_strdup:
>  	if (is_file)
>  		ret = strdup(token);
>  out:
> -- 
> 2.39.0
>