Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp5160744rwl;
        Sun, 8 Jan 2023 09:33:00 -0800 (PST)
X-Google-Smtp-Source: AMrXdXvg30+f2Uc8IjX9j7BRZLsMhpDCcnu0IqsaNjtSG/g1Zzdv3TsvkGJPuX8CdCAFK57nKDTK
X-Received: by 2002:a17:906:311b:b0:7c1:64dc:ac25 with SMTP id 27-20020a170906311b00b007c164dcac25mr53448968ejx.23.1673199180133;
        Sun, 08 Jan 2023 09:33:00 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1673199180; cv=none;
        d=google.com; s=arc-20160816;
        b=iCVXfeDdfBxOlFaMAOZ4ozqLXW6bzv6Dikd76WPYOiy401bwrgRz6N526XYJYe3S8S
         JCMVVMXanxWVR+9/03coPHwOefp7GoN06lq2rfEvkOm5ectjl54e8eArd0SEQD3GCC2c
         njVJlsPdcyj49VBpJmWZYHX+UMAo+B0qN6N460/DLSRJGo9OSBa4XLLik2fn2npzjkd7
         ygQOwQMoj7cx/ijNsTtySktehOlfQ8JqLRwptZ8xzCx9E6t8secEelnmoE7Bhkr8Y4cl
         igN9p+7kyMKa5Uo+8vm7ZPK3zYhVFrGEkWIDyjPLZfM1YxLK1GITM6yp5VYDOmtUUXi/
         M+Cw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:in-reply-to:content-disposition:mime-version
         :references:message-id:subject:cc:to:from:date:dkim-signature;
        bh=j1yO3Mkjepz9lCRA0UQQCZNzrS+IEn6ws1vaF0OS/0U=;
        b=pgNUHZgmM9M5x80TJ3oU+TELvOBbFLi/RWl8iEqoRU/Zz39+/3wXpPamQ05wPmEfg5
         la4oycwcsTw56Lz9/zgKW0N7Gnp4K0ZxtwX0S14SIrsTn2PwWuXZHM/Q82xJwLeNn4TD
         eTb0x6mZpWth4NyU24jMdte6X+EnnVAocy8Li0IJuDUNKaxuSUzm6UCkVucB4KGEpdJ2
         YIHJUAQaztkegAAImH/oVVMpiZLrVH0XVhFy5edETzCIdmWNdVUOT5CVyNupHa3ZJpzi
         xWUFTU0ll9YKYxLfqqAH4ATZZmI1PRrMiy01jLWmMSmIsuZZ9yqt9cNO+p1cHFHF+Hnd
         jMPA==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=B6VDIscm;
       spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org
Return-Path: <linux-ext4-owner@vger.kernel.org>
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
        by mx.google.com with ESMTP id b12-20020a056402278c00b004615937b174si8268262ede.480.2023.01.08.09.32.36;
        Sun, 08 Jan 2023 09:33:00 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=B6VDIscm;
       spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S231253AbjAHRbT (ORCPT <rfc822;aminbrickmover@gmail.com>
        + 99 others); Sun, 8 Jan 2023 12:31:19 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57104 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229520AbjAHRbS (ORCPT
        <rfc822;linux-ext4@vger.kernel.org>); Sun, 8 Jan 2023 12:31:18 -0500
Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F2C6D11C;
        Sun,  8 Jan 2023 09:31:18 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version
        :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description;
        bh=j1yO3Mkjepz9lCRA0UQQCZNzrS+IEn6ws1vaF0OS/0U=; b=B6VDIscmO8fbl4lLFNJU1MLiB+
        h4YPrQ4XMzW3mjzPdC1/aZm7EFAIOa4tyfG4jz5p33Kf1hJa9SdlW2afin0l4qj9l7RsZJ+7hXVDF
        uvWJKdtAxu8r5ZN3SQj7f4sWXoduaVVQpKfU+A9It4vL6rv3IZsLaPpgNNxp0j1sZ/GY90xW/GmNg
        keiKYLORjbKsojiPhFJ2eQqD0oOpWxVpwElJeV2FQ8BRugBMHIz+dgRBmvr7nOHEnCkiaVBSk6mHi
        Gi7BiXT1oWrYyXHBDrb9j782NUw5WXVU3wk5emi6yu/c0v7+8kiIvGlVnCvlFo9dc4rHMa6KaRuuT
        fnqO26jA==;
Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux))
        id 1pEZVq-00Eci3-9x; Sun, 08 Jan 2023 17:31:14 +0000
Date:   Sun, 8 Jan 2023 09:31:14 -0800
From:   Christoph Hellwig <hch@infradead.org>
To:     Andreas Gruenbacher <agruenba@redhat.com>
Cc:     Christoph Hellwig <hch@infradead.org>,
        "Darrick J . Wong" <djwong@kernel.org>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Matthew Wilcox <willy@infradead.org>,
        linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-ext4@vger.kernel.org, cluster-devel@redhat.com
Subject: Re: [PATCH v5 6/9] iomap: Rename page_prepare handler to get_folio
Message-ID: <Y7r94noBbxi7612G@infradead.org>
References: <20221231150919.659533-1-agruenba@redhat.com>
 <20221231150919.659533-7-agruenba@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221231150919.659533-7-agruenba@redhat.com>
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-ext4.vger.kernel.org>
X-Mailing-List: linux-ext4@vger.kernel.org

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

although it might make sense to just do the rename in patch 5 which
changes the signature to return a folio?