Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH RFC v7 08/23] dept: Apply sdt_might_sleep_strong() to
 PG_{locked,writeback} wait
To:     Byungchul Park <byungchul.park@lge.com>,
        <linux-kernel@vger.kernel.org>
CC:     <torvalds@linux-foundation.org>,
        <damien.lemoal@opensource.wdc.com>, <linux-ide@vger.kernel.org>,
        <adilger.kernel@dilger.ca>, <linux-ext4@vger.kernel.org>,
        <mingo@redhat.com>, <peterz@infradead.org>, <will@kernel.org>,
        <tglx@linutronix.de>, <rostedt@goodmis.org>,
        <joel@joelfernandes.org>, <sashal@kernel.org>,
        <daniel.vetter@ffwll.ch>, <duyuyang@gmail.com>,
        <johannes.berg@intel.com>, <tj@kernel.org>, <tytso@mit.edu>,
        <willy@infradead.org>, <david@fromorbit.com>, <amir73il@gmail.com>,
        <gregkh@linuxfoundation.org>, <kernel-team@lge.com>,
        <linux-mm@kvack.org>, <akpm@linux-foundation.org>,
        <mhocko@kernel.org>, <minchan@kernel.org>, <hannes@cmpxchg.org>,
        <vdavydov.dev@gmail.com>, <sj@kernel.org>, <jglisse@redhat.com>,
        <dennis@kernel.org>, <cl@linux.com>, <penberg@kernel.org>,
        <rientjes@google.com>, <vbabka@suse.cz>, <ngupta@vflare.org>,
        <linux-block@vger.kernel.org>, <paolo.valente@linaro.org>,
        <josef@toxicpanda.com>, <linux-fsdevel@vger.kernel.org>,
        <viro@zeniv.linux.org.uk>, <jack@suse.cz>, <jlayton@kernel.org>,
        <dan.j.williams@intel.com>, <hch@infradead.org>,
        <djwong@kernel.org>, <dri-devel@lists.freedesktop.org>,
        <rodrigosiqueiramelo@gmail.com>, <melissa.srw@gmail.com>,
        <hamohammed.sa@gmail.com>, <42.hyeyoo@gmail.com>,
        <chris.p.wilson@intel.com>, <gwan-gyeong.mun@intel.com>
References: <1673235231-30302-1-git-send-email-byungchul.park@lge.com>
 <1673235231-30302-9-git-send-email-byungchul.park@lge.com>
From:   Sergey Shtylyov <s.shtylyov@omp.ru>
Organization: Open Mobile Platform
Message-ID: <e8b24129-536c-a367-1436-fe0e054259cf@omp.ru>
Date:   Mon, 9 Jan 2023 12:10:15 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <1673235231-30302-9-git-send-email-byungchul.park@lge.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-KSE-AttachmentFiltering-Interceptor-Info: protection disabled
X-KSE-Antivirus-Interceptor-Info: scan successful
X-KSE-Antivirus-Info: Clean, bases: 1/9/2023 6:18:00 AM
X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NICE_REPLY_A,
        SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-ext4.vger.kernel.org>
X-Mailing-List: linux-ext4@vger.kernel.org

On 1/9/23 6:33 AM, Byungchul Park wrote:

> Makes Dept able to track dependencies by PG_{locked,writeback} waits.
> 
> Signed-off-by: Byungchul Park <byungchul.park@lge.com>
> ---
>  mm/filemap.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/mm/filemap.c b/mm/filemap.c
> index c4d4ace..b013a5b 100644
> --- a/mm/filemap.c
> +++ b/mm/filemap.c
[...]
> @@ -1226,6 +1230,11 @@ static inline int folio_wait_bit_common(struct folio *folio, int bit_nr,
>  	unsigned long pflags;
>  	bool in_thrashing;
>  
> +	if (bit_nr == PG_locked)
> +		sdt_might_sleep_strong(&PG_locked_map);
> +	else if (bit_nr == PG_writeback)
> +		sdt_might_sleep_strong(&PG_writeback_map);

   Hm, this is asking to be a *switch* statement instead...

[...]

MBR, Sergey